[INFO] updating cached repository pjhades/izzet [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pjhades/izzet [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pjhades/izzet" "work/ex/clippy-test-run/sources/stable/gh/pjhades/izzet"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pjhades/izzet'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pjhades/izzet" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjhades/izzet"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjhades/izzet'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6e310cef91480c9671d87d4e2810b1aaeae0dafc [INFO] sha for GitHub repo pjhades/izzet: 6e310cef91480c9671d87d4e2810b1aaeae0dafc [INFO] validating manifest of pjhades/izzet on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pjhades/izzet on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pjhades/izzet [INFO] finished frobbing pjhades/izzet [INFO] frobbed toml for pjhades/izzet written to work/ex/clippy-test-run/sources/stable/gh/pjhades/izzet/Cargo.toml [INFO] started frobbing pjhades/izzet [INFO] finished frobbing pjhades/izzet [INFO] frobbed toml for pjhades/izzet written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjhades/izzet/Cargo.toml [INFO] crate pjhades/izzet has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pjhades/izzet against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pjhades/izzet:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c673ffe3ad4e7c3a0f3d3f887bc12e69a357e4ccec3a41637a2ae4f6655fabf9 [INFO] running `"docker" "start" "-a" "c673ffe3ad4e7c3a0f3d3f887bc12e69a357e4ccec3a41637a2ae4f6655fabf9"` [INFO] [stderr] Checking humansize v1.0.1 [INFO] [stderr] Checking pest v0.4.1 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking url v0.2.38 [INFO] [stderr] Checking tera v0.10.10 [INFO] [stderr] Checking tiny_http v0.5.8 [INFO] [stderr] Checking izzet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/post.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | Ok(n) if n > 0 && &line != POST_META_MARK => { [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/post.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if meta.url.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `meta.url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/post.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | post.meta.url = match &kind { [INFO] [stderr] | _____________________^ [INFO] [stderr] 141 | | &PostKind::Article => DEFAULT_ARTICLE_URL.to_string(), [INFO] [stderr] 142 | | &PostKind::Page => DEFAULT_PAGE_URL.to_string(), [INFO] [stderr] 143 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | post.meta.url = match kind { [INFO] [stderr] 141 | PostKind::Article => DEFAULT_ARTICLE_URL.to_string(), [INFO] [stderr] 142 | PostKind::Page => DEFAULT_PAGE_URL.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/conf.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / f.write(b"force = true\n\ [INFO] [stderr] 56 | | in_dir = \".\"\n\ [INFO] [stderr] 57 | | port = 9999\n\ [INFO] [stderr] 58 | | title = \"title\"").unwrap(); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/post.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | Ok(n) if n > 0 && &line != POST_META_MARK => { [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/post.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if meta.url.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `meta.url.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/post.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | post.meta.url = match &kind { [INFO] [stderr] | _____________________^ [INFO] [stderr] 141 | | &PostKind::Article => DEFAULT_ARTICLE_URL.to_string(), [INFO] [stderr] 142 | | &PostKind::Page => DEFAULT_PAGE_URL.to_string(), [INFO] [stderr] 143 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | post.meta.url = match kind { [INFO] [stderr] 141 | PostKind::Article => DEFAULT_ARTICLE_URL.to_string(), [INFO] [stderr] 142 | PostKind::Page => DEFAULT_PAGE_URL.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/post.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / fs::OpenOptions::new().append(true) [INFO] [stderr] 170 | | .open(&path).unwrap() [INFO] [stderr] 171 | | .write(b"XXX").unwrap(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/post.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | file.write(POST_META_MARK.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/post.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / file.write(b"title = \"xxx\"\n\ [INFO] [stderr] 217 | | link = \"yyy\"\n\ [INFO] [stderr] 218 | | url = \"\"\n\ [INFO] [stderr] 219 | | ts = \"2017-12-04T20:23:37.463860-05:00\"\n\ [INFO] [stderr] 220 | | kind = \"Page\"\n") [INFO] [stderr] 221 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/post.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | file.write(POST_META_MARK.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `izzet`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | .unwrap_or(izzet::CONFIG_FILE.to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| izzet::CONFIG_FILE.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if let None = conf.title { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 37 | | conf.title = Some("Default title".to_string()); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____- help: try this: `if conf.title.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .ok_or(Error::new("need specify path to the article".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("need specify path to the article".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | .ok_or(Error::new("need specify path to the page".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("need specify path to the page".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | .unwrap_or(izzet::CONFIG_FILE.to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| izzet::CONFIG_FILE.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if let None = conf.title { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 37 | | conf.title = Some("Default title".to_string()); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____- help: try this: `if conf.title.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .ok_or(Error::new("need specify path to the article".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("need specify path to the article".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | .ok_or(Error::new("need specify path to the page".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("need specify path to the page".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c673ffe3ad4e7c3a0f3d3f887bc12e69a357e4ccec3a41637a2ae4f6655fabf9"` [INFO] running `"docker" "rm" "-f" "c673ffe3ad4e7c3a0f3d3f887bc12e69a357e4ccec3a41637a2ae4f6655fabf9"` [INFO] [stdout] c673ffe3ad4e7c3a0f3d3f887bc12e69a357e4ccec3a41637a2ae4f6655fabf9