[INFO] updating cached repository pjf/nms-compute [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pjf/nms-compute [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pjf/nms-compute" "work/ex/clippy-test-run/sources/stable/gh/pjf/nms-compute"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pjf/nms-compute'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pjf/nms-compute" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjf/nms-compute"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjf/nms-compute'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4aca50a69fa513766d5804869d269e3a9f3d1ff [INFO] sha for GitHub repo pjf/nms-compute: b4aca50a69fa513766d5804869d269e3a9f3d1ff [INFO] validating manifest of pjf/nms-compute on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pjf/nms-compute on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pjf/nms-compute [INFO] finished frobbing pjf/nms-compute [INFO] frobbed toml for pjf/nms-compute written to work/ex/clippy-test-run/sources/stable/gh/pjf/nms-compute/Cargo.toml [INFO] started frobbing pjf/nms-compute [INFO] finished frobbing pjf/nms-compute [INFO] frobbed toml for pjf/nms-compute written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjf/nms-compute/Cargo.toml [INFO] crate pjf/nms-compute has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pjf/nms-compute against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pjf/nms-compute:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6529dbfc44a4776c81443c096642571e41962c6bdf52200f2cfdd722a64f75d7 [INFO] running `"docker" "start" "-a" "6529dbfc44a4776c81443c096642571e41962c6bdf52200f2cfdd722a64f75d7"` [INFO] [stderr] Checking encode_unicode v0.3.2 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking prettytable-rs v0.7.0 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking nms-compute v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | inputs.push(Input { resource: resource, qty: qty.as_i64().unwrap() as u32 }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | result.push(Recipe { name: name, inputs: inputs, output: output }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | result.push(Recipe { name: name, inputs: inputs, output: output }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:92:58 [INFO] [stderr] | [INFO] [stderr] 92 | result.push(Recipe { name: name, inputs: inputs, output: output }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | inputs: inputs [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | inputs.push(Input { resource: resource, qty: qty.as_i64().unwrap() as u32 }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | result.push(Recipe { name: name, inputs: inputs, output: output }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | result.push(Recipe { name: name, inputs: inputs, output: output }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:92:58 [INFO] [stderr] | [INFO] [stderr] 92 | result.push(Recipe { name: name, inputs: inputs, output: output }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/recipe.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | inputs: inputs [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resource.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const RESOURCES_FILE: &'static str = "Resources.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resource.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return read_resources(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_resources()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resource.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return ResourceMap(map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ResourceMap(map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/recipe.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const RECIPES_FILE: &'static str = "Recipes.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/recipe.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const REFINING_CSV: &'static str = "Refinery.csv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return recipes; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `recipes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / return Ok(Recipe { [INFO] [stderr] 165 | | name: record[6].to_string(), [INFO] [stderr] 166 | | output: output, [INFO] [stderr] 167 | | inputs: inputs [INFO] [stderr] 168 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 164 | Ok(Recipe { [INFO] [stderr] 165 | name: record[6].to_string(), [INFO] [stderr] 166 | output: output, [INFO] [stderr] 167 | inputs: inputs [INFO] [stderr] 168 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / return Ok(InputOutput { [INFO] [stderr] 176 | | resource, [INFO] [stderr] 177 | | qty [INFO] [stderr] 178 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 175 | Ok(InputOutput { [INFO] [stderr] 176 | resource, [INFO] [stderr] 177 | qty [INFO] [stderr] 178 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return yaml_from_file(filename).into_hash().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `yaml_from_file(filename).into_hash().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return yaml_from_file(filename).into_vec().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `yaml_from_file(filename).into_vec().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resource.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const RESOURCES_FILE: &'static str = "Resources.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resource.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return read_resources(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_resources()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resource.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return ResourceMap(map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ResourceMap(map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/recipe.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const RECIPES_FILE: &'static str = "Recipes.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/recipe.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const REFINING_CSV: &'static str = "Refinery.csv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return recipes; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `recipes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / return Ok(Recipe { [INFO] [stderr] 165 | | name: record[6].to_string(), [INFO] [stderr] 166 | | output: output, [INFO] [stderr] 167 | | inputs: inputs [INFO] [stderr] 168 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 164 | Ok(Recipe { [INFO] [stderr] 165 | name: record[6].to_string(), [INFO] [stderr] 166 | output: output, [INFO] [stderr] 167 | inputs: inputs [INFO] [stderr] 168 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/recipe.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / return Ok(InputOutput { [INFO] [stderr] 176 | | resource, [INFO] [stderr] 177 | | qty [INFO] [stderr] 178 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 175 | Ok(InputOutput { [INFO] [stderr] 176 | resource, [INFO] [stderr] 177 | qty [INFO] [stderr] 178 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return yaml_from_file(filename).into_hash().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `yaml_from_file(filename).into_hash().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return yaml_from_file(filename).into_vec().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `yaml_from_file(filename).into_vec().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/recipe.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.output_value() as f64 - self.input_value() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.output_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/recipe.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | self.output_value() as f64 - self.input_value() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.input_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/recipe.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | self.profit() / self.input_qty() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.input_qty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/recipe.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | let name = String::from(recipe.get(&Yaml::from_str("name")).unwrap().clone().into_string().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `recipe.get(&Yaml::from_str("name")).unwrap().clone().into_string().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/recipe.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | let fh = File::open(REFINING_CSV).expect(&format!("Could not open {}", REFINING_CSV)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open {}", REFINING_CSV))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/recipe.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.output_value() as f64 - self.input_value() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.output_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/recipe.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | self.output_value() as f64 - self.input_value() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.input_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/recipe.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | self.profit() / self.input_qty() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.input_qty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/recipe.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | let name = String::from(recipe.get(&Yaml::from_str("name")).unwrap().clone().into_string().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `recipe.get(&Yaml::from_str("name")).unwrap().clone().into_string().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/recipe.rs:101:39 [INFO] [stderr] | [INFO] [stderr] 101 | let fh = File::open(REFINING_CSV).expect(&format!("Could not open {}", REFINING_CSV)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open {}", REFINING_CSV))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/recipe.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | let resource = resources.get(resource).ok_or(format!("Resource '{}' lookup failed", resource))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Resource '{}' lookup failed", resource))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/recipe.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | let resource = resources.get(resource).ok_or(format!("Resource '{}' lookup failed", resource))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Resource '{}' lookup failed", resource))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | let mut fh = File::open(filename).expect(&format!("Could not open {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:106:34 [INFO] [stderr] | [INFO] [stderr] 106 | fh.read_to_string(&mut yaml).expect(&format!("Reading {} failed", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Reading {} failed", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | let mut fh = File::open(filename).expect(&format!("Could not open {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:106:34 [INFO] [stderr] | [INFO] [stderr] 106 | fh.read_to_string(&mut yaml).expect(&format!("Reading {} failed", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Reading {} failed", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.12s [INFO] running `"docker" "inspect" "6529dbfc44a4776c81443c096642571e41962c6bdf52200f2cfdd722a64f75d7"` [INFO] running `"docker" "rm" "-f" "6529dbfc44a4776c81443c096642571e41962c6bdf52200f2cfdd722a64f75d7"` [INFO] [stdout] 6529dbfc44a4776c81443c096642571e41962c6bdf52200f2cfdd722a64f75d7