[INFO] updating cached repository pixlark/rust-2048 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pixlark/rust-2048 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pixlark/rust-2048" "work/ex/clippy-test-run/sources/stable/gh/pixlark/rust-2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pixlark/rust-2048'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pixlark/rust-2048" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pixlark/rust-2048"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pixlark/rust-2048'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f79620db9330253800dcb3b96e933f669863a93a [INFO] sha for GitHub repo pixlark/rust-2048: f79620db9330253800dcb3b96e933f669863a93a [INFO] validating manifest of pixlark/rust-2048 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pixlark/rust-2048 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pixlark/rust-2048 [INFO] finished frobbing pixlark/rust-2048 [INFO] frobbed toml for pixlark/rust-2048 written to work/ex/clippy-test-run/sources/stable/gh/pixlark/rust-2048/Cargo.toml [INFO] started frobbing pixlark/rust-2048 [INFO] finished frobbing pixlark/rust-2048 [INFO] frobbed toml for pixlark/rust-2048 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pixlark/rust-2048/Cargo.toml [INFO] crate pixlark/rust-2048 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pixlark/rust-2048 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pixlark/rust-2048:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b27769eca435c6a53ed18d98ee770d72a53b6bb6378b2661618e40b7823533d [INFO] running `"docker" "start" "-a" "1b27769eca435c6a53ed18d98ee770d72a53b6bb6378b2661618e40b7823533d"` [INFO] [stderr] Compiling game-2048 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `sdl2::video::WindowContext` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use sdl2::video::WindowContext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::choose': use SliceRandom::choose instead [INFO] [stderr] --> src/main.rs:267:32 [INFO] [stderr] | [INFO] [stderr] 267 | let choice: u64 = *rng.choose(&[2, 4]).unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state_stack` [INFO] [stderr] --> src/main.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | let mut state_stack: Vec> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_state_stack` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | let mut state_stack: Vec> = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PlayingState` [INFO] [stderr] --> src/main.rs:286:1 [INFO] [stderr] | [INFO] [stderr] 286 | struct PlayingState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `v2` should have a camel case name such as `V2` [INFO] [stderr] --> src/main.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / struct v2 { [INFO] [stderr] 45 | | row: i32, [INFO] [stderr] 46 | | column: i32, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | / canvas.copy( [INFO] [stderr] 160 | | &texture, [INFO] [stderr] 161 | | None, [INFO] [stderr] 162 | | Some(Rect::new( [INFO] [stderr] ... | [INFO] [stderr] 167 | | )), [INFO] [stderr] 168 | | ); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `sdl2::video::WindowContext` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use sdl2::video::WindowContext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::Rng::choose': use SliceRandom::choose instead [INFO] [stderr] --> src/main.rs:267:32 [INFO] [stderr] | [INFO] [stderr] 267 | let choice: u64 = *rng.choose(&[2, 4]).unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state_stack` [INFO] [stderr] --> src/main.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | let mut state_stack: Vec> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_state_stack` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | let mut state_stack: Vec> = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PlayingState` [INFO] [stderr] --> src/main.rs:286:1 [INFO] [stderr] | [INFO] [stderr] 286 | struct PlayingState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `v2` should have a camel case name such as `V2` [INFO] [stderr] --> src/main.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / struct v2 { [INFO] [stderr] 45 | | row: i32, [INFO] [stderr] 46 | | column: i32, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | / canvas.copy( [INFO] [stderr] 160 | | &texture, [INFO] [stderr] 161 | | None, [INFO] [stderr] 162 | | Some(Rect::new( [INFO] [stderr] ... | [INFO] [stderr] 167 | | )), [INFO] [stderr] 168 | | ); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.90s [INFO] running `"docker" "inspect" "1b27769eca435c6a53ed18d98ee770d72a53b6bb6378b2661618e40b7823533d"` [INFO] running `"docker" "rm" "-f" "1b27769eca435c6a53ed18d98ee770d72a53b6bb6378b2661618e40b7823533d"` [INFO] [stdout] 1b27769eca435c6a53ed18d98ee770d72a53b6bb6378b2661618e40b7823533d