[INFO] updating cached repository pixix4/Robots-Rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/pixix4/Robots-Rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/pixix4/Robots-Rust" "work/ex/clippy-test-run/sources/stable/gh/pixix4/Robots-Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pixix4/Robots-Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/pixix4/Robots-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pixix4/Robots-Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pixix4/Robots-Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0ee861e53645de24e0b8b65625a1496d0fb557f1
[INFO] sha for GitHub repo pixix4/Robots-Rust: 0ee861e53645de24e0b8b65625a1496d0fb557f1
[INFO] validating manifest of pixix4/Robots-Rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pixix4/Robots-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pixix4/Robots-Rust
[INFO] finished frobbing pixix4/Robots-Rust
[INFO] frobbed toml for pixix4/Robots-Rust written to work/ex/clippy-test-run/sources/stable/gh/pixix4/Robots-Rust/Cargo.toml
[INFO] started frobbing pixix4/Robots-Rust
[INFO] finished frobbing pixix4/Robots-Rust
[INFO] frobbed toml for pixix4/Robots-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pixix4/Robots-Rust/Cargo.toml
[INFO] crate pixix4/Robots-Rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pixix4/Robots-Rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pixix4/Robots-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5e71a275f4ad674c61408617d93b227b27ca264a8a7b21d744e6e86679a9dcea
[INFO] running `"docker" "start" "-a" "5e71a275f4ad674c61408617d93b227b27ca264a8a7b21d744e6e86679a9dcea"`
[INFO] [stderr]     Checking ev3dev-lang-rust v0.4.0
[INFO] [stderr]     Checking robots-rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/network.rs:218:5
[INFO] [stderr]     |
[INFO] [stderr] 218 |     return stop_sender;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `stop_sender`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/driving.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     return driving_sender;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `driving_sender`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/pid.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return Ok((((red + green + blue) / 1.5).min(2.0).max(0.0) - 1.0) * DRIVE_MULTIPLIER);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((((red + green + blue) / 1.5).min(2.0).max(0.0) - 1.0) * DRIVE_MULTIPLIER)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pid.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pid.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 |     return pid_sender;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pid_sender`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pid.rs:192:5
[INFO] [stderr]     |
[INFO] [stderr] 192 |     return (r,g,b)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `(r,g,b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/status.rs:8:20
[INFO] [stderr]   |
[INFO] [stderr] 8 | const COLOR_LIME: &'static str = "lime";
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/status.rs:9:22
[INFO] [stderr]   |
[INFO] [stderr] 9 | const COLOR_YELLOW: &'static str = "yellow";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:10:21
[INFO] [stderr]    |
[INFO] [stderr] 10 | const COLOR_AMBER: &'static str = "amber";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | const COLOR_ORANGE: &'static str = "orange";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 | const COLOR_RED: &'static str = "red";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:13:19
[INFO] [stderr]    |
[INFO] [stderr] 13 | const COLOR_OFF: &'static str = "black";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/status.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 |         return ((now - min) as f32 / (max - min) as f32).max(0.0).min(1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((now - min) as f32 / (max - min) as f32).max(0.0).min(1.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/network.rs:218:5
[INFO] [stderr]     |
[INFO] [stderr] 218 |     return stop_sender;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `stop_sender`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/driving.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     return driving_sender;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `driving_sender`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/pid.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return Ok((((red + green + blue) / 1.5).min(2.0).max(0.0) - 1.0) * DRIVE_MULTIPLIER);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((((red + green + blue) / 1.5).min(2.0).max(0.0) - 1.0) * DRIVE_MULTIPLIER)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pid.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pid.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 |     return pid_sender;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pid_sender`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pid.rs:192:5
[INFO] [stderr]     |
[INFO] [stderr] 192 |     return (r,g,b)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `(r,g,b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/status.rs:8:20
[INFO] [stderr]   |
[INFO] [stderr] 8 | const COLOR_LIME: &'static str = "lime";
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/status.rs:9:22
[INFO] [stderr]   |
[INFO] [stderr] 9 | const COLOR_YELLOW: &'static str = "yellow";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:10:21
[INFO] [stderr]    |
[INFO] [stderr] 10 | const COLOR_AMBER: &'static str = "amber";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | const COLOR_ORANGE: &'static str = "orange";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 | const COLOR_RED: &'static str = "red";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/status.rs:13:19
[INFO] [stderr]    |
[INFO] [stderr] 13 | const COLOR_OFF: &'static str = "black";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/status.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 |         return ((now - min) as f32 / (max - min) as f32).max(0.0).min(1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((now - min) as f32 / (max - min) as f32).max(0.0).min(1.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Stop`
[INFO] [stderr]    --> src/network.rs:223:5
[INFO] [stderr]     |
[INFO] [stderr] 223 |     Stop,
[INFO] [stderr]     |     ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Stop`
[INFO] [stderr]    --> src/driving.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 |     Stop,
[INFO] [stderr]     |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference
[INFO] [stderr]   --> src/network.rs:42:24
[INFO] [stderr]    |
[INFO] [stderr] 42 |         socket.send_to(&mut send_buffer, broadcast_address)?;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             let _ = robot_sender.send(RobotCommand::SetTrack(left, right)).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:76:13
[INFO] [stderr]    |
[INFO] [stderr] 76 |             let _ = robot_sender.send(RobotCommand::SetTrim(trim)).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:79:13
[INFO] [stderr]    |
[INFO] [stderr] 79 |             let _ = robot_sender.send(RobotCommand::Kick).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             let _ = robot_sender.send(RobotCommand::SetPid(pid != 0)).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             let _ = robot_sender.send(RobotCommand::SetForeground).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             let _ = robot_sender.send(RobotCommand::SetBackground).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/network.rs:159:17
[INFO] [stderr]     |
[INFO] [stderr] 159 | /                 match message_version {
[INFO] [stderr] 160 | |                     1 => {
[INFO] [stderr] 161 | |                         let _ = parse_message_v1(&mut cursor, robot_sender, &mut status);
[INFO] [stderr] 162 | |                     }
[INFO] [stderr] 163 | |                     _ => {}
[INFO] [stderr] 164 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 159 |                 if let 1 = message_version {
[INFO] [stderr] 160 |     let _ = parse_message_v1(&mut cursor, robot_sender, &mut status);
[INFO] [stderr] 161 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/driving.rs:23:22
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let speed: f32 = MAX_SPEED as f32;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^ help: try: `f32::from(MAX_SPEED)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Stop`
[INFO] [stderr]    --> src/network.rs:223:5
[INFO] [stderr]     |
[INFO] [stderr] 223 |     Stop,
[INFO] [stderr]     |     ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Stop`
[INFO] [stderr]    --> src/driving.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 |     Stop,
[INFO] [stderr]     |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/pid.rs:186:36
[INFO] [stderr]     |
[INFO] [stderr] 186 |     let vec:Vec<&str> = file.split(";").collect::<Vec<&str>>();
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `';'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `send_to` doesn't need a mutable reference
[INFO] [stderr]   --> src/network.rs:42:24
[INFO] [stderr]    |
[INFO] [stderr] 42 |         socket.send_to(&mut send_buffer, broadcast_address)?;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             let _ = robot_sender.send(RobotCommand::SetTrack(left, right)).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:76:13
[INFO] [stderr]    |
[INFO] [stderr] 76 |             let _ = robot_sender.send(RobotCommand::SetTrim(trim)).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:79:13
[INFO] [stderr]    |
[INFO] [stderr] 79 |             let _ = robot_sender.send(RobotCommand::Kick).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             let _ = robot_sender.send(RobotCommand::SetPid(pid != 0)).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             let _ = robot_sender.send(RobotCommand::SetForeground).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/network.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             let _ = robot_sender.send(RobotCommand::SetBackground).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/network.rs:159:17
[INFO] [stderr]     |
[INFO] [stderr] 159 | /                 match message_version {
[INFO] [stderr] 160 | |                     1 => {
[INFO] [stderr] 161 | |                         let _ = parse_message_v1(&mut cursor, robot_sender, &mut status);
[INFO] [stderr] 162 | |                     }
[INFO] [stderr] 163 | |                     _ => {}
[INFO] [stderr] 164 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 159 |                 if let 1 = message_version {
[INFO] [stderr] 160 |     let _ = parse_message_v1(&mut cursor, robot_sender, &mut status);
[INFO] [stderr] 161 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/driving.rs:23:22
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let speed: f32 = MAX_SPEED as f32;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^ help: try: `f32::from(MAX_SPEED)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/pid.rs:186:36
[INFO] [stderr]     |
[INFO] [stderr] 186 |     let vec:Vec<&str> = file.split(";").collect::<Vec<&str>>();
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `';'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.60s
[INFO] running `"docker" "inspect" "5e71a275f4ad674c61408617d93b227b27ca264a8a7b21d744e6e86679a9dcea"`
[INFO] running `"docker" "rm" "-f" "5e71a275f4ad674c61408617d93b227b27ca264a8a7b21d744e6e86679a9dcea"`
[INFO] [stdout] 5e71a275f4ad674c61408617d93b227b27ca264a8a7b21d744e6e86679a9dcea