[INFO] updating cached repository pirogoeth/unix-named-pipe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pirogoeth/unix-named-pipe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pirogoeth/unix-named-pipe" "work/ex/clippy-test-run/sources/stable/gh/pirogoeth/unix-named-pipe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pirogoeth/unix-named-pipe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pirogoeth/unix-named-pipe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pirogoeth/unix-named-pipe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pirogoeth/unix-named-pipe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78bd325c82d13451027bc0b5c686f972358b8e9a [INFO] sha for GitHub repo pirogoeth/unix-named-pipe: 78bd325c82d13451027bc0b5c686f972358b8e9a [INFO] validating manifest of pirogoeth/unix-named-pipe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pirogoeth/unix-named-pipe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pirogoeth/unix-named-pipe [INFO] finished frobbing pirogoeth/unix-named-pipe [INFO] frobbed toml for pirogoeth/unix-named-pipe written to work/ex/clippy-test-run/sources/stable/gh/pirogoeth/unix-named-pipe/Cargo.toml [INFO] started frobbing pirogoeth/unix-named-pipe [INFO] finished frobbing pirogoeth/unix-named-pipe [INFO] frobbed toml for pirogoeth/unix-named-pipe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pirogoeth/unix-named-pipe/Cargo.toml [INFO] crate pirogoeth/unix-named-pipe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pirogoeth/unix-named-pipe against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pirogoeth/unix-named-pipe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f556a333c0dc101efc4fc5945475ed43c40a10891a50003d1ee3e0cccf5bbcb [INFO] running `"docker" "start" "-a" "7f556a333c0dc101efc4fc5945475ed43c40a10891a50003d1ee3e0cccf5bbcb"` [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking unix-named-pipe v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Compiling syn v0.15.11 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / return Err(io::Error::new( [INFO] [stderr] 53 | | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Err(io::Error::new( [INFO] [stderr] 53 | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / return Err(io::Error::new( [INFO] [stderr] 59 | | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Err(io::Error::new( [INFO] [stderr] 59 | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / return Err(io::Error::new( [INFO] [stderr] 65 | | io::ErrorKind::NotFound, [INFO] [stderr] 66 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | Err(io::Error::new( [INFO] [stderr] 65 | io::ErrorKind::NotFound, [INFO] [stderr] 66 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / return Err(io::Error::new( [INFO] [stderr] 71 | | io::ErrorKind::Other, [INFO] [stderr] 72 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 70 | Err(io::Error::new( [INFO] [stderr] 71 | io::ErrorKind::Other, [INFO] [stderr] 72 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | let result: i32 = result.into(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Compiling mini-internal v0.1.8 [INFO] [stderr] Checking miniserde v0.1.8 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/fixsz_server.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return running; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `running` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/varsz_server.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return running; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `running` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / return Err(io::Error::new( [INFO] [stderr] 53 | | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Err(io::Error::new( [INFO] [stderr] 53 | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / return Err(io::Error::new( [INFO] [stderr] 59 | | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Err(io::Error::new( [INFO] [stderr] 59 | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / return Err(io::Error::new( [INFO] [stderr] 65 | | io::ErrorKind::NotFound, [INFO] [stderr] 66 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | Err(io::Error::new( [INFO] [stderr] 65 | io::ErrorKind::NotFound, [INFO] [stderr] 66 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / return Err(io::Error::new( [INFO] [stderr] 71 | | io::ErrorKind::Other, [INFO] [stderr] 72 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 70 | Err(io::Error::new( [INFO] [stderr] 71 | io::ErrorKind::Other, [INFO] [stderr] 72 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | let result: i32 = result.into(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let _ = create(filename, None).expect("could not create pipe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | let _ = create(filename, None).expect("could not make test pipe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | / write_file [INFO] [stderr] 198 | | .write(&contents) [INFO] [stderr] 199 | | .expect("could not write test data to pipe"); [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `unix-named-pipe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7f556a333c0dc101efc4fc5945475ed43c40a10891a50003d1ee3e0cccf5bbcb"` [INFO] running `"docker" "rm" "-f" "7f556a333c0dc101efc4fc5945475ed43c40a10891a50003d1ee3e0cccf5bbcb"` [INFO] [stdout] 7f556a333c0dc101efc4fc5945475ed43c40a10891a50003d1ee3e0cccf5bbcb