[INFO] updating cached repository piot/git-backup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/piot/git-backup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/piot/git-backup" "work/ex/clippy-test-run/sources/stable/gh/piot/git-backup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/piot/git-backup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/piot/git-backup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piot/git-backup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piot/git-backup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9006aca305eea03b581f1482ea61d101e412463a [INFO] sha for GitHub repo piot/git-backup: 9006aca305eea03b581f1482ea61d101e412463a [INFO] validating manifest of piot/git-backup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piot/git-backup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piot/git-backup [INFO] finished frobbing piot/git-backup [INFO] frobbed toml for piot/git-backup written to work/ex/clippy-test-run/sources/stable/gh/piot/git-backup/Cargo.toml [INFO] started frobbing piot/git-backup [INFO] finished frobbing piot/git-backup [INFO] frobbed toml for piot/git-backup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piot/git-backup/Cargo.toml [INFO] crate piot/git-backup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piot/git-backup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/piot/git-backup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05cc8a18ced47eb89f1fa556e68a3bbd5a4a84655fe0c885e30288f45d029021 [INFO] running `"docker" "start" "-a" "05cc8a18ced47eb89f1fa556e68a3bbd5a4a84655fe0c885e30288f45d029021"` [INFO] [stderr] Checking serde v1.0.55 [INFO] [stderr] Checking pad v0.1.5 [INFO] [stderr] Compiling structopt-derive v0.2.8 [INFO] [stderr] Compiling serde_derive v1.0.55 [INFO] [stderr] Checking structopt v0.2.8 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking git-backup v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | env::home_dir().unwrap().to_str().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | env::home_dir().unwrap().to_str().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:117:62 [INFO] [stderr] | [INFO] [stderr] 117 | let mut all_repo_paths: Vec = values.iter().map(|i| PathBuf::from(i)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:125:45 [INFO] [stderr] | [INFO] [stderr] 125 | fn repo_value_from_tag(v: &Value, tag_name: &String) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:162:60 [INFO] [stderr] | [INFO] [stderr] 162 | let colored_name = if !is_clean { repo_name } else { repo_name }; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:162:41 [INFO] [stderr] | [INFO] [stderr] 162 | let colored_name = if !is_clean { repo_name } else { repo_name }; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `git-backup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:117:62 [INFO] [stderr] | [INFO] [stderr] 117 | let mut all_repo_paths: Vec = values.iter().map(|i| PathBuf::from(i)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:125:45 [INFO] [stderr] | [INFO] [stderr] 125 | fn repo_value_from_tag(v: &Value, tag_name: &String) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:162:60 [INFO] [stderr] | [INFO] [stderr] 162 | let colored_name = if !is_clean { repo_name } else { repo_name }; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:162:41 [INFO] [stderr] | [INFO] [stderr] 162 | let colored_name = if !is_clean { repo_name } else { repo_name }; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `git-backup`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "05cc8a18ced47eb89f1fa556e68a3bbd5a4a84655fe0c885e30288f45d029021"` [INFO] running `"docker" "rm" "-f" "05cc8a18ced47eb89f1fa556e68a3bbd5a4a84655fe0c885e30288f45d029021"` [INFO] [stdout] 05cc8a18ced47eb89f1fa556e68a3bbd5a4a84655fe0c885e30288f45d029021