[INFO] updating cached repository pimdh/risk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pimdh/risk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pimdh/risk" "work/ex/clippy-test-run/sources/stable/gh/pimdh/risk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pimdh/risk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pimdh/risk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pimdh/risk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pimdh/risk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f93f0e5dd21e8c6c2c8d0b83d315ce21a508f2e8 [INFO] sha for GitHub repo pimdh/risk: f93f0e5dd21e8c6c2c8d0b83d315ce21a508f2e8 [INFO] validating manifest of pimdh/risk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pimdh/risk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pimdh/risk [INFO] finished frobbing pimdh/risk [INFO] frobbed toml for pimdh/risk written to work/ex/clippy-test-run/sources/stable/gh/pimdh/risk/Cargo.toml [INFO] started frobbing pimdh/risk [INFO] finished frobbing pimdh/risk [INFO] frobbed toml for pimdh/risk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pimdh/risk/Cargo.toml [INFO] crate pimdh/risk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pimdh/risk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pimdh/risk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4d89b20191a51c74ee29142c6dec824e01157bd4d1232a86a73ca3f831a9739 [INFO] running `"docker" "start" "-a" "e4d89b20191a51c74ee29142c6dec824e01157bd4d1232a86a73ca3f831a9739"` [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling num-bigint v0.2.0 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling num-complex v0.2.0 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking risk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/dice_iterator.rs:8:26 [INFO] [stderr] | [INFO] [stderr] 8 | (0..n_dice).map(|_i| 1..(n_faces+1)).multi_cartesian_product() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n_faces` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/utils.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | let counter = map.entry(x).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/utils.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | let counter = a.entry(k).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &Vec, defender_dice: &Vec) -> (i32, i32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &[u32], defender_dice: &Vec) -> (i32, i32) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `attacker_dice.clone()` to [INFO] [stderr] | [INFO] [stderr] 12 | let mut attacker_dice = attacker_dice.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:61 [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &Vec, defender_dice: &Vec) -> (i32, i32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &Vec, defender_dice: &[u32]) -> (i32, i32) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `defender_dice.clone()` to [INFO] [stderr] | [INFO] [stderr] 14 | let mut defender_dice = defender_dice.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | -self.attacker_ratio * (outcome_attacker as f64) + (outcome_defender as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(outcome_attacker)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | -self.attacker_ratio * (outcome_attacker as f64) + (outcome_defender as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(outcome_defender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | (p * o_a as f64, p * o_d as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | (p * o_a as f64, p * o_d as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | (p * (o_a as f64 - exp_a).powf(2.0), p * (o_d as f64 - exp_d).powf(2.0)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | (p * (o_a as f64 - exp_a).powf(2.0), p * (o_d as f64 - exp_d).powf(2.0)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:55:32 [INFO] [stderr] | [INFO] [stderr] 55 | let n_dice: Vec = (1..n_defender+1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=n_defender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/dice_iterator.rs:8:26 [INFO] [stderr] | [INFO] [stderr] 8 | (0..n_dice).map(|_i| 1..(n_faces+1)).multi_cartesian_product() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n_faces` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/utils.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | let counter = map.entry(x).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/utils.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | let counter = a.entry(k).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &Vec, defender_dice: &Vec) -> (i32, i32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &[u32], defender_dice: &Vec) -> (i32, i32) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `attacker_dice.clone()` to [INFO] [stderr] | [INFO] [stderr] 12 | let mut attacker_dice = attacker_dice.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:61 [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &Vec, defender_dice: &Vec) -> (i32, i32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 11 | fn compute_outcome(attacker_dice: &Vec, defender_dice: &[u32]) -> (i32, i32) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `defender_dice.clone()` to [INFO] [stderr] | [INFO] [stderr] 14 | let mut defender_dice = defender_dice.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | -self.attacker_ratio * (outcome_attacker as f64) + (outcome_defender as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(outcome_attacker)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | -self.attacker_ratio * (outcome_attacker as f64) + (outcome_defender as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(outcome_defender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | (p * o_a as f64, p * o_d as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | (p * o_a as f64, p * o_d as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | (p * (o_a as f64 - exp_a).powf(2.0), p * (o_d as f64 - exp_d).powf(2.0)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | (p * (o_a as f64 - exp_a).powf(2.0), p * (o_d as f64 - exp_d).powf(2.0)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(o_d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:55:32 [INFO] [stderr] | [INFO] [stderr] 55 | let n_dice: Vec = (1..n_defender+1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=n_defender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.31s [INFO] running `"docker" "inspect" "e4d89b20191a51c74ee29142c6dec824e01157bd4d1232a86a73ca3f831a9739"` [INFO] running `"docker" "rm" "-f" "e4d89b20191a51c74ee29142c6dec824e01157bd4d1232a86a73ca3f831a9739"` [INFO] [stdout] e4d89b20191a51c74ee29142c6dec824e01157bd4d1232a86a73ca3f831a9739