[INFO] updating cached repository pijamarda/TresEnRalla [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pijamarda/TresEnRalla [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pijamarda/TresEnRalla" "work/ex/clippy-test-run/sources/stable/gh/pijamarda/TresEnRalla"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pijamarda/TresEnRalla'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pijamarda/TresEnRalla" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pijamarda/TresEnRalla"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pijamarda/TresEnRalla'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 190a61579a9bc8a432cda53032551804da218597 [INFO] sha for GitHub repo pijamarda/TresEnRalla: 190a61579a9bc8a432cda53032551804da218597 [INFO] validating manifest of pijamarda/TresEnRalla on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pijamarda/TresEnRalla on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pijamarda/TresEnRalla [INFO] finished frobbing pijamarda/TresEnRalla [INFO] frobbed toml for pijamarda/TresEnRalla written to work/ex/clippy-test-run/sources/stable/gh/pijamarda/TresEnRalla/Cargo.toml [INFO] started frobbing pijamarda/TresEnRalla [INFO] finished frobbing pijamarda/TresEnRalla [INFO] frobbed toml for pijamarda/TresEnRalla written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pijamarda/TresEnRalla/Cargo.toml [INFO] crate pijamarda/TresEnRalla has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pijamarda/TresEnRalla against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pijamarda/TresEnRalla:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86981bf8dacefcb4e598b93054463225749c8af68960173830b5995120960d40 [INFO] running `"docker" "start" "-a" "86981bf8dacefcb4e598b93054463225749c8af68960173830b5995120960d40"` [INFO] [stderr] Checking tresenralla v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:127:2 [INFO] [stderr] | [INFO] [stderr] 127 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:127:2 [INFO] [stderr] | [INFO] [stderr] 127 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:2 [INFO] [stderr] | [INFO] [stderr] 135 | return resultado; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultado` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:2 [INFO] [stderr] | [INFO] [stderr] 149 | return resultado [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultado` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:2 [INFO] [stderr] | [INFO] [stderr] 212 | return resultado; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultado` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:182:2 [INFO] [stderr] | [INFO] [stderr] 182 | if t[1] != 0 [INFO] [stderr] | _____^ [INFO] [stderr] 183 | | { [INFO] [stderr] 184 | | if t[1] == t[4] && t[4] == t[7] [INFO] [stderr] 185 | | { [INFO] [stderr] 186 | | resultado = true [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if t[1] != 0 && t[1] == t[4] && t[4] == t[7] { [INFO] [stderr] 183 | resultado = true [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:191:2 [INFO] [stderr] | [INFO] [stderr] 191 | if t[3] != 0 [INFO] [stderr] | _____^ [INFO] [stderr] 192 | | { [INFO] [stderr] 193 | | if t[3] == t[4] && t[4] == t[5] [INFO] [stderr] 194 | | { [INFO] [stderr] 195 | | resultado = true [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | if t[3] != 0 && t[3] == t[4] && t[4] == t[5] { [INFO] [stderr] 192 | resultado = true [INFO] [stderr] 193 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:2 [INFO] [stderr] | [INFO] [stderr] 135 | return resultado; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultado` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:2 [INFO] [stderr] | [INFO] [stderr] 149 | return resultado [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultado` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:2 [INFO] [stderr] | [INFO] [stderr] 212 | return resultado; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resultado` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:182:2 [INFO] [stderr] | [INFO] [stderr] 182 | if t[1] != 0 [INFO] [stderr] | _____^ [INFO] [stderr] 183 | | { [INFO] [stderr] 184 | | if t[1] == t[4] && t[4] == t[7] [INFO] [stderr] 185 | | { [INFO] [stderr] 186 | | resultado = true [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | if t[1] != 0 && t[1] == t[4] && t[4] == t[7] { [INFO] [stderr] 183 | resultado = true [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:191:2 [INFO] [stderr] | [INFO] [stderr] 191 | if t[3] != 0 [INFO] [stderr] | _____^ [INFO] [stderr] 192 | | { [INFO] [stderr] 193 | | if t[3] == t[4] && t[4] == t[5] [INFO] [stderr] 194 | | { [INFO] [stderr] 195 | | resultado = true [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | if t[3] != 0 && t[3] == t[4] && t[4] == t[5] { [INFO] [stderr] 192 | resultado = true [INFO] [stderr] 193 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: value assigned to `opcion` is never read [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | let mut opcion = 1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:36:6 [INFO] [stderr] | [INFO] [stderr] 36 | io::stdin().read_line(&mut posicion) [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | .ok() [INFO] [stderr] 38 | | .expect("Error al leer la linea"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | let posicion: i32 = posicion.trim().parse() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 44 | | .ok() [INFO] [stderr] 45 | | .expect("Debes introducir un numero, linea 36"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: value assigned to `opcion` is never read [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | let mut opcion = 1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:125:3 [INFO] [stderr] | [INFO] [stderr] 125 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:141:2 [INFO] [stderr] | [INFO] [stderr] 141 | let mut resultado = false; [INFO] [stderr] | _____^ [INFO] [stderr] 142 | | //Es decir que si la posicion esta vacia [INFO] [stderr] 143 | | //restamos 1, puesto que el usuario utiliza valores entre 1..9 [INFO] [stderr] 144 | | //pero el array es desde 0..8 [INFO] [stderr] ... | [INFO] [stderr] 147 | | resultado = true; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let resultado = if t[(posicion-1) as usize] == 0 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:36:6 [INFO] [stderr] | [INFO] [stderr] 36 | io::stdin().read_line(&mut posicion) [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | .ok() [INFO] [stderr] 38 | | .expect("Error al leer la linea"); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | let posicion: i32 = posicion.trim().parse() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 44 | | .ok() [INFO] [stderr] 45 | | .expect("Debes introducir un numero, linea 36"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:125:3 [INFO] [stderr] | [INFO] [stderr] 125 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:141:2 [INFO] [stderr] | [INFO] [stderr] 141 | let mut resultado = false; [INFO] [stderr] | _____^ [INFO] [stderr] 142 | | //Es decir que si la posicion esta vacia [INFO] [stderr] 143 | | //restamos 1, puesto que el usuario utiliza valores entre 1..9 [INFO] [stderr] 144 | | //pero el array es desde 0..8 [INFO] [stderr] ... | [INFO] [stderr] 147 | | resultado = true; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let resultado = if t[(posicion-1) as usize] == 0 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "86981bf8dacefcb4e598b93054463225749c8af68960173830b5995120960d40"` [INFO] running `"docker" "rm" "-f" "86981bf8dacefcb4e598b93054463225749c8af68960173830b5995120960d40"` [INFO] [stdout] 86981bf8dacefcb4e598b93054463225749c8af68960173830b5995120960d40