[INFO] updating cached repository pierrechevalier83/slider [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pierrechevalier83/slider [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pierrechevalier83/slider" "work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/slider"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/slider'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pierrechevalier83/slider" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/slider"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/slider'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f98c9076d5bd2fbf69629ed401642b49e8c4962 [INFO] sha for GitHub repo pierrechevalier83/slider: 1f98c9076d5bd2fbf69629ed401642b49e8c4962 [INFO] validating manifest of pierrechevalier83/slider on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pierrechevalier83/slider on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pierrechevalier83/slider [INFO] finished frobbing pierrechevalier83/slider [INFO] frobbed toml for pierrechevalier83/slider written to work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/slider/Cargo.toml [INFO] started frobbing pierrechevalier83/slider [INFO] finished frobbing pierrechevalier83/slider [INFO] frobbed toml for pierrechevalier83/slider written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/slider/Cargo.toml [INFO] crate pierrechevalier83/slider has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pierrechevalier83/slider against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/slider:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 061b5aa81cb83a5b2d6eddda4b61ad8ebe59710541886c3436e1c66623c0a058 [INFO] running `"docker" "start" "-a" "061b5aa81cb83a5b2d6eddda4b61ad8ebe59710541886c3436e1c66623c0a058"` [INFO] [stderr] Compiling serde v0.9.10 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling x11-dl v2.12.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking gfx_core v0.6.0 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking arrayvec v0.3.20 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Compiling serde_json v0.9.8 [INFO] [stderr] Compiling libloading v0.3.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking gfx v0.14.0 [INFO] [stderr] Checking gfx_device_gl v0.13.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.0 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking slider v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/settings.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | pub const IMAGE_PATH: &'static str = "butterfly.jpg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `app::App` [INFO] [stderr] --> src/app.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> App { [INFO] [stderr] 78 | | App { [INFO] [stderr] 79 | | slider: Slider::new(), [INFO] [stderr] 80 | | skin: Render::new(), [INFO] [stderr] 81 | | player_moved_last: false, [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for app::App { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `colors::Colors` [INFO] [stderr] --> src/colors.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Colors { [INFO] [stderr] 12 | | Colors { colors: Colors::gen_gradient() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `font::Font` [INFO] [stderr] --> src/font.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Font { [INFO] [stderr] 12 | | Font { font: None } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let ref font = assets.join("OpenSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("OpenSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref factory = window.factory; [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let factory = &window.factory;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn right(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn left(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn up(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn down(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn within_bounds(&self, low: Point, high: Point) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `skin::Render` [INFO] [stderr] --> src/skin.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Render { [INFO] [stderr] 30 | | Render { [INFO] [stderr] 31 | | colors: Colors::new(), [INFO] [stderr] 32 | | textures: Textures::new(), [INFO] [stderr] 33 | | font: Font::new(), [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for skin::Render { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | col as f64 * CELL_SIZE, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | row as f64 * CELL_SIZE); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | (CELL_SIZE * N_COLS as f64) + 1.8 * LINING, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(N_COLS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:89:40 [INFO] [stderr] | [INFO] [stderr] 89 | (CELL_SIZE * N_ROWS as f64) + 1.8 * LINING], [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(N_ROWS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `textures::Textures` [INFO] [stderr] --> src/textures.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Textures { [INFO] [stderr] 16 | | Textures { cell_textures: Vec::new() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/settings.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | pub const IMAGE_PATH: &'static str = "butterfly.jpg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `app::App` [INFO] [stderr] --> src/app.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> App { [INFO] [stderr] 78 | | App { [INFO] [stderr] 79 | | slider: Slider::new(), [INFO] [stderr] 80 | | skin: Render::new(), [INFO] [stderr] 81 | | player_moved_last: false, [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for app::App { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `colors::Colors` [INFO] [stderr] --> src/colors.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Colors { [INFO] [stderr] 12 | | Colors { colors: Colors::gen_gradient() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `font::Font` [INFO] [stderr] --> src/font.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Font { [INFO] [stderr] 12 | | Font { font: None } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let ref font = assets.join("OpenSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("OpenSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/font.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref factory = window.factory; [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let factory = &window.factory;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn right(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn left(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn up(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn down(&self) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/point.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn within_bounds(&self, low: Point, high: Point) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `skin::Render` [INFO] [stderr] --> src/skin.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Render { [INFO] [stderr] 30 | | Render { [INFO] [stderr] 31 | | colors: Colors::new(), [INFO] [stderr] 32 | | textures: Textures::new(), [INFO] [stderr] 33 | | font: Font::new(), [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for skin::Render { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | col as f64 * CELL_SIZE, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | row as f64 * CELL_SIZE); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | (CELL_SIZE * N_COLS as f64) + 1.8 * LINING, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(N_COLS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/skin.rs:89:40 [INFO] [stderr] | [INFO] [stderr] 89 | (CELL_SIZE * N_ROWS as f64) + 1.8 * LINING], [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(N_ROWS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `textures::Textures` [INFO] [stderr] --> src/textures.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Textures { [INFO] [stderr] 16 | | Textures { cell_textures: Vec::new() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `"docker" "inspect" "061b5aa81cb83a5b2d6eddda4b61ad8ebe59710541886c3436e1c66623c0a058"` [INFO] running `"docker" "rm" "-f" "061b5aa81cb83a5b2d6eddda4b61ad8ebe59710541886c3436e1c66623c0a058"` [INFO] [stdout] 061b5aa81cb83a5b2d6eddda4b61ad8ebe59710541886c3436e1c66623c0a058