[INFO] updating cached repository phyber/upsidedown-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/phyber/upsidedown-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/phyber/upsidedown-rs" "work/ex/clippy-test-run/sources/stable/gh/phyber/upsidedown-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phyber/upsidedown-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/phyber/upsidedown-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phyber/upsidedown-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phyber/upsidedown-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 839a6138380b0e481801967b3bcd28c4630d4043
[INFO] sha for GitHub repo phyber/upsidedown-rs: 839a6138380b0e481801967b3bcd28c4630d4043
[INFO] validating manifest of phyber/upsidedown-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of phyber/upsidedown-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing phyber/upsidedown-rs
[INFO] finished frobbing phyber/upsidedown-rs
[INFO] frobbed toml for phyber/upsidedown-rs written to work/ex/clippy-test-run/sources/stable/gh/phyber/upsidedown-rs/Cargo.toml
[INFO] started frobbing phyber/upsidedown-rs
[INFO] finished frobbing phyber/upsidedown-rs
[INFO] frobbed toml for phyber/upsidedown-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phyber/upsidedown-rs/Cargo.toml
[INFO] crate phyber/upsidedown-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting phyber/upsidedown-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phyber/upsidedown-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 80330257c330787e18fd3c1fc9e6b0a796536f5550d8625ec92c84ee20b13104
[INFO] running `"docker" "start" "-a" "80330257c330787e18fd3c1fc9e6b0a796536f5550d8625ec92c84ee20b13104"`
[INFO] [stderr]     Checking upsidedown-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/translations.rs:4:21
[INFO] [stderr]   |
[INFO] [stderr] 4 | const PUNCTUATION: &'static [(char, char)] = &[
[INFO] [stderr]   |                    -^^^^^^^--------------- help: consider removing `'static`: `&[(char, char)]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/translations.rs:27:33
[INFO] [stderr]    |
[INFO] [stderr] 27 | const UPSIDE_DOWN_ALPHA_UPPER: &'static [char] = &[
[INFO] [stderr]    |                                -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/translations.rs:56:33
[INFO] [stderr]    |
[INFO] [stderr] 56 | const UPSIDE_DOWN_ALPHA_LOWER: &'static [char] = &[
[INFO] [stderr]    |                                -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/translations.rs:85:28
[INFO] [stderr]    |
[INFO] [stderr] 85 | const UPSIDE_DOWN_NUMBER: &'static [char] = &[
[INFO] [stderr]    |                           -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/translations.rs:132:5
[INFO] [stderr]     |
[INFO] [stderr] 132 |     return table;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `table`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return table;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `table`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         return new;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `new`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/translations.rs:4:21
[INFO] [stderr]   |
[INFO] [stderr] 4 | const PUNCTUATION: &'static [(char, char)] = &[
[INFO] [stderr]   |                    -^^^^^^^--------------- help: consider removing `'static`: `&[(char, char)]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/translations.rs:27:33
[INFO] [stderr]    |
[INFO] [stderr] 27 | const UPSIDE_DOWN_ALPHA_UPPER: &'static [char] = &[
[INFO] [stderr]    |                                -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/translations.rs:56:33
[INFO] [stderr]    |
[INFO] [stderr] 56 | const UPSIDE_DOWN_ALPHA_LOWER: &'static [char] = &[
[INFO] [stderr]    |                                -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/translations.rs:85:28
[INFO] [stderr]    |
[INFO] [stderr] 85 | const UPSIDE_DOWN_NUMBER: &'static [char] = &[
[INFO] [stderr]    |                           -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/translations.rs:132:5
[INFO] [stderr]     |
[INFO] [stderr] 132 |     return table;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `table`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return table;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `table`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         return new;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `new`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/translations.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let alphabet = (b'A' .. b'Z' + 1)  // u8
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: use: `(b'A'..=b'Z')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/translations.rs:122:19
[INFO] [stderr]     |
[INFO] [stderr] 122 |     let numbers = (0 .. 9).into_iter().zip(UPSIDE_DOWN_NUMBER.iter());
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0 .. 9)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/translations.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let alphabet = (b'A' .. b'Z' + 1)  // u8
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: use: `(b'A'..=b'Z')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/translations.rs:122:19
[INFO] [stderr]     |
[INFO] [stderr] 122 |     let numbers = (0 .. 9).into_iter().zip(UPSIDE_DOWN_NUMBER.iter());
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0 .. 9)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.87s
[INFO] running `"docker" "inspect" "80330257c330787e18fd3c1fc9e6b0a796536f5550d8625ec92c84ee20b13104"`
[INFO] running `"docker" "rm" "-f" "80330257c330787e18fd3c1fc9e6b0a796536f5550d8625ec92c84ee20b13104"`
[INFO] [stdout] 80330257c330787e18fd3c1fc9e6b0a796536f5550d8625ec92c84ee20b13104