[INFO] updating cached repository phreaknik/dice-mnemonics [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phreaknik/dice-mnemonics [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phreaknik/dice-mnemonics" "work/ex/clippy-test-run/sources/stable/gh/phreaknik/dice-mnemonics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phreaknik/dice-mnemonics'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phreaknik/dice-mnemonics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/dice-mnemonics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/dice-mnemonics'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1409e6e3ebd73f6debdf88c572df9abaa9210e19 [INFO] sha for GitHub repo phreaknik/dice-mnemonics: 1409e6e3ebd73f6debdf88c572df9abaa9210e19 [INFO] validating manifest of phreaknik/dice-mnemonics on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phreaknik/dice-mnemonics on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phreaknik/dice-mnemonics [INFO] finished frobbing phreaknik/dice-mnemonics [INFO] frobbed toml for phreaknik/dice-mnemonics written to work/ex/clippy-test-run/sources/stable/gh/phreaknik/dice-mnemonics/Cargo.toml [INFO] started frobbing phreaknik/dice-mnemonics [INFO] finished frobbing phreaknik/dice-mnemonics [INFO] frobbed toml for phreaknik/dice-mnemonics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/dice-mnemonics/Cargo.toml [INFO] crate phreaknik/dice-mnemonics has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phreaknik/dice-mnemonics against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phreaknik/dice-mnemonics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f71900825326a591e56544c277477873eadf0b2d36a273c7b9f07b0f08e78a23 [INFO] running `"docker" "start" "-a" "f71900825326a591e56544c277477873eadf0b2d36a273c7b9f07b0f08e78a23"` [INFO] [stderr] Checking dicephrase v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/monero.rs:14:39 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn run(args: Option<&ArgMatches>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/monero.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return Err("No input detected.".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("No input detected.".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/monero.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/monero.rs:14:39 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn run(args: Option<&ArgMatches>) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/monero.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return Err("No input detected.".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("No input detected.".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/monero.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `rolls` is never read [INFO] [stderr] --> src/monero.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let mut rolls: Vec = Vec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/monero.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if scale_factor <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using scale_factor == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/monero.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dicephrase`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: value assigned to `rolls` is never read [INFO] [stderr] --> src/monero.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let mut rolls: Vec = Vec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/monero.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if scale_factor <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using scale_factor == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/monero.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dicephrase`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f71900825326a591e56544c277477873eadf0b2d36a273c7b9f07b0f08e78a23"` [INFO] running `"docker" "rm" "-f" "f71900825326a591e56544c277477873eadf0b2d36a273c7b9f07b0f08e78a23"` [INFO] [stdout] f71900825326a591e56544c277477873eadf0b2d36a273c7b9f07b0f08e78a23