[INFO] updating cached repository phowell/FHasher [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phowell/FHasher [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phowell/FHasher" "work/ex/clippy-test-run/sources/stable/gh/phowell/FHasher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phowell/FHasher'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phowell/FHasher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phowell/FHasher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phowell/FHasher'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 545ed1f82e57fdd791d923b476d9c990c8cf63ba [INFO] sha for GitHub repo phowell/FHasher: 545ed1f82e57fdd791d923b476d9c990c8cf63ba [INFO] validating manifest of phowell/FHasher on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phowell/FHasher on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phowell/FHasher [INFO] finished frobbing phowell/FHasher [INFO] frobbed toml for phowell/FHasher written to work/ex/clippy-test-run/sources/stable/gh/phowell/FHasher/Cargo.toml [INFO] started frobbing phowell/FHasher [INFO] finished frobbing phowell/FHasher [INFO] frobbed toml for phowell/FHasher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phowell/FHasher/Cargo.toml [INFO] crate phowell/FHasher has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phowell/FHasher against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phowell/FHasher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d14d09d4438ed92ad2b65ac738cc367dd1b49989321316f9ef3d95f848088c1c [INFO] running `"docker" "start" "-a" "d14d09d4438ed92ad2b65ac738cc367dd1b49989321316f9ef3d95f848088c1c"` [INFO] [stderr] Compiling proc-macro2 v0.4.12 [INFO] [stderr] Compiling ryu v0.2.3 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking md-5 v0.8.0 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Compiling quote v0.6.6 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Checking fhasher v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `fp` [INFO] [stderr] --> src/hasher.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | fn sha1(fp: &Path) -> io::Result { [INFO] [stderr] | ^^ help: consider using `_fp` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fp` [INFO] [stderr] --> src/hasher.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | fn sha256(fp: &Path) -> io::Result { [INFO] [stderr] | ^^ help: consider using `_fp` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fp` [INFO] [stderr] --> src/hasher.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | fn sha1(fp: &Path) -> io::Result { [INFO] [stderr] | ^^ help: consider using `_fp` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fp` [INFO] [stderr] --> src/hasher.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | fn sha256(fp: &Path) -> io::Result { [INFO] [stderr] | ^^ help: consider using `_fp` instead [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/logfile.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / if !f.hashes.contains_key(&alg.to_string()) { [INFO] [stderr] 56 | | f.hashes.insert(alg.to_string(), hash.to_owned()); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________^ help: consider using: `f.hashes.entry(alg.to_string()).or_insert(hash.to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/logfile.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | / if !f.hashes.contains_key(&alg.to_string()) { [INFO] [stderr] 56 | | f.hashes.insert(alg.to_string(), hash.to_owned()); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________^ help: consider using: `f.hashes.entry(alg.to_string()).or_insert(hash.to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.43s [INFO] running `"docker" "inspect" "d14d09d4438ed92ad2b65ac738cc367dd1b49989321316f9ef3d95f848088c1c"` [INFO] running `"docker" "rm" "-f" "d14d09d4438ed92ad2b65ac738cc367dd1b49989321316f9ef3d95f848088c1c"` [INFO] [stdout] d14d09d4438ed92ad2b65ac738cc367dd1b49989321316f9ef3d95f848088c1c