[INFO] updating cached repository phoomparin/ath-core [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phoomparin/ath-core [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phoomparin/ath-core" "work/ex/clippy-test-run/sources/stable/gh/phoomparin/ath-core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phoomparin/ath-core'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phoomparin/ath-core" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phoomparin/ath-core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phoomparin/ath-core'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ce9d93c71d4dd05b9a4deeb37c1388eefe57f59 [INFO] sha for GitHub repo phoomparin/ath-core: 8ce9d93c71d4dd05b9a4deeb37c1388eefe57f59 [INFO] validating manifest of phoomparin/ath-core on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phoomparin/ath-core on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phoomparin/ath-core [INFO] finished frobbing phoomparin/ath-core [INFO] frobbed toml for phoomparin/ath-core written to work/ex/clippy-test-run/sources/stable/gh/phoomparin/ath-core/Cargo.toml [INFO] started frobbing phoomparin/ath-core [INFO] finished frobbing phoomparin/ath-core [INFO] frobbed toml for phoomparin/ath-core written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phoomparin/ath-core/Cargo.toml [INFO] crate phoomparin/ath-core has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phoomparin/ath-core against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phoomparin/ath-core:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ffb4e2d71c135d63612f5332b8007a8e3787dc2d66e1b6d8ce8935ad97c761f0 [INFO] running `"docker" "start" "-a" "ffb4e2d71c135d63612f5332b8007a8e3787dc2d66e1b6d8ce8935ad97c761f0"` [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking ath v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `logger::Levels` [INFO] [stderr] --> src/logger.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Levels { [INFO] [stderr] 31 | | let levels = HashMap::new(); [INFO] [stderr] 32 | | let mut levels = Levels { levels, current: ALL }; [INFO] [stderr] 33 | | [INFO] [stderr] ... | [INFO] [stderr] 37 | | levels [INFO] [stderr] 38 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | impl Default for logger::Levels { [INFO] [stderr] 30 | fn default() -> Self { [INFO] [stderr] 31 | Self::new() [INFO] [stderr] 32 | } [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/logger.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn from_env(&self) -> Level { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `logger::Logger` [INFO] [stderr] --> src/logger.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Logger { [INFO] [stderr] 78 | | let logs: Vec = Vec::new(); [INFO] [stderr] 79 | | let levels = Levels::new(); [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | Logger { logs, levels } [INFO] [stderr] 82 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | impl Default for logger::Logger { [INFO] [stderr] 77 | fn default() -> Self { [INFO] [stderr] 78 | Self::new() [INFO] [stderr] 79 | } [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `logger::Levels` [INFO] [stderr] --> src/logger.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Levels { [INFO] [stderr] 31 | | let levels = HashMap::new(); [INFO] [stderr] 32 | | let mut levels = Levels { levels, current: ALL }; [INFO] [stderr] 33 | | [INFO] [stderr] ... | [INFO] [stderr] 37 | | levels [INFO] [stderr] 38 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | impl Default for logger::Levels { [INFO] [stderr] 30 | fn default() -> Self { [INFO] [stderr] 31 | Self::new() [INFO] [stderr] 32 | } [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/logger.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn from_env(&self) -> Level { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `logger::Logger` [INFO] [stderr] --> src/logger.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Logger { [INFO] [stderr] 78 | | let logs: Vec = Vec::new(); [INFO] [stderr] 79 | | let levels = Levels::new(); [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | Logger { logs, levels } [INFO] [stderr] 82 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | impl Default for logger::Logger { [INFO] [stderr] 77 | fn default() -> Self { [INFO] [stderr] 78 | Self::new() [INFO] [stderr] 79 | } [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.22s [INFO] running `"docker" "inspect" "ffb4e2d71c135d63612f5332b8007a8e3787dc2d66e1b6d8ce8935ad97c761f0"` [INFO] running `"docker" "rm" "-f" "ffb4e2d71c135d63612f5332b8007a8e3787dc2d66e1b6d8ce8935ad97c761f0"` [INFO] [stdout] ffb4e2d71c135d63612f5332b8007a8e3787dc2d66e1b6d8ce8935ad97c761f0