[INFO] updating cached repository phonnz/shell-with-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phonnz/shell-with-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phonnz/shell-with-rust" "work/ex/clippy-test-run/sources/stable/gh/phonnz/shell-with-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phonnz/shell-with-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phonnz/shell-with-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonnz/shell-with-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonnz/shell-with-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fcf16b764a46609d60630fda7b0b625b036730c6 [INFO] sha for GitHub repo phonnz/shell-with-rust: fcf16b764a46609d60630fda7b0b625b036730c6 [INFO] validating manifest of phonnz/shell-with-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phonnz/shell-with-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phonnz/shell-with-rust [INFO] finished frobbing phonnz/shell-with-rust [INFO] frobbed toml for phonnz/shell-with-rust written to work/ex/clippy-test-run/sources/stable/gh/phonnz/shell-with-rust/Cargo.toml [INFO] started frobbing phonnz/shell-with-rust [INFO] finished frobbing phonnz/shell-with-rust [INFO] frobbed toml for phonnz/shell-with-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonnz/shell-with-rust/Cargo.toml [INFO] crate phonnz/shell-with-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phonnz/shell-with-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phonnz/shell-with-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76cfce56611e2b1b8001f3fb937e64a2d3cd113cc7567552cfc88ab17eb2c6fa [INFO] running `"docker" "start" "-a" "76cfce56611e2b1b8001f3fb937e64a2d3cd113cc7567552cfc88ab17eb2c6fa"` [INFO] [stderr] Checking shell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `clean_path` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | fn clean_path(path: &mut String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_cmd(cmd: &String) -> Vec<&str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn make_queue(command: &String) -> Vec<&str>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:41 [INFO] [stderr] | [INFO] [stderr] 36 | let commands = command.trim().split(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | fn run_single_cmd(command: &String){ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | let sequence = cmd.trim().split("|"); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clean_path` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | fn clean_path(path: &mut String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_cmd(cmd: &String) -> Vec<&str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn make_queue(command: &String) -> Vec<&str>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:41 [INFO] [stderr] | [INFO] [stderr] 36 | let commands = command.trim().split(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | fn run_single_cmd(command: &String){ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | let sequence = cmd.trim().split("|"); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "76cfce56611e2b1b8001f3fb937e64a2d3cd113cc7567552cfc88ab17eb2c6fa"` [INFO] running `"docker" "rm" "-f" "76cfce56611e2b1b8001f3fb937e64a2d3cd113cc7567552cfc88ab17eb2c6fa"` [INFO] [stdout] 76cfce56611e2b1b8001f3fb937e64a2d3cd113cc7567552cfc88ab17eb2c6fa