[INFO] updating cached repository phonaputer/rust_dice_roller
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/phonaputer/rust_dice_roller
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/phonaputer/rust_dice_roller" "work/ex/clippy-test-run/sources/stable/gh/phonaputer/rust_dice_roller"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phonaputer/rust_dice_roller'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/phonaputer/rust_dice_roller" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonaputer/rust_dice_roller"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonaputer/rust_dice_roller'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7c465fbeb97a44fce7b19d56032493a1b602849b
[INFO] sha for GitHub repo phonaputer/rust_dice_roller: 7c465fbeb97a44fce7b19d56032493a1b602849b
[INFO] validating manifest of phonaputer/rust_dice_roller on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of phonaputer/rust_dice_roller on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing phonaputer/rust_dice_roller
[INFO] finished frobbing phonaputer/rust_dice_roller
[INFO] frobbed toml for phonaputer/rust_dice_roller written to work/ex/clippy-test-run/sources/stable/gh/phonaputer/rust_dice_roller/Cargo.toml
[INFO] started frobbing phonaputer/rust_dice_roller
[INFO] finished frobbing phonaputer/rust_dice_roller
[INFO] frobbed toml for phonaputer/rust_dice_roller written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonaputer/rust_dice_roller/Cargo.toml
[INFO] crate phonaputer/rust_dice_roller has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting phonaputer/rust_dice_roller against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phonaputer/rust_dice_roller:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fc3da4d55ea735f5f0d078a241ab4c28c7540bdc9b1c0c37983a2524ea5237d8
[INFO] running `"docker" "start" "-a" "fc3da4d55ea735f5f0d078a241ab4c28c7540bdc9b1c0c37983a2524ea5237d8"`
[INFO] [stderr]     Checking rust_dice_roller v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return roll
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `roll`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     return roll_string.split("d")
[INFO] [stderr] 47 | |         .map(|x| Box::new(x.to_string()))
[INFO] [stderr] 48 | |         .collect::<Vec<Box<String>>>();
[INFO] [stderr]    | |_______________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 46 |     roll_string.split("d")
[INFO] [stderr] 47 |         .map(|x| Box::new(x.to_string()))
[INFO] [stderr] 48 |         .collect::<Vec<Box<String>>>()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     return -1;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `-1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     return int_string.parse().unwrap_or(-1);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `int_string.parse().unwrap_or(-1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:46:30
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return roll_string.split("d")
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'d'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return roll
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `roll`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     return roll_string.split("d")
[INFO] [stderr] 47 | |         .map(|x| Box::new(x.to_string()))
[INFO] [stderr] 48 | |         .collect::<Vec<Box<String>>>();
[INFO] [stderr]    | |_______________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 46 |     roll_string.split("d")
[INFO] [stderr] 47 |         .map(|x| Box::new(x.to_string()))
[INFO] [stderr] 48 |         .collect::<Vec<Box<String>>>()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     return -1;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `-1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     return int_string.parse().unwrap_or(-1);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `int_string.parse().unwrap_or(-1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:46:30
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return roll_string.split("d")
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'d'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.95s
[INFO] running `"docker" "inspect" "fc3da4d55ea735f5f0d078a241ab4c28c7540bdc9b1c0c37983a2524ea5237d8"`
[INFO] running `"docker" "rm" "-f" "fc3da4d55ea735f5f0d078a241ab4c28c7540bdc9b1c0c37983a2524ea5237d8"`
[INFO] [stdout] fc3da4d55ea735f5f0d078a241ab4c28c7540bdc9b1c0c37983a2524ea5237d8