[INFO] updating cached repository phillyai/tic-tac-toe-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phillyai/tic-tac-toe-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phillyai/tic-tac-toe-rs" "work/ex/clippy-test-run/sources/stable/gh/phillyai/tic-tac-toe-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phillyai/tic-tac-toe-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phillyai/tic-tac-toe-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phillyai/tic-tac-toe-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phillyai/tic-tac-toe-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25d0d75e18794ac85a307ecad2e9f91d20b7f66c [INFO] sha for GitHub repo phillyai/tic-tac-toe-rs: 25d0d75e18794ac85a307ecad2e9f91d20b7f66c [INFO] validating manifest of phillyai/tic-tac-toe-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phillyai/tic-tac-toe-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phillyai/tic-tac-toe-rs [INFO] finished frobbing phillyai/tic-tac-toe-rs [INFO] frobbed toml for phillyai/tic-tac-toe-rs written to work/ex/clippy-test-run/sources/stable/gh/phillyai/tic-tac-toe-rs/Cargo.toml [INFO] started frobbing phillyai/tic-tac-toe-rs [INFO] finished frobbing phillyai/tic-tac-toe-rs [INFO] frobbed toml for phillyai/tic-tac-toe-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phillyai/tic-tac-toe-rs/Cargo.toml [INFO] crate phillyai/tic-tac-toe-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phillyai/tic-tac-toe-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phillyai/tic-tac-toe-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25bea2af53b4ed74d715682d51cac929232092e831ce23ea550246786f112db2 [INFO] running `"docker" "start" "-a" "25bea2af53b4ed74d715682d51cac929232092e831ce23ea550246786f112db2"` [INFO] [stderr] Checking tic-tac-toe-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `match` head expression [INFO] [stderr] --> src/main.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | Some(w) => match (w) { [INFO] [stderr] | ^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `match` head expression [INFO] [stderr] --> src/main.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | Some(w) => match (w) { [INFO] [stderr] | ^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Direction` [INFO] [stderr] --> src/main.rs:137:1 [INFO] [stderr] | [INFO] [stderr] 137 | enum Direction { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | while !game_end { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | if let Some(_) = &mut board.set(n) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 30 | | let msg = match board.winner() { [INFO] [stderr] 31 | | None => continue, [INFO] [stderr] 32 | | Some(w) => match (w) { [INFO] [stderr] ... | [INFO] [stderr] 39 | | break; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________- help: try this: `if &mut board.set(n).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Direction` [INFO] [stderr] --> src/main.rs:137:1 [INFO] [stderr] | [INFO] [stderr] 137 | enum Direction { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | while !game_end { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | if let Some(_) = &mut board.set(n) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 30 | | let msg = match board.winner() { [INFO] [stderr] 31 | | None => continue, [INFO] [stderr] 32 | | Some(w) => match (w) { [INFO] [stderr] ... | [INFO] [stderr] 39 | | break; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________- help: try this: `if &mut board.set(n).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tic-tac-toe-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `tic-tac-toe-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "25bea2af53b4ed74d715682d51cac929232092e831ce23ea550246786f112db2"` [INFO] running `"docker" "rm" "-f" "25bea2af53b4ed74d715682d51cac929232092e831ce23ea550246786f112db2"` [INFO] [stdout] 25bea2af53b4ed74d715682d51cac929232092e831ce23ea550246786f112db2