[INFO] updating cached repository phillyai/calc-repl-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phillyai/calc-repl-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phillyai/calc-repl-rs" "work/ex/clippy-test-run/sources/stable/gh/phillyai/calc-repl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phillyai/calc-repl-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phillyai/calc-repl-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phillyai/calc-repl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phillyai/calc-repl-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3d9f432de12ce44d2384c1fab56268aee2fba9e [INFO] sha for GitHub repo phillyai/calc-repl-rs: e3d9f432de12ce44d2384c1fab56268aee2fba9e [INFO] validating manifest of phillyai/calc-repl-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phillyai/calc-repl-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phillyai/calc-repl-rs [INFO] finished frobbing phillyai/calc-repl-rs [INFO] frobbed toml for phillyai/calc-repl-rs written to work/ex/clippy-test-run/sources/stable/gh/phillyai/calc-repl-rs/Cargo.toml [INFO] started frobbing phillyai/calc-repl-rs [INFO] finished frobbing phillyai/calc-repl-rs [INFO] frobbed toml for phillyai/calc-repl-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phillyai/calc-repl-rs/Cargo.toml [INFO] crate phillyai/calc-repl-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phillyai/calc-repl-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phillyai/calc-repl-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b969b246f20de03cc909c01a601b887f9306a5605936c03ad0823eda5b6ead7e [INFO] running `"docker" "start" "-a" "b969b246f20de03cc909c01a601b887f9306a5605936c03ad0823eda5b6ead7e"` [INFO] [stderr] Checking calc-repl-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | fn $name(toks: &Vec, i: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] ... [INFO] [stderr] 63 | create_binary_parser!(parse_bin parse_term Op('+') => Plus, Op('-') => Minus); [INFO] [stderr] | ------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | fn $name(toks: &Vec, i: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] ... [INFO] [stderr] 64 | create_binary_parser!(parse_term parse_atom Op('*') => Mult, Op('/') => Divide); [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | fn parse_atom(toks: &Vec, i: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | ref n => Err(String::from(format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 86 | | "parse_atom: not expecting token {:?}", [INFO] [stderr] 87 | | n [INFO] [stderr] 88 | | ))), [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 85 | ref n => Err(format!( [INFO] [stderr] 86 | "parse_atom: not expecting token {:?}", [INFO] [stderr] 87 | n [INFO] [stderr] 88 | )), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | fn $name(toks: &Vec, i: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] ... [INFO] [stderr] 63 | create_binary_parser!(parse_bin parse_term Op('+') => Plus, Op('-') => Minus); [INFO] [stderr] | ------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | fn $name(toks: &Vec, i: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] ... [INFO] [stderr] 64 | create_binary_parser!(parse_term parse_atom Op('*') => Mult, Op('/') => Divide); [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | fn parse_atom(toks: &Vec, i: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | ref n => Err(String::from(format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 86 | | "parse_atom: not expecting token {:?}", [INFO] [stderr] 87 | | n [INFO] [stderr] 88 | | ))), [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 85 | ref n => Err(format!( [INFO] [stderr] 86 | "parse_atom: not expecting token {:?}", [INFO] [stderr] 87 | n [INFO] [stderr] 88 | )), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "b969b246f20de03cc909c01a601b887f9306a5605936c03ad0823eda5b6ead7e"` [INFO] running `"docker" "rm" "-f" "b969b246f20de03cc909c01a601b887f9306a5605936c03ad0823eda5b6ead7e"` [INFO] [stdout] b969b246f20de03cc909c01a601b887f9306a5605936c03ad0823eda5b6ead7e