[INFO] updating cached repository philippkeller/rexpect [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/philippkeller/rexpect [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/philippkeller/rexpect" "work/ex/clippy-test-run/sources/stable/gh/philippkeller/rexpect"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/philippkeller/rexpect'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/philippkeller/rexpect" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/philippkeller/rexpect"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/philippkeller/rexpect'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a54f2072de8d9b7d259efc43aae301f649ee88e [INFO] sha for GitHub repo philippkeller/rexpect: 6a54f2072de8d9b7d259efc43aae301f649ee88e [INFO] validating manifest of philippkeller/rexpect on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of philippkeller/rexpect on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing philippkeller/rexpect [INFO] finished frobbing philippkeller/rexpect [INFO] frobbed toml for philippkeller/rexpect written to work/ex/clippy-test-run/sources/stable/gh/philippkeller/rexpect/Cargo.toml [INFO] started frobbing philippkeller/rexpect [INFO] finished frobbing philippkeller/rexpect [INFO] frobbed toml for philippkeller/rexpect written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/philippkeller/rexpect/Cargo.toml [INFO] crate philippkeller/rexpect has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting philippkeller/rexpect against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/philippkeller/rexpect:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87346f7218fef3c7fddc9fdb55590f9a5e226cda9fa7c47c40993921237f6917 [INFO] running `"docker" "start" "-a" "87346f7218fef3c7fddc9fdb55590f9a5e226cda9fa7c47c40993921237f6917"` [INFO] [stderr] Compiling cc v1.0.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Compiling backtrace-sys v0.1.14 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking rexpect v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | child_pid: child_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:235:12 [INFO] [stderr] | [INFO] [stderr] 235 | process: process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:238:12 [INFO] [stderr] | [INFO] [stderr] 238 | commandname: commandname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commandname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | child_pid: child_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:235:12 [INFO] [stderr] | [INFO] [stderr] 235 | process: process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/session.rs:238:12 [INFO] [stderr] | [INFO] [stderr] 238 | commandname: commandname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commandname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/session.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/session.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | let res = self.exp(&ReadUntil::Regex(Regex::new(regex).chain_err(|| "invalid regex")?)) [INFO] [stderr] | ___________________^ [INFO] [stderr] 142 | | .and_then(|s| Ok(s)); [INFO] [stderr] | |________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/session.rs:385:67 [INFO] [stderr] | [INFO] [stderr] 385 | c.args(&["--rcfile", rcfile.path().to_str().unwrap_or_else(|| return "temp file does not exist".into())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"temp file does not exist".into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/process.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / match self.status() { [INFO] [stderr] 237 | | Some(wait::WaitStatus::StillAlive) => { [INFO] [stderr] 238 | | self.exit().expect("cannot exit"); [INFO] [stderr] 239 | | } [INFO] [stderr] 240 | | _ => {} [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 236 | if let Some(wait::WaitStatus::StillAlive) = self.status() { [INFO] [stderr] 237 | self.exit().expect("cannot exit"); [INFO] [stderr] 238 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/session.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | .write(&['\n' as u8]) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/session.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | 'a'...'z' => c as u8 + 1 - 'a' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/session.rs:73:40 [INFO] [stderr] | [INFO] [stderr] 73 | 'A'...'Z' => c as u8 + 1 - 'A' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/session.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | .and_then(|s| Ok(s)); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/session.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | let command = if program.find(" ").is_some() { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/session.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | / rcfile.write(b"include () { [[ -f \"$1\" ]] && source \"$1\"; }\n\ [INFO] [stderr] 380 | | include /etc/bash.bashrc\n\ [INFO] [stderr] 381 | | include ~/.bashrc\n\ [INFO] [stderr] 382 | | PS1=\"~~~~\"\n\ [INFO] [stderr] 383 | | unset PROMPT_COMMAND\n").expect("cannot write to tmpfile"); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/session.rs:385:74 [INFO] [stderr] | [INFO] [stderr] 385 | c.args(&["--rcfile", rcfile.path().to_str().unwrap_or_else(|| return "temp file does not exist".into())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"temp file does not exist"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let printable = match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 33 | | &ReadUntil::String(ref s) if s == "\n" => "\\n (newline)".to_string(), [INFO] [stderr] 34 | | &ReadUntil::String(ref s) if s == "\r" => "\\r (carriage return)".to_string(), [INFO] [stderr] 35 | | &ReadUntil::String(ref s) => format!("\"{}\"", s), [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | let printable = match *self { [INFO] [stderr] 33 | ReadUntil::String(ref s) if s == "\n" => "\\n (newline)".to_string(), [INFO] [stderr] 34 | ReadUntil::String(ref s) if s == "\r" => "\\r (carriage return)".to_string(), [INFO] [stderr] 35 | ReadUntil::String(ref s) => format!("\"{}\"", s), [INFO] [stderr] 36 | ReadUntil::Regex(ref r) => format!("Regex: \"{}\"", r), [INFO] [stderr] 37 | ReadUntil::EOF => "EOF (End of File)".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / match needle { [INFO] [stderr] 65 | | &ReadUntil::String(ref s) => buffer.find(s).and_then(|pos| Some((pos, pos + s.len()))), [INFO] [stderr] 66 | | &ReadUntil::Regex(ref pattern) => { [INFO] [stderr] 67 | | if let Some(mat) = pattern.find(buffer) { [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *needle { [INFO] [stderr] 65 | ReadUntil::String(ref s) => buffer.find(s).and_then(|pos| Some((pos, pos + s.len()))), [INFO] [stderr] 66 | ReadUntil::Regex(ref pattern) => { [INFO] [stderr] 67 | if let Some(mat) = pattern.find(buffer) { [INFO] [stderr] 68 | Some((mat.start(), mat.end())) [INFO] [stderr] 69 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | } else if eof && buffer.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let _ = tx.send(Ok(PipedChar::EOF)).chain_err(|| "cannot send")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | if self.buffer.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:107:31 [INFO] [stderr] | [INFO] [stderr] 107 | .unwrap_or("unknown".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | + timeout.subsec_nanos() / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `timeout.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rexpect`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/session.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/session.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | let res = self.exp(&ReadUntil::Regex(Regex::new(regex).chain_err(|| "invalid regex")?)) [INFO] [stderr] | ___________________^ [INFO] [stderr] 142 | | .and_then(|s| Ok(s)); [INFO] [stderr] | |________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/session.rs:385:67 [INFO] [stderr] | [INFO] [stderr] 385 | c.args(&["--rcfile", rcfile.path().to_str().unwrap_or_else(|| return "temp file does not exist".into())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"temp file does not exist".into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/process.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / match self.status() { [INFO] [stderr] 237 | | Some(wait::WaitStatus::StillAlive) => { [INFO] [stderr] 238 | | self.exit().expect("cannot exit"); [INFO] [stderr] 239 | | } [INFO] [stderr] 240 | | _ => {} [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 236 | if let Some(wait::WaitStatus::StillAlive) = self.status() { [INFO] [stderr] 237 | self.exit().expect("cannot exit"); [INFO] [stderr] 238 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/process.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | writer.write(b"hello cat\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/session.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | .write(&['\n' as u8]) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/session.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | 'a'...'z' => c as u8 + 1 - 'a' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/session.rs:73:40 [INFO] [stderr] | [INFO] [stderr] 73 | 'A'...'Z' => c as u8 + 1 - 'A' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/session.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | .and_then(|s| Ok(s)); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/session.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | let command = if program.find(" ").is_some() { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/session.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | / rcfile.write(b"include () { [[ -f \"$1\" ]] && source \"$1\"; }\n\ [INFO] [stderr] 380 | | include /etc/bash.bashrc\n\ [INFO] [stderr] 381 | | include ~/.bashrc\n\ [INFO] [stderr] 382 | | PS1=\"~~~~\"\n\ [INFO] [stderr] 383 | | unset PROMPT_COMMAND\n").expect("cannot write to tmpfile"); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/session.rs:385:74 [INFO] [stderr] | [INFO] [stderr] 385 | c.args(&["--rcfile", rcfile.path().to_str().unwrap_or_else(|| return "temp file does not exist".into())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"temp file does not exist"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let printable = match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 33 | | &ReadUntil::String(ref s) if s == "\n" => "\\n (newline)".to_string(), [INFO] [stderr] 34 | | &ReadUntil::String(ref s) if s == "\r" => "\\r (carriage return)".to_string(), [INFO] [stderr] 35 | | &ReadUntil::String(ref s) => format!("\"{}\"", s), [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | let printable = match *self { [INFO] [stderr] 33 | ReadUntil::String(ref s) if s == "\n" => "\\n (newline)".to_string(), [INFO] [stderr] 34 | ReadUntil::String(ref s) if s == "\r" => "\\r (carriage return)".to_string(), [INFO] [stderr] 35 | ReadUntil::String(ref s) => format!("\"{}\"", s), [INFO] [stderr] 36 | ReadUntil::Regex(ref r) => format!("Regex: \"{}\"", r), [INFO] [stderr] 37 | ReadUntil::EOF => "EOF (End of File)".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / match needle { [INFO] [stderr] 65 | | &ReadUntil::String(ref s) => buffer.find(s).and_then(|pos| Some((pos, pos + s.len()))), [INFO] [stderr] 66 | | &ReadUntil::Regex(ref pattern) => { [INFO] [stderr] 67 | | if let Some(mat) = pattern.find(buffer) { [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *needle { [INFO] [stderr] 65 | ReadUntil::String(ref s) => buffer.find(s).and_then(|pos| Some((pos, pos + s.len()))), [INFO] [stderr] 66 | ReadUntil::Regex(ref pattern) => { [INFO] [stderr] 67 | if let Some(mat) = pattern.find(buffer) { [INFO] [stderr] 68 | Some((mat.start(), mat.end())) [INFO] [stderr] 69 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | } else if eof && buffer.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reader.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | let _ = tx.send(Ok(PipedChar::EOF)).chain_err(|| "cannot send")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | if self.buffer.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:107:31 [INFO] [stderr] | [INFO] [stderr] 107 | .unwrap_or("unknown".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | + timeout.subsec_nanos() / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `timeout.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rexpect`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "87346f7218fef3c7fddc9fdb55590f9a5e226cda9fa7c47c40993921237f6917"` [INFO] running `"docker" "rm" "-f" "87346f7218fef3c7fddc9fdb55590f9a5e226cda9fa7c47c40993921237f6917"` [INFO] [stdout] 87346f7218fef3c7fddc9fdb55590f9a5e226cda9fa7c47c40993921237f6917