[INFO] updating cached repository phil-opp/cargo-update-installed [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phil-opp/cargo-update-installed [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phil-opp/cargo-update-installed" "work/ex/clippy-test-run/sources/stable/gh/phil-opp/cargo-update-installed"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phil-opp/cargo-update-installed'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phil-opp/cargo-update-installed" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phil-opp/cargo-update-installed"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phil-opp/cargo-update-installed'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eb029ca8ed294571fd24b8a68f70e3ba1bfc705b [INFO] sha for GitHub repo phil-opp/cargo-update-installed: eb029ca8ed294571fd24b8a68f70e3ba1bfc705b [INFO] validating manifest of phil-opp/cargo-update-installed on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phil-opp/cargo-update-installed on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phil-opp/cargo-update-installed [INFO] finished frobbing phil-opp/cargo-update-installed [INFO] frobbed toml for phil-opp/cargo-update-installed written to work/ex/clippy-test-run/sources/stable/gh/phil-opp/cargo-update-installed/Cargo.toml [INFO] started frobbing phil-opp/cargo-update-installed [INFO] finished frobbing phil-opp/cargo-update-installed [INFO] frobbed toml for phil-opp/cargo-update-installed written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phil-opp/cargo-update-installed/Cargo.toml [INFO] crate phil-opp/cargo-update-installed has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phil-opp/cargo-update-installed against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phil-opp/cargo-update-installed:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 24b3c09d11a4a2ebecaed547b59f520dae6d51ee847a0f327619380b5f4aa9ec [INFO] running `"docker" "start" "-a" "24b3c09d11a4a2ebecaed547b59f520dae6d51ee847a0f327619380b5f4aa9ec"` [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking cargo-update-installed v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | required_crates: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 37 | pub fn get_latest_versions( [INFO] [stderr] 38 | required_crates: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | .ok_or(format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 118 | | "Error: package {} not found in dummy Cargo.lock", [INFO] [stderr] 119 | | crate_name [INFO] [stderr] 120 | | ))?; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 117 | .ok_or_else(|| format!( [INFO] [stderr] 118 | "Error: package {} not found in dummy Cargo.lock", [INFO] [stderr] 119 | crate_name [INFO] [stderr] 120 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | .ok_or(format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 125 | | "Error: package {} has no version number in dummy Cargo.lock", [INFO] [stderr] 126 | | crate_name [INFO] [stderr] 127 | | ))?; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | .ok_or_else(|| format!( [INFO] [stderr] 125 | "Error: package {} has no version number in dummy Cargo.lock", [INFO] [stderr] 126 | crate_name [INFO] [stderr] 127 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | writeln!(stderr(), "Warning: package {} is present multiple times in dummy Cargo.lock. Choosing version {}.", crate_name, version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | if line.starts_with(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:185:36 [INFO] [stderr] | [INFO] [stderr] 185 | let mut parts = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:189:33 [INFO] [stderr] | [INFO] [stderr] 189 | if !version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:194:30 [INFO] [stderr] | [INFO] [stderr] 194 | if version.ends_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:204:45 [INFO] [stderr] | [INFO] [stderr] 204 | if !dependency_path.starts_with("(") || !dependency_path.ends_with("):") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | / writeln!( [INFO] [stderr] 214 | | stderr(), [INFO] [stderr] 215 | | "Warning: Git binaries are not supported. Ignoring `{}`.", [INFO] [stderr] 216 | | name [INFO] [stderr] 217 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | / writeln!( [INFO] [stderr] 222 | | stderr(), [INFO] [stderr] 223 | | "Warning: Local binaries are not supported. Ignoring `{}`.", [INFO] [stderr] 224 | | name [INFO] [stderr] 225 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | required_crates: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 37 | pub fn get_latest_versions( [INFO] [stderr] 38 | required_crates: &HashMap, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | .ok_or(format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 118 | | "Error: package {} not found in dummy Cargo.lock", [INFO] [stderr] 119 | | crate_name [INFO] [stderr] 120 | | ))?; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 117 | .ok_or_else(|| format!( [INFO] [stderr] 118 | "Error: package {} not found in dummy Cargo.lock", [INFO] [stderr] 119 | crate_name [INFO] [stderr] 120 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | .ok_or(format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 125 | | "Error: package {} has no version number in dummy Cargo.lock", [INFO] [stderr] 126 | | crate_name [INFO] [stderr] 127 | | ))?; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | .ok_or_else(|| format!( [INFO] [stderr] 125 | "Error: package {} has no version number in dummy Cargo.lock", [INFO] [stderr] 126 | crate_name [INFO] [stderr] 127 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | writeln!(stderr(), "Warning: package {} is present multiple times in dummy Cargo.lock. Choosing version {}.", crate_name, version); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | if line.starts_with(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:185:36 [INFO] [stderr] | [INFO] [stderr] 185 | let mut parts = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:189:33 [INFO] [stderr] | [INFO] [stderr] 189 | if !version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:194:30 [INFO] [stderr] | [INFO] [stderr] 194 | if version.ends_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:204:45 [INFO] [stderr] | [INFO] [stderr] 204 | if !dependency_path.starts_with("(") || !dependency_path.ends_with("):") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | / writeln!( [INFO] [stderr] 214 | | stderr(), [INFO] [stderr] 215 | | "Warning: Git binaries are not supported. Ignoring `{}`.", [INFO] [stderr] 216 | | name [INFO] [stderr] 217 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | / writeln!( [INFO] [stderr] 222 | | stderr(), [INFO] [stderr] 223 | | "Warning: Local binaries are not supported. Ignoring `{}`.", [INFO] [stderr] 224 | | name [INFO] [stderr] 225 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | writeln!(stderr(), "Error: {}", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(format!("Error: No latest version found for {}", c.name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Error: No latest version found for {}", c.name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | writeln!(stderr(), "Error: {}", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(format!("Error: No latest version found for {}", c.name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Error: No latest version found for {}", c.name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.17s [INFO] running `"docker" "inspect" "24b3c09d11a4a2ebecaed547b59f520dae6d51ee847a0f327619380b5f4aa9ec"` [INFO] running `"docker" "rm" "-f" "24b3c09d11a4a2ebecaed547b59f520dae6d51ee847a0f327619380b5f4aa9ec"` [INFO] [stdout] 24b3c09d11a4a2ebecaed547b59f520dae6d51ee847a0f327619380b5f4aa9ec