[INFO] updating cached repository phaux/rust-brainfuck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phaux/rust-brainfuck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phaux/rust-brainfuck" "work/ex/clippy-test-run/sources/stable/gh/phaux/rust-brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phaux/rust-brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phaux/rust-brainfuck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phaux/rust-brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phaux/rust-brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] de0ae600a9abadf78c37a7bbd5ec92c54cd37a26 [INFO] sha for GitHub repo phaux/rust-brainfuck: de0ae600a9abadf78c37a7bbd5ec92c54cd37a26 [INFO] validating manifest of phaux/rust-brainfuck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phaux/rust-brainfuck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phaux/rust-brainfuck [INFO] finished frobbing phaux/rust-brainfuck [INFO] frobbed toml for phaux/rust-brainfuck written to work/ex/clippy-test-run/sources/stable/gh/phaux/rust-brainfuck/Cargo.toml [INFO] started frobbing phaux/rust-brainfuck [INFO] finished frobbing phaux/rust-brainfuck [INFO] frobbed toml for phaux/rust-brainfuck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phaux/rust-brainfuck/Cargo.toml [INFO] crate phaux/rust-brainfuck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phaux/rust-brainfuck against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/phaux/rust-brainfuck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 000ea1aa2b18d44dcf317aae337ac8bb757a38642fbba66ca908a437daa6e351 [INFO] running `"docker" "start" "-a" "000ea1aa2b18d44dcf317aae337ac8bb757a38642fbba66ca908a437daa6e351"` [INFO] [stderr] Checking brainfuck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | fn run_program(prog: &Vec, data: &mut [u8], ptr: &mut usize) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Cmd]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | Cmd::Set(n) => data[*ptr] = ((data[*ptr] as i32) + n) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data[*ptr])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:43:55 [INFO] [stderr] | [INFO] [stderr] 43 | std::io::stdin().read_exact(&mut data[*ptr..*ptr+1]) [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `*ptr..=*ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | fn run_program(prog: &Vec, data: &mut [u8], ptr: &mut usize) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Cmd]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | Cmd::Set(n) => data[*ptr] = ((data[*ptr] as i32) + n) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data[*ptr])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:43:55 [INFO] [stderr] | [INFO] [stderr] 43 | std::io::stdin().read_exact(&mut data[*ptr..*ptr+1]) [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `*ptr..=*ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "000ea1aa2b18d44dcf317aae337ac8bb757a38642fbba66ca908a437daa6e351"` [INFO] running `"docker" "rm" "-f" "000ea1aa2b18d44dcf317aae337ac8bb757a38642fbba66ca908a437daa6e351"` [INFO] [stdout] 000ea1aa2b18d44dcf317aae337ac8bb757a38642fbba66ca908a437daa6e351