[INFO] updating cached repository pfac/zsh-git-prompt-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pfac/zsh-git-prompt-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pfac/zsh-git-prompt-rs" "work/ex/clippy-test-run/sources/stable/gh/pfac/zsh-git-prompt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pfac/zsh-git-prompt-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pfac/zsh-git-prompt-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pfac/zsh-git-prompt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pfac/zsh-git-prompt-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b793a10b65cc39957c2fd1cfb990a2b5e7c47ed8 [INFO] sha for GitHub repo pfac/zsh-git-prompt-rs: b793a10b65cc39957c2fd1cfb990a2b5e7c47ed8 [INFO] validating manifest of pfac/zsh-git-prompt-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pfac/zsh-git-prompt-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pfac/zsh-git-prompt-rs [INFO] finished frobbing pfac/zsh-git-prompt-rs [INFO] frobbed toml for pfac/zsh-git-prompt-rs written to work/ex/clippy-test-run/sources/stable/gh/pfac/zsh-git-prompt-rs/Cargo.toml [INFO] started frobbing pfac/zsh-git-prompt-rs [INFO] finished frobbing pfac/zsh-git-prompt-rs [INFO] frobbed toml for pfac/zsh-git-prompt-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pfac/zsh-git-prompt-rs/Cargo.toml [INFO] crate pfac/zsh-git-prompt-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pfac/zsh-git-prompt-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pfac/zsh-git-prompt-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b047151eca7c12a00670a644f8a864e952b63e010aa790ab24e2d5c3df9cd75 [INFO] running `"docker" "start" "-a" "0b047151eca7c12a00670a644f8a864e952b63e010aa790ab24e2d5c3df9cd75"` [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking my-git-prompt v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 42 | | if let Some(oid) = head.target() { [INFO] [stderr] 43 | | let hash = oid.to_string(); [INFO] [stderr] 44 | | println!("[{}]", &hash[..7]); [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | } else if let Some(oid) = head.target() { [INFO] [stderr] 42 | let hash = oid.to_string(); [INFO] [stderr] 43 | println!("[{}]", &hash[..7]); [INFO] [stderr] 44 | } else { [INFO] [stderr] 45 | panic!("Current branch has no name or reference"); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 42 | | if let Some(oid) = head.target() { [INFO] [stderr] 43 | | let hash = oid.to_string(); [INFO] [stderr] 44 | | println!("[{}]", &hash[..7]); [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | } else if let Some(oid) = head.target() { [INFO] [stderr] 42 | let hash = oid.to_string(); [INFO] [stderr] 43 | println!("[{}]", &hash[..7]); [INFO] [stderr] 44 | } else { [INFO] [stderr] 45 | panic!("Current branch has no name or reference"); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.15s [INFO] running `"docker" "inspect" "0b047151eca7c12a00670a644f8a864e952b63e010aa790ab24e2d5c3df9cd75"` [INFO] running `"docker" "rm" "-f" "0b047151eca7c12a00670a644f8a864e952b63e010aa790ab24e2d5c3df9cd75"` [INFO] [stdout] 0b047151eca7c12a00670a644f8a864e952b63e010aa790ab24e2d5c3df9cd75