[INFO] updating cached repository peterdn/shutter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/peterdn/shutter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/peterdn/shutter" "work/ex/clippy-test-run/sources/stable/gh/peterdn/shutter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/peterdn/shutter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/peterdn/shutter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterdn/shutter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterdn/shutter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 47371302a53550619f64fae8640fe19687da11b5 [INFO] sha for GitHub repo peterdn/shutter: 47371302a53550619f64fae8640fe19687da11b5 [INFO] validating manifest of peterdn/shutter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peterdn/shutter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peterdn/shutter [INFO] finished frobbing peterdn/shutter [INFO] frobbed toml for peterdn/shutter written to work/ex/clippy-test-run/sources/stable/gh/peterdn/shutter/Cargo.toml [INFO] started frobbing peterdn/shutter [INFO] finished frobbing peterdn/shutter [INFO] frobbed toml for peterdn/shutter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterdn/shutter/Cargo.toml [INFO] crate peterdn/shutter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peterdn/shutter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/peterdn/shutter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc7669903c82e5392d6e179e7466562fc5f0b70ddd68e15ce69b6f386481ffd4 [INFO] running `"docker" "start" "-a" "fc7669903c82e5392d6e179e7466562fc5f0b70ddd68e15ce69b6f386481ffd4"` [INFO] [stderr] Compiling serde v1.0.64 [INFO] [stderr] Checking assert_matches v1.2.0 [INFO] [stderr] Compiling openssl-sys v0.9.31 [INFO] [stderr] Compiling proc-macro2 v0.4.4 [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking libflate v0.1.14 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling syn v0.14.1 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.65 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking instagram-scraper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scrape.rs:180:57 [INFO] [stderr] | [INFO] [stderr] 180 | taken_at_timestamp: 1200000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_200_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scrape.rs:186:57 [INFO] [stderr] | [INFO] [stderr] 186 | taken_at_timestamp: 1300000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_300_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/profile.rs:67:49 [INFO] [stderr] | [INFO] [stderr] 67 | taken_at_timestamp: 1200000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_200_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/profile.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | taken_at_timestamp: 1300000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_300_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/profile.rs:91:65 [INFO] [stderr] | [INFO] [stderr] 91 | PostImage::new("https://peterdn.com/1.jpg", 1200000000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_200_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/profile.rs:92:65 [INFO] [stderr] | [INFO] [stderr] 92 | PostImage::new("https://peterdn.com/2.jpg", 1300000000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_300_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/scrape.rs:62:58 [INFO] [stderr] | [INFO] [stderr] 62 | serde_json::from_value(user_data_json_value).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/scrape.rs:62:58 [INFO] [stderr] | [INFO] [stderr] 62 | serde_json::from_value(user_data_json_value).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/scrape.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | Ok(ref json) if *json == r#"{"username": "peterdn"}"#.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/scrape.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(ref json) if *json == r#"{"username": "peterdn", "data": {}}"#.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/app/main.rs:116:58 [INFO] [stderr] | [INFO] [stderr] 116 | let timestamp = UNIX_EPOCH + Duration::from_secs(1230000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_230_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.08s [INFO] running `"docker" "inspect" "fc7669903c82e5392d6e179e7466562fc5f0b70ddd68e15ce69b6f386481ffd4"` [INFO] running `"docker" "rm" "-f" "fc7669903c82e5392d6e179e7466562fc5f0b70ddd68e15ce69b6f386481ffd4"` [INFO] [stdout] fc7669903c82e5392d6e179e7466562fc5f0b70ddd68e15ce69b6f386481ffd4