[INFO] updating cached repository peterdelevoryas/io-state-machine-prototype4 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/peterdelevoryas/io-state-machine-prototype4 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/peterdelevoryas/io-state-machine-prototype4" "work/ex/clippy-test-run/sources/stable/gh/peterdelevoryas/io-state-machine-prototype4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/peterdelevoryas/io-state-machine-prototype4'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/peterdelevoryas/io-state-machine-prototype4" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterdelevoryas/io-state-machine-prototype4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterdelevoryas/io-state-machine-prototype4'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 59a8fe24ee6aff714d9dfac6abb54d62b80735f4 [INFO] sha for GitHub repo peterdelevoryas/io-state-machine-prototype4: 59a8fe24ee6aff714d9dfac6abb54d62b80735f4 [INFO] validating manifest of peterdelevoryas/io-state-machine-prototype4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peterdelevoryas/io-state-machine-prototype4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peterdelevoryas/io-state-machine-prototype4 [INFO] finished frobbing peterdelevoryas/io-state-machine-prototype4 [INFO] frobbed toml for peterdelevoryas/io-state-machine-prototype4 written to work/ex/clippy-test-run/sources/stable/gh/peterdelevoryas/io-state-machine-prototype4/Cargo.toml [INFO] started frobbing peterdelevoryas/io-state-machine-prototype4 [INFO] finished frobbing peterdelevoryas/io-state-machine-prototype4 [INFO] frobbed toml for peterdelevoryas/io-state-machine-prototype4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterdelevoryas/io-state-machine-prototype4/Cargo.toml [INFO] crate peterdelevoryas/io-state-machine-prototype4 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peterdelevoryas/io-state-machine-prototype4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/peterdelevoryas/io-state-machine-prototype4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7aedbe2428ff0cf017ed16e505b8261f24ddcac222e560cb96cae9a01d2fd66a [INFO] running `"docker" "start" "-a" "7aedbe2428ff0cf017ed16e505b8261f24ddcac222e560cb96cae9a01d2fd66a"` [INFO] [stderr] Checking io-state-machine-prototype4 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:70 [INFO] [stderr] | [INFO] [stderr] 52 | let conn_task_slab_index = task_slab.insert(Task::Conn { conn_slab_index: conn_slab_index }).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conn_slab_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:70 [INFO] [stderr] | [INFO] [stderr] 52 | let conn_task_slab_index = task_slab.insert(Task::Conn { conn_slab_index: conn_slab_index }).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conn_slab_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:140:47 [INFO] [stderr] | [INFO] [stderr] 140 | Task::Conn { conn_slab_index: i } => { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | TaskStatus::Done(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:167:47 [INFO] [stderr] | [INFO] [stderr] 167 | Task::Conn { conn_slab_index: i } => { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | TaskStatus::Done(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ready` [INFO] [stderr] --> src/main.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | ready: mio::Ready, [INFO] [stderr] | ^^^^^ help: consider using `_ready` instead [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:140:47 [INFO] [stderr] | [INFO] [stderr] 140 | Task::Conn { conn_slab_index: i } => { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | TaskStatus::Done(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:167:47 [INFO] [stderr] | [INFO] [stderr] 167 | Task::Conn { conn_slab_index: i } => { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/main.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | TaskStatus::Done(result) => { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ready` [INFO] [stderr] --> src/main.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | ready: mio::Ready, [INFO] [stderr] | ^^^^^ help: consider using `_ready` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `KineticRequest` [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | KineticRequest, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `KineticRequest` [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | KineticRequest, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / match run() { [INFO] [stderr] 192 | | Err(err) => println!("# Error: {}", err), [INFO] [stderr] 193 | | _ => (), [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = run() { println!("# Error: {}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / match run() { [INFO] [stderr] 192 | | Err(err) => println!("# Error: {}", err), [INFO] [stderr] 193 | | _ => (), [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = run() { println!("# Error: {}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "7aedbe2428ff0cf017ed16e505b8261f24ddcac222e560cb96cae9a01d2fd66a"` [INFO] running `"docker" "rm" "-f" "7aedbe2428ff0cf017ed16e505b8261f24ddcac222e560cb96cae9a01d2fd66a"` [INFO] [stdout] 7aedbe2428ff0cf017ed16e505b8261f24ddcac222e560cb96cae9a01d2fd66a