[INFO] updating cached repository peterallin/the-great-replacer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/peterallin/the-great-replacer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/peterallin/the-great-replacer" "work/ex/clippy-test-run/sources/stable/gh/peterallin/the-great-replacer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/peterallin/the-great-replacer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/peterallin/the-great-replacer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterallin/the-great-replacer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterallin/the-great-replacer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 746e1bef208739ab46e96b2549eda2d903931b8f [INFO] sha for GitHub repo peterallin/the-great-replacer: 746e1bef208739ab46e96b2549eda2d903931b8f [INFO] validating manifest of peterallin/the-great-replacer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peterallin/the-great-replacer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peterallin/the-great-replacer [INFO] finished frobbing peterallin/the-great-replacer [INFO] frobbed toml for peterallin/the-great-replacer written to work/ex/clippy-test-run/sources/stable/gh/peterallin/the-great-replacer/Cargo.toml [INFO] started frobbing peterallin/the-great-replacer [INFO] finished frobbing peterallin/the-great-replacer [INFO] frobbed toml for peterallin/the-great-replacer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterallin/the-great-replacer/Cargo.toml [INFO] crate peterallin/the-great-replacer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peterallin/the-great-replacer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/peterallin/the-great-replacer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d9ea8b9f707a7df1c1f39e41a34d3fd469cf5554a03f4a3f1cc926d20352c314 [INFO] running `"docker" "start" "-a" "d9ea8b9f707a7df1c1f39e41a34d3fd469cf5554a03f4a3f1cc926d20352c314"` [INFO] [stderr] Compiling cmake v0.1.33 [INFO] [stderr] Compiling libz-sys v1.0.20 [INFO] [stderr] Compiling curl-sys v0.4.8 [INFO] [stderr] Compiling libssh2-sys v0.2.10 [INFO] [stderr] Compiling libgit2-sys v0.7.7 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking the-great-replacer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gittools.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match branch.0.into_reference().name() { [INFO] [stderr] 14 | | Some(b) => result.push(b.to_string()), [INFO] [stderr] 15 | | None => {} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(b) = branch.0.into_reference().name() { result.push(b.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gittools.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/replace.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | file.write(contents.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `the-great-replacer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gittools.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match branch.0.into_reference().name() { [INFO] [stderr] 14 | | Some(b) => result.push(b.to_string()), [INFO] [stderr] 15 | | None => {} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(b) = branch.0.into_reference().name() { result.push(b.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gittools.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | branches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/replace.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | file.write(contents.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `the-great-replacer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d9ea8b9f707a7df1c1f39e41a34d3fd469cf5554a03f4a3f1cc926d20352c314"` [INFO] running `"docker" "rm" "-f" "d9ea8b9f707a7df1c1f39e41a34d3fd469cf5554a03f4a3f1cc926d20352c314"` [INFO] [stdout] d9ea8b9f707a7df1c1f39e41a34d3fd469cf5554a03f4a3f1cc926d20352c314