[INFO] updating cached repository permil/rust-puyo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/permil/rust-puyo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/permil/rust-puyo" "work/ex/clippy-test-run/sources/stable/gh/permil/rust-puyo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/permil/rust-puyo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/permil/rust-puyo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/permil/rust-puyo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/permil/rust-puyo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e19bedab9bf3f0c7bd1325910dd49f55d608dce [INFO] sha for GitHub repo permil/rust-puyo: 8e19bedab9bf3f0c7bd1325910dd49f55d608dce [INFO] validating manifest of permil/rust-puyo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of permil/rust-puyo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing permil/rust-puyo [INFO] finished frobbing permil/rust-puyo [INFO] frobbed toml for permil/rust-puyo written to work/ex/clippy-test-run/sources/stable/gh/permil/rust-puyo/Cargo.toml [INFO] started frobbing permil/rust-puyo [INFO] finished frobbing permil/rust-puyo [INFO] frobbed toml for permil/rust-puyo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/permil/rust-puyo/Cargo.toml [INFO] crate permil/rust-puyo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting permil/rust-puyo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/permil/rust-puyo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc13c77c8b80ba816923720172ee9a0c0f348e27284b79cbb274393e1d79628f [INFO] running `"docker" "start" "-a" "dc13c77c8b80ba816923720172ee9a0c0f348e27284b79cbb274393e1d79628f"` [INFO] [stderr] Compiling libc v0.2.24 [INFO] [stderr] Compiling num-traits v0.1.39 [INFO] [stderr] Checking num_cpus v1.5.1 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Compiling gl_generator v0.5.3 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking gfx v0.16.0 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking num-integer v0.1.34 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking rayon v0.8.1 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.1.38 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling gl v0.6.2 [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking piston-gfx_texture v0.25.0 [INFO] [stderr] Checking gfx_device_gl v0.14.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.41.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking piston_window v0.67.0 [INFO] [stderr] Checking puyo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/field.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | / if !self.drop() { [INFO] [stderr] 90 | | if !self.erase() { [INFO] [stderr] 91 | | self.x = 3; [INFO] [stderr] 92 | | self.y = CEIL; [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | if !self.drop() && !self.erase() { [INFO] [stderr] 90 | self.x = 3; [INFO] [stderr] 91 | self.y = CEIL; [INFO] [stderr] 92 | self.kind = rand::thread_rng().gen_range(1, 4); [INFO] [stderr] 93 | self.state = State::Move; [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/field.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | / if !self.drop() { [INFO] [stderr] 90 | | if !self.erase() { [INFO] [stderr] 91 | | self.x = 3; [INFO] [stderr] 92 | | self.y = CEIL; [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | if !self.drop() && !self.erase() { [INFO] [stderr] 90 | self.x = 3; [INFO] [stderr] 91 | self.y = CEIL; [INFO] [stderr] 92 | self.kind = rand::thread_rng().gen_range(1, 4); [INFO] [stderr] 93 | self.state = State::Move; [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | if let Some(ref args) = e.render_args() { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `column` [INFO] [stderr] --> src/field.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | let mut column = self.grids[i]; [INFO] [stderr] | ^^^^^^ help: consider using `_column` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `column` [INFO] [stderr] --> src/field.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | let mut column = self.grids[i]; [INFO] [stderr] | ^^^^^^ help: consider using `_column` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | fn color(&self, n: &usize) -> [f32; 4] { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/field.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 1..WIDTH+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=WIDTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/field.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 1..WIDTH+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=WIDTH` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/field.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for j in CEIL..HEIGHT+CEIL+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `CEIL..=HEIGHT+CEIL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/field.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if x <= 0 || x > WIDTH || y < CEIL || y > CEIL+HEIGHT { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using x == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `puyo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | if let Some(ref args) = e.render_args() { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `column` [INFO] [stderr] --> src/field.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | let mut column = self.grids[i]; [INFO] [stderr] | ^^^^^^ help: consider using `_column` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `column` [INFO] [stderr] --> src/field.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | let mut column = self.grids[i]; [INFO] [stderr] | ^^^^^^ help: consider using `_column` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | fn color(&self, n: &usize) -> [f32; 4] { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/field.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 1..WIDTH+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=WIDTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/field.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 1..WIDTH+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=WIDTH` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/field.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for j in CEIL..HEIGHT+CEIL+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `CEIL..=HEIGHT+CEIL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/field.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if x <= 0 || x > WIDTH || y < CEIL || y > CEIL+HEIGHT { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using x == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `puyo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dc13c77c8b80ba816923720172ee9a0c0f348e27284b79cbb274393e1d79628f"` [INFO] running `"docker" "rm" "-f" "dc13c77c8b80ba816923720172ee9a0c0f348e27284b79cbb274393e1d79628f"` [INFO] [stdout] dc13c77c8b80ba816923720172ee9a0c0f348e27284b79cbb274393e1d79628f