[INFO] updating cached repository pepone42/raytracer.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pepone42/raytracer.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pepone42/raytracer.rs" "work/ex/clippy-test-run/sources/stable/gh/pepone42/raytracer.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pepone42/raytracer.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pepone42/raytracer.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepone42/raytracer.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepone42/raytracer.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c9bf53733c283bede7f8369c66fa9fd04c60a732 [INFO] sha for GitHub repo pepone42/raytracer.rs: c9bf53733c283bede7f8369c66fa9fd04c60a732 [INFO] validating manifest of pepone42/raytracer.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pepone42/raytracer.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pepone42/raytracer.rs [INFO] finished frobbing pepone42/raytracer.rs [INFO] frobbed toml for pepone42/raytracer.rs written to work/ex/clippy-test-run/sources/stable/gh/pepone42/raytracer.rs/Cargo.toml [INFO] started frobbing pepone42/raytracer.rs [INFO] finished frobbing pepone42/raytracer.rs [INFO] frobbed toml for pepone42/raytracer.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepone42/raytracer.rs/Cargo.toml [INFO] crate pepone42/raytracer.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pepone42/raytracer.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pepone42/raytracer.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51c9deef2de7dd62d93cafe71a682ae5b93d04518e55828966529fb579d9f251 [INFO] running `"docker" "start" "-a" "51c9deef2de7dd62d93cafe71a682ae5b93d04518e55828966529fb579d9f251"` [INFO] [stderr] Checking libc v0.1.12 [INFO] [stderr] Checking dylib v0.0.1 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Compiling minifb v0.9.1 [INFO] [stderr] Checking x11-dl v2.2.1 [INFO] [stderr] Checking raytrace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: equal expressions as operands to `^` [INFO] [stderr] --> src/sphere.rs:32:55 [INFO] [stderr] | [INFO] [stderr] 32 | let disc = (self.radius * self.radius) - ((eo ^ eo) - (v * v)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytracer.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | start: pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytracer.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | dir: reflect_dir.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `reflect_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | let width = (width * oversampling) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width * oversampling)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:127:26 [INFO] [stderr] | [INFO] [stderr] 127 | let height = (height * oversampling) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height * oversampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytracer.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | start: self.scene.camera.pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scene.camera.pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:143:45 [INFO] [stderr] | [INFO] [stderr] 143 | (x * oversampling + xx) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x * oversampling + xx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:144:45 [INFO] [stderr] | [INFO] [stderr] 144 | (y * oversampling + yy) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y * oversampling + yy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | color * (1.0 / ((oversampling * oversampling) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(oversampling * oversampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `raytrace`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / assert_eq!( [INFO] [stderr] 129 | | 10.0, [INFO] [stderr] 130 | | Vector3::new(1.0, 2.0, 3.0) ^ Vector3::new(3.0, 2.0, 1.0) [INFO] [stderr] 131 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / assert_eq!( [INFO] [stderr] 129 | | 10.0, [INFO] [stderr] 130 | | Vector3::new(1.0, 2.0, 3.0) ^ Vector3::new(3.0, 2.0, 1.0) [INFO] [stderr] 131 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector3.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!((14f64).sqrt(), Vector3::new(1.0, 2.0, 3.0).len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector3.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!((14f64).sqrt(), Vector3::new(1.0, 2.0, 3.0).len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `^` [INFO] [stderr] --> src/sphere.rs:32:55 [INFO] [stderr] | [INFO] [stderr] 32 | let disc = (self.radius * self.radius) - ((eo ^ eo) - (v * v)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytracer.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | start: pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytracer.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | dir: reflect_dir.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `reflect_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | let width = (width * oversampling) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width * oversampling)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:127:26 [INFO] [stderr] | [INFO] [stderr] 127 | let height = (height * oversampling) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height * oversampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytracer.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | start: self.scene.camera.pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scene.camera.pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:143:45 [INFO] [stderr] | [INFO] [stderr] 143 | (x * oversampling + xx) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x * oversampling + xx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:144:45 [INFO] [stderr] | [INFO] [stderr] 144 | (y * oversampling + yy) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y * oversampling + yy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/raytracer.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | color * (1.0 / ((oversampling * oversampling) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(oversampling * oversampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `raytrace`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "51c9deef2de7dd62d93cafe71a682ae5b93d04518e55828966529fb579d9f251"` [INFO] running `"docker" "rm" "-f" "51c9deef2de7dd62d93cafe71a682ae5b93d04518e55828966529fb579d9f251"` [INFO] [stdout] 51c9deef2de7dd62d93cafe71a682ae5b93d04518e55828966529fb579d9f251