[INFO] updating cached repository peerhenry/rust_hello_triangle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/peerhenry/rust_hello_triangle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/peerhenry/rust_hello_triangle" "work/ex/clippy-test-run/sources/stable/gh/peerhenry/rust_hello_triangle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/peerhenry/rust_hello_triangle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/peerhenry/rust_hello_triangle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peerhenry/rust_hello_triangle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peerhenry/rust_hello_triangle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d315ea6613c5c9a13b67c7b37befc2569b556382 [INFO] sha for GitHub repo peerhenry/rust_hello_triangle: d315ea6613c5c9a13b67c7b37befc2569b556382 [INFO] validating manifest of peerhenry/rust_hello_triangle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peerhenry/rust_hello_triangle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peerhenry/rust_hello_triangle [INFO] finished frobbing peerhenry/rust_hello_triangle [INFO] frobbed toml for peerhenry/rust_hello_triangle written to work/ex/clippy-test-run/sources/stable/gh/peerhenry/rust_hello_triangle/Cargo.toml [INFO] started frobbing peerhenry/rust_hello_triangle [INFO] finished frobbing peerhenry/rust_hello_triangle [INFO] frobbed toml for peerhenry/rust_hello_triangle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peerhenry/rust_hello_triangle/Cargo.toml [INFO] crate peerhenry/rust_hello_triangle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peerhenry/rust_hello_triangle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/peerhenry/rust_hello_triangle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28db46ac12d08dcf3e86cdb17fd32e0c1bef1ce7e130e141c9dc5028b805fbbc [INFO] running `"docker" "start" "-a" "28db46ac12d08dcf3e86cdb17fd32e0c1bef1ce7e130e141c9dc5028b805fbbc"` [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking rust_hello_triangle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | events_loop: events_loop [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | events_loop: events_loop [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `CString` [INFO] [stderr] --> src/main.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ffi::{CStr, CString}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `CString` [INFO] [stderr] --> src/main.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ffi::{CStr, CString}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/context.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | let mut events_loop = EventsLoop::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/context.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | let mut events_loop = EventsLoop::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:130:7 [INFO] [stderr] | [INFO] [stderr] 130 | / match event { [INFO] [stderr] 131 | | Event::WindowEvent{ event, .. } => { [INFO] [stderr] 132 | | match event { [INFO] [stderr] 133 | | WindowEvent::Closed => { unsafe{ RUNNING = false; } }, [INFO] [stderr] ... | [INFO] [stderr] 137 | | _ => () [INFO] [stderr] 138 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Event::WindowEvent{ event, .. } = event { [INFO] [stderr] 131 | match event { [INFO] [stderr] 132 | WindowEvent::Closed => { unsafe{ RUNNING = false; } }, [INFO] [stderr] 133 | _ => { handle_window_event(event); } [INFO] [stderr] 134 | } [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:152:3 [INFO] [stderr] | [INFO] [stderr] 152 | / match event { [INFO] [stderr] 153 | | WindowEvent::KeyboardInput {input, ..} => { [INFO] [stderr] 154 | | match input.state{ [INFO] [stderr] 155 | | ElementState::Pressed => { [INFO] [stderr] ... | [INFO] [stderr] 169 | | _ => { /* nothing */ } [INFO] [stderr] 170 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | if let WindowEvent::KeyboardInput {input, ..} = event { [INFO] [stderr] 153 | match input.state{ [INFO] [stderr] 154 | ElementState::Pressed => { [INFO] [stderr] 155 | if let Some(keycode) = input.virtual_keycode [INFO] [stderr] 156 | { [INFO] [stderr] 157 | match keycode{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / match keycode{ [INFO] [stderr] 159 | | VirtualKeyCode::Escape => { unsafe{ RUNNING = false; } }, [INFO] [stderr] 160 | | _ => () [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ help: try this: `if let VirtualKeyCode::Escape = keycode { unsafe{ RUNNING = false; } }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:130:7 [INFO] [stderr] | [INFO] [stderr] 130 | / match event { [INFO] [stderr] 131 | | Event::WindowEvent{ event, .. } => { [INFO] [stderr] 132 | | match event { [INFO] [stderr] 133 | | WindowEvent::Closed => { unsafe{ RUNNING = false; } }, [INFO] [stderr] ... | [INFO] [stderr] 137 | | _ => () [INFO] [stderr] 138 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | if let Event::WindowEvent{ event, .. } = event { [INFO] [stderr] 131 | match event { [INFO] [stderr] 132 | WindowEvent::Closed => { unsafe{ RUNNING = false; } }, [INFO] [stderr] 133 | _ => { handle_window_event(event); } [INFO] [stderr] 134 | } [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:152:3 [INFO] [stderr] | [INFO] [stderr] 152 | / match event { [INFO] [stderr] 153 | | WindowEvent::KeyboardInput {input, ..} => { [INFO] [stderr] 154 | | match input.state{ [INFO] [stderr] 155 | | ElementState::Pressed => { [INFO] [stderr] ... | [INFO] [stderr] 169 | | _ => { /* nothing */ } [INFO] [stderr] 170 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | if let WindowEvent::KeyboardInput {input, ..} = event { [INFO] [stderr] 153 | match input.state{ [INFO] [stderr] 154 | ElementState::Pressed => { [INFO] [stderr] 155 | if let Some(keycode) = input.virtual_keycode [INFO] [stderr] 156 | { [INFO] [stderr] 157 | match keycode{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / match keycode{ [INFO] [stderr] 159 | | VirtualKeyCode::Escape => { unsafe{ RUNNING = false; } }, [INFO] [stderr] 160 | | _ => () [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ help: try this: `if let VirtualKeyCode::Escape = keycode { unsafe{ RUNNING = false; } }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.17s [INFO] running `"docker" "inspect" "28db46ac12d08dcf3e86cdb17fd32e0c1bef1ce7e130e141c9dc5028b805fbbc"` [INFO] running `"docker" "rm" "-f" "28db46ac12d08dcf3e86cdb17fd32e0c1bef1ce7e130e141c9dc5028b805fbbc"` [INFO] [stdout] 28db46ac12d08dcf3e86cdb17fd32e0c1bef1ce7e130e141c9dc5028b805fbbc