[INFO] updating cached repository pcostasgr/rustraytracing [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pcostasgr/rustraytracing [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pcostasgr/rustraytracing" "work/ex/clippy-test-run/sources/stable/gh/pcostasgr/rustraytracing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pcostasgr/rustraytracing'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pcostasgr/rustraytracing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pcostasgr/rustraytracing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pcostasgr/rustraytracing'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d2e9704952e3eb54b363b00bc1626e98c1e405b [INFO] sha for GitHub repo pcostasgr/rustraytracing: 6d2e9704952e3eb54b363b00bc1626e98c1e405b [INFO] validating manifest of pcostasgr/rustraytracing on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pcostasgr/rustraytracing on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pcostasgr/rustraytracing [INFO] finished frobbing pcostasgr/rustraytracing [INFO] frobbed toml for pcostasgr/rustraytracing written to work/ex/clippy-test-run/sources/stable/gh/pcostasgr/rustraytracing/Cargo.toml [INFO] started frobbing pcostasgr/rustraytracing [INFO] finished frobbing pcostasgr/rustraytracing [INFO] frobbed toml for pcostasgr/rustraytracing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pcostasgr/rustraytracing/Cargo.toml [INFO] crate pcostasgr/rustraytracing has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pcostasgr/rustraytracing against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pcostasgr/rustraytracing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64962cfbaf8c8e8bd62c119c44bbaa3cf6237394c870ea940bf4f03408dc7d2a [INFO] running `"docker" "start" "-a" "64962cfbaf8c8e8bd62c119c44bbaa3cf6237394c870ea940bf4f03408dc7d2a"` [INFO] [stderr] Checking ray_tracing v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math3d.rs:99:11 [INFO] [stderr] | [INFO] [stderr] 99 | Vec3D{x:x,y:y,z:z} [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math3d.rs:99:15 [INFO] [stderr] | [INFO] [stderr] 99 | Vec3D{x:x,y:y,z:z} [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math3d.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | Vec3D{x:x,y:y,z:z} [INFO] [stderr] | ^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math3d.rs:99:11 [INFO] [stderr] | [INFO] [stderr] 99 | Vec3D{x:x,y:y,z:z} [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math3d.rs:99:15 [INFO] [stderr] | [INFO] [stderr] 99 | Vec3D{x:x,y:y,z:z} [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math3d.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | Vec3D{x:x,y:y,z:z} [INFO] [stderr] | ^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `fmt`, `ptr` [INFO] [stderr] --> src/math3d.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | use std::{ptr,fmt}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math3d.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | const MAX_FLOAT:f32=9999999999999999999999999.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_999_999_999_999_999_999_999_999.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/math3d.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/math3d.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | let r=VecAdd3D(&self.origin,&v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | return &self.material; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | return v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v3f{x:0.0,y:0.0,z:0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | return v3; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `v3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:304:17 [INFO] [stderr] | [INFO] [stderr] 304 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:529:9 [INFO] [stderr] | [INFO] [stderr] 529 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:618:5 [INFO] [stderr] | [INFO] [stderr] 618 | return r0+ ( (1.0-r0)*( (1.0-cosine).powf(5.0) ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r0+ ( (1.0-r0)*( (1.0-cosine).powf(5.0) ) )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/math3d.rs:654:33 [INFO] [stderr] | [INFO] [stderr] 654 | outward_normal.x=-rec.normal.x; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_assignment_formatting)] on by default [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/math3d.rs:655:33 [INFO] [stderr] | [INFO] [stderr] 655 | outward_normal.y=-rec.normal.y; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/math3d.rs:656:33 [INFO] [stderr] | [INFO] [stderr] 656 | outward_normal.z=-rec.normal.z; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/main.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `fmt`, `ptr` [INFO] [stderr] --> src/math3d.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | use std::{ptr,fmt}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math3d.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | const MAX_FLOAT:f32=9999999999999999999999999.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_999_999_999_999_999_999_999_999.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/math3d.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/math3d.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | let r=VecAdd3D(&self.origin,&v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | return &self.material; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | return v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v3f{x:0.0,y:0.0,z:0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | return v3; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `v3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:304:17 [INFO] [stderr] | [INFO] [stderr] 304 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:529:9 [INFO] [stderr] | [INFO] [stderr] 529 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math3d.rs:618:5 [INFO] [stderr] | [INFO] [stderr] 618 | return r0+ ( (1.0-r0)*( (1.0-cosine).powf(5.0) ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r0+ ( (1.0-r0)*( (1.0-cosine).powf(5.0) ) )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/math3d.rs:654:33 [INFO] [stderr] | [INFO] [stderr] 654 | outward_normal.x=-rec.normal.x; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_assignment_formatting)] on by default [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/math3d.rs:655:33 [INFO] [stderr] | [INFO] [stderr] 655 | outward_normal.y=-rec.normal.y; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/math3d.rs:656:33 [INFO] [stderr] | [INFO] [stderr] 656 | outward_normal.z=-rec.normal.z; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/main.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/math3d.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let b:bool; [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `p` is never read [INFO] [stderr] --> src/math3d.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | let mut p=v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let n=500; [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `world` [INFO] [stderr] --> src/main.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn CreateRandomScene(world:& mut math3d::World){ [INFO] [stderr] | ^^^^^ help: consider using `_world` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lower_lef_corner` [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let lower_lef_corner:v3f=v3f{x:-2.0,y:-1.0,z:-1.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_lower_lef_corner` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `horizontal` [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let horizontal:v3f=v3f{x:4.0,y:0.0,z:0.0}; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_horizontal` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vertical` [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let vertical:v3f=v3f{x:0.0,y:2.0,z:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider using `_vertical` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let origin:v3f=v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v00` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let v00=math3d::VecSub3D(&look_from,&look_at); [INFO] [stderr] | ^^^ help: consider using `_v00` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `r1` is never read [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let mut r1:f32=0.0; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `r2` is never read [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | let mut r2:f32=0.0; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/main.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | for s in 0..ns{ [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `hit` [INFO] [stderr] --> src/math3d.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | let mut hit:bool=false; [INFO] [stderr] | ^^^ help: consider using `_hit` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r_in` [INFO] [stderr] --> src/math3d.rs:513:25 [INFO] [stderr] | [INFO] [stderr] 513 | fn Scatter(&self,r_in:&Ray,rec:&HitRecord,attenuation:&mut v3f,scattered:&mut Ray)->bool{ [INFO] [stderr] | ^^^^ help: consider using `_r_in` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `ni_over_nt` is never read [INFO] [stderr] --> src/math3d.rs:640:21 [INFO] [stderr] | [INFO] [stderr] 640 | let mut ni_over_nt:f32=0.0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cosine` is never read [INFO] [stderr] --> src/math3d.rs:647:21 [INFO] [stderr] | [INFO] [stderr] 647 | let mut cosine:f32=0.0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `reflect_prob` is never read [INFO] [stderr] --> src/math3d.rs:648:21 [INFO] [stderr] | [INFO] [stderr] 648 | let mut reflect_prob:f32=0.0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn GetColor(mut ray:Ray,world:& World,depth:i16)->v3f{ [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | let mut unit_direction=VecNorm3D(&ray.direction); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | let mut hit:bool=false; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `v3i` [INFO] [stderr] --> src/math3d.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `Refrect` [INFO] [stderr] --> src/math3d.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn Refrect(v:&v3f,n:&v3f)->v3f{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `HitSphere` [INFO] [stderr] --> src/math3d.rs:246:1 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn HitSphere(center:v3f,radius:f32,r:Ray)->f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | pub fn new()->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `GetRay` [INFO] [stderr] --> src/math3d.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | pub fn GetRay(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `GetRayOld` [INFO] [stderr] --> src/math3d.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | pub fn GetRayOld(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:502:5 [INFO] [stderr] | [INFO] [stderr] 502 | pub fn new(a:v3f)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | pub fn new(a:v3f,f:f32)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:627:5 [INFO] [stderr] | [INFO] [stderr] 627 | pub fn new(ri:f32)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `v3f` should have a camel case name such as `V3f` [INFO] [stderr] --> src/math3d.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | type v3f=Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `v3i` should have a camel case name such as `V3i` [INFO] [stderr] --> src/math3d.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `math3d::HitRecord` [INFO] [stderr] --> src/math3d.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new()->Self{ [INFO] [stderr] 30 | | HitRecord{ [INFO] [stderr] 31 | | t:0.0, [INFO] [stderr] 32 | | p:v3f{x:0.0,y:0.0,z:0.0}, [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for math3d::HitRecord { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait method `Hit` should have a snake case name such as `hit` [INFO] [stderr] --> src/math3d.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | fn Hit(&self,r:Ray,t_min:f32,t_max:f32,rec:& mut HitRecord)->bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: trait method `GetMaterial` should have a snake case name such as `get_material` [INFO] [stderr] --> src/math3d.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | fn GetMaterial(&self)->& Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/math3d.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | fn GetMaterial(&self)->& Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&Material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `math3d::Vec3D` [INFO] [stderr] --> src/math3d.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new()->Self{ [INFO] [stderr] 46 | | v3f{ [INFO] [stderr] 47 | | x:0.0, [INFO] [stderr] 48 | | y:0.0, [INFO] [stderr] 49 | | z:0.0 [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `Length` should have a snake case name such as `length` [INFO] [stderr] --> src/math3d.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn Length(&self)-> f32{ [INFO] [stderr] 54 | | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] 55 | | value.sqrt() [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `SquaredLength` should have a snake case name such as `squared_length` [INFO] [stderr] --> src/math3d.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn SquaredLength(&self)-> f32{ [INFO] [stderr] 59 | | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] 60 | | value [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `ToI32` should have a snake case name such as `to_i32` [INFO] [stderr] --> src/math3d.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn ToI32(&self)->Vec3D{ [INFO] [stderr] 64 | | Vec3D{x:self.x as i32,y:self.y as i32,z:self.z as i32} [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `math3d::Ray` [INFO] [stderr] --> src/math3d.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new()->Self{ [INFO] [stderr] 76 | | Ray{ [INFO] [stderr] 77 | | origin:v3f{x:0.0,y:0.0,z:0.0}, [INFO] [stderr] 78 | | direction:v3f{x:0.0,y:0.0,z:0.0}, [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | impl Default for math3d::Ray { [INFO] [stderr] 75 | fn default() -> Self { [INFO] [stderr] 76 | Self::new() [INFO] [stderr] 77 | } [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `PointAtParameter` should have a snake case name such as `point_at_parameter` [INFO] [stderr] --> src/math3d.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn PointAtParameter(&self,t:f32) -> v3f{ [INFO] [stderr] 83 | | let v=VecMul3D(&self.direction,t); [INFO] [stderr] 84 | | let r=VecAdd3D(&self.origin,&v); [INFO] [stderr] 85 | | r [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `VecDot3D` should have a snake case name such as `vec_dot3_d` [INFO] [stderr] --> src/math3d.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn VecDot3D(v1:&Vec3D,v2:&Vec3D)-> f32{ [INFO] [stderr] 91 | | (v1.x*v2.x+v1.y*v2.y+v1.z*v2.z) [INFO] [stderr] 92 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecCross3D` should have a snake case name such as `vec_cross3_d` [INFO] [stderr] --> src/math3d.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn VecCross3D(v1:&Vec3D,v2:&Vec3D)-> Vec3D{ [INFO] [stderr] 95 | | let x=v1.y*v2.z-v1.z*v2.y; [INFO] [stderr] 96 | | let y=-(v1.x*v2.z)-v1.z*v2.x; [INFO] [stderr] 97 | | let z=v1.x*v2.y-v1.y*v2.x; [INFO] [stderr] 98 | | [INFO] [stderr] 99 | | Vec3D{x:x,y:y,z:z} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecAdd3D` should have a snake case name such as `vec_add3_d` [INFO] [stderr] --> src/math3d.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn VecAdd3D(v1:&Vec3D,v2:&Vec3D)-> Vec3D{ [INFO] [stderr] 103 | | Vec3D{x:v1.x+v2.x,y:v1.y+v2.y,z:v1.z+v2.z} [INFO] [stderr] 104 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecSub3D` should have a snake case name such as `vec_sub3_d` [INFO] [stderr] --> src/math3d.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn VecSub3D(v1:&Vec3D,v2:&Vec3D)-> Vec3D{ [INFO] [stderr] 107 | | Vec3D{x:v1.x-v2.x,y:v1.y-v2.y,z:v1.z-v2.z} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecMul3D` should have a snake case name such as `vec_mul3_d` [INFO] [stderr] --> src/math3d.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn VecMul3D(v:&Vec3D,f:f32)->Vec3D{ [INFO] [stderr] 111 | | Vec3D{x:v.x*f,y:v.y*f,z:v.z*f} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecMulVec3D` should have a snake case name such as `vec_mul_vec3_d` [INFO] [stderr] --> src/math3d.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn VecMulVec3D(v1:&Vec3D,v2:&Vec3D)->Vec3D{ [INFO] [stderr] 115 | | Vec3D{x:v1.x*v2.x,y:v1.y*v2.y,z:v1.z*v2.z} [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecDiv3D` should have a snake case name such as `vec_div3_d` [INFO] [stderr] --> src/math3d.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / pub fn VecDiv3D(v:&v3f,f:f32)->v3f{ [INFO] [stderr] 119 | | [INFO] [stderr] 120 | | //this sucks I'll use an epsilon next time I promise [INFO] [stderr] 121 | | if f!=0.0 { [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecNorm3D` should have a snake case name such as `vec_norm3_d` [INFO] [stderr] --> src/math3d.rs:129:1 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn VecNorm3D(v:&v3f)->v3f{ [INFO] [stderr] 130 | | let length=v.Length(); [INFO] [stderr] 131 | | VecDiv3D(v,length) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `Refrect` should have a snake case name such as `refrect` [INFO] [stderr] --> src/math3d.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn Refrect(v:&v3f,n:&v3f)->v3f{ [INFO] [stderr] 135 | | let result=VecDot3D(&v,&n)*2.0; [INFO] [stderr] 136 | | let nn=VecMul3D(&n,result); [INFO] [stderr] 137 | | VecSub3D(&v,&nn) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `GetColor` should have a snake case name such as `get_color` [INFO] [stderr] --> src/math3d.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / pub fn GetColor(mut ray:Ray,world:& World,depth:i16)->v3f{ [INFO] [stderr] 191 | | [INFO] [stderr] 192 | | let b:bool; [INFO] [stderr] 193 | | [INFO] [stderr] ... | [INFO] [stderr] 243 | | [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `HitSphere` should have a snake case name such as `hit_sphere` [INFO] [stderr] --> src/math3d.rs:246:1 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn HitSphere(center:v3f,radius:f32,r:Ray)->f32 { [INFO] [stderr] 247 | | let oc=VecSub3D(&r.origin,¢er); [INFO] [stderr] 248 | | let a=VecDot3D(&r.direction,&r.direction); [INFO] [stderr] 249 | | let b=2.0*VecDot3D(&oc,&r.direction); [INFO] [stderr] ... | [INFO] [stderr] 258 | | [INFO] [stderr] 259 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `math3d::World` [INFO] [stderr] --> src/math3d.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / pub fn new()->Self { [INFO] [stderr] 268 | | World{ [INFO] [stderr] 269 | | objects:Vec::new(), [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 262 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `Hit` should have a snake case name such as `hit` [INFO] [stderr] --> src/math3d.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / fn Hit(&self,r:Ray,t_min:f32,t_max:f32,rec:& mut HitRecord)->bool{ [INFO] [stderr] 277 | | [INFO] [stderr] 278 | | let mut hit_anything:bool=false; [INFO] [stderr] 279 | | [INFO] [stderr] ... | [INFO] [stderr] 307 | | //return None; [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &self.objects.enumerate()` or similar iterators [INFO] [stderr] --> src/math3d.rs:286:24 [INFO] [stderr] | [INFO] [stderr] 286 | for obj in &self.objects { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:293:31 [INFO] [stderr] | [INFO] [stderr] 293 | rec.p=temp_rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `temp_rec.p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:294:36 [INFO] [stderr] | [INFO] [stderr] 294 | rec.normal=temp_rec.normal.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `temp_rec.normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/math3d.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | / if hit_anything{ [INFO] [stderr] 302 | | return true [INFO] [stderr] 303 | | }else{ [INFO] [stderr] 304 | | return false; [INFO] [stderr] 305 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return hit_anything` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: method `GetRay` should have a snake case name such as `get_ray` [INFO] [stderr] --> src/math3d.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | / pub fn GetRay(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] 337 | | let mut v1=VecMul3D(&self.horizontal,u); [INFO] [stderr] 338 | | let v2=VecMul3D(&self.vertical,v); [INFO] [stderr] 339 | | [INFO] [stderr] ... | [INFO] [stderr] 348 | | r [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `RandomInUnitDisk` should have a snake case name such as `random_in_unit_disk` [INFO] [stderr] --> src/math3d.rs:354:1 [INFO] [stderr] | [INFO] [stderr] 354 | / pub fn RandomInUnitDisk()->v3f { [INFO] [stderr] 355 | | [INFO] [stderr] 356 | | let mut do_loop=true; [INFO] [stderr] 357 | | let mut p=v3f::new(); [INFO] [stderr] ... | [INFO] [stderr] 375 | | [INFO] [stderr] 376 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:407:40 [INFO] [stderr] | [INFO] [stderr] 407 | let mut lower_left_corner_=look_from.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `look_from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: method `GetRayOld` should have a snake case name such as `get_ray_old` [INFO] [stderr] --> src/math3d.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | / pub fn GetRayOld(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] 437 | | let mut v1=VecMul3D(&self.horizontal,u); [INFO] [stderr] 438 | | let v2=VecMul3D(&self.vertical,v); [INFO] [stderr] 439 | | [INFO] [stderr] ... | [INFO] [stderr] 448 | | r [INFO] [stderr] 449 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `GetRay` should have a snake case name such as `get_ray` [INFO] [stderr] --> src/math3d.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | / pub fn GetRay(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] 452 | | [INFO] [stderr] 453 | | let rd_=RandomInUnitDisk(); [INFO] [stderr] 454 | | let rd=VecMul3D(&rd_,self.lens_radius); [INFO] [stderr] ... | [INFO] [stderr] 475 | | r [INFO] [stderr] 476 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `RandomInUnitSphere` should have a snake case name such as `random_in_unit_sphere` [INFO] [stderr] --> src/math3d.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / pub fn RandomInUnitSphere()->v3f{ [INFO] [stderr] 481 | | let mut p=v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] 482 | | loop { [INFO] [stderr] 483 | | let r1=thread_rng().gen_range(0.0,1.0); [INFO] [stderr] ... | [INFO] [stderr] 490 | | p [INFO] [stderr] 491 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: trait method `Scatter` should have a snake case name such as `scatter` [INFO] [stderr] --> src/math3d.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | fn Scatter(&self,r_in:&Ray,rec:&HitRecord,attenuation:&mut v3f,scattered:&mut Ray)->bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:522:26 [INFO] [stderr] | [INFO] [stderr] 522 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:523:29 [INFO] [stderr] | [INFO] [stderr] 523 | scattered.direction=dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:557:30 [INFO] [stderr] | [INFO] [stderr] 557 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:558:33 [INFO] [stderr] | [INFO] [stderr] 558 | scattered.direction=fuzz_reflected.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fuzz_reflected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: function `Reflect` should have a snake case name such as `reflect` [INFO] [stderr] --> src/math3d.rs:573:1 [INFO] [stderr] | [INFO] [stderr] 573 | / pub fn Reflect(v:&v3f,n:&v3f)->v3f{ [INFO] [stderr] 574 | | let dot=2.0*VecDot3D(v,n); [INFO] [stderr] 575 | | let t=VecMul3D(n,dot); [INFO] [stderr] 576 | | VecSub3D(v,&t) [INFO] [stderr] 577 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `Refract` should have a snake case name such as `refract` [INFO] [stderr] --> src/math3d.rs:579:1 [INFO] [stderr] | [INFO] [stderr] 579 | / pub fn Refract(v:&v3f,n:&v3f,ni_over_nt:f32,refracted:& mut v3f)-> bool{ [INFO] [stderr] 580 | | [INFO] [stderr] 581 | | let uv=VecNorm3D(v); [INFO] [stderr] 582 | | [INFO] [stderr] ... | [INFO] [stderr] 612 | | false [INFO] [stderr] 613 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `Schlick` should have a snake case name such as `schlick` [INFO] [stderr] --> src/math3d.rs:615:1 [INFO] [stderr] | [INFO] [stderr] 615 | / pub fn Schlick(cosine:f32,ref_idx:f32)->f32{ [INFO] [stderr] 616 | | let mut r0=(1.0-ref_idx)/(1.0+ref_idx); [INFO] [stderr] 617 | | r0=r0*r0; [INFO] [stderr] 618 | | return r0+ ( (1.0-r0)*( (1.0-cosine).powf(5.0) ) ); [INFO] [stderr] 619 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:684:34 [INFO] [stderr] | [INFO] [stderr] 684 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:685:37 [INFO] [stderr] | [INFO] [stderr] 685 | scattered.direction=reflected.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `reflected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:688:34 [INFO] [stderr] | [INFO] [stderr] 688 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:689:37 [INFO] [stderr] | [INFO] [stderr] 689 | scattered.direction=refracted.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `refracted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: function `CreateRandomScene` should have a snake case name such as `create_random_scene` [INFO] [stderr] --> src/main.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn CreateRandomScene(world:& mut math3d::World){ [INFO] [stderr] 11 | | let n=500; [INFO] [stderr] 12 | | [INFO] [stderr] 13 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `v3f` should have a camel case name such as `V3f` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | type v3f=math3d::Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `v3i` should have a camel case name such as `V3i` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=math3d::Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | writeln!(buffer,"P3"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | writeln!(buffer,"{} {}",nx,ny); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | writeln!(buffer,"255"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | writeln!(buffer,"{} {} {}",iclr.x,iclr.y,iclr.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/math3d.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let b:bool; [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `p` is never read [INFO] [stderr] --> src/math3d.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | let mut p=v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let n=500; [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `world` [INFO] [stderr] --> src/main.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn CreateRandomScene(world:& mut math3d::World){ [INFO] [stderr] | ^^^^^ help: consider using `_world` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lower_lef_corner` [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let lower_lef_corner:v3f=v3f{x:-2.0,y:-1.0,z:-1.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_lower_lef_corner` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `horizontal` [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let horizontal:v3f=v3f{x:4.0,y:0.0,z:0.0}; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_horizontal` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vertical` [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let vertical:v3f=v3f{x:0.0,y:2.0,z:0.0}; [INFO] [stderr] | ^^^^^^^^ help: consider using `_vertical` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let origin:v3f=v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v00` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let v00=math3d::VecSub3D(&look_from,&look_at); [INFO] [stderr] | ^^^ help: consider using `_v00` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `r1` is never read [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let mut r1:f32=0.0; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `r2` is never read [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | let mut r2:f32=0.0; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/main.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | for s in 0..ns{ [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `hit` [INFO] [stderr] --> src/math3d.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | let mut hit:bool=false; [INFO] [stderr] | ^^^ help: consider using `_hit` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r_in` [INFO] [stderr] --> src/math3d.rs:513:25 [INFO] [stderr] | [INFO] [stderr] 513 | fn Scatter(&self,r_in:&Ray,rec:&HitRecord,attenuation:&mut v3f,scattered:&mut Ray)->bool{ [INFO] [stderr] | ^^^^ help: consider using `_r_in` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `ni_over_nt` is never read [INFO] [stderr] --> src/math3d.rs:640:21 [INFO] [stderr] | [INFO] [stderr] 640 | let mut ni_over_nt:f32=0.0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cosine` is never read [INFO] [stderr] --> src/math3d.rs:647:21 [INFO] [stderr] | [INFO] [stderr] 647 | let mut cosine:f32=0.0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `reflect_prob` is never read [INFO] [stderr] --> src/math3d.rs:648:21 [INFO] [stderr] | [INFO] [stderr] 648 | let mut reflect_prob:f32=0.0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn GetColor(mut ray:Ray,world:& World,depth:i16)->v3f{ [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | let mut unit_direction=VecNorm3D(&ray.direction); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/math3d.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | let mut hit:bool=false; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `v3i` [INFO] [stderr] --> src/math3d.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `Refrect` [INFO] [stderr] --> src/math3d.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn Refrect(v:&v3f,n:&v3f)->v3f{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `HitSphere` [INFO] [stderr] --> src/math3d.rs:246:1 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn HitSphere(center:v3f,radius:f32,r:Ray)->f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CameraOld` [INFO] [stderr] --> src/math3d.rs:312:1 [INFO] [stderr] | [INFO] [stderr] 312 | pub struct CameraOld{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | pub fn new()->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `GetRay` [INFO] [stderr] --> src/math3d.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | pub fn GetRay(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `GetRayOld` [INFO] [stderr] --> src/math3d.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | pub fn GetRayOld(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:502:5 [INFO] [stderr] | [INFO] [stderr] 502 | pub fn new(a:v3f)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | pub fn new(a:v3f,f:f32)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math3d.rs:627:5 [INFO] [stderr] | [INFO] [stderr] 627 | pub fn new(ri:f32)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `v3i` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=math3d::Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Ray` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | type Ray=math3d::Ray; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `CameraOld` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | type CameraOld=math3d::CameraOld; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `HitRecord` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | type HitRecord=math3d::HitRecord; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `v3f` should have a camel case name such as `V3f` [INFO] [stderr] --> src/math3d.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | type v3f=Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `v3i` should have a camel case name such as `V3i` [INFO] [stderr] --> src/math3d.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `math3d::HitRecord` [INFO] [stderr] --> src/math3d.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new()->Self{ [INFO] [stderr] 30 | | HitRecord{ [INFO] [stderr] 31 | | t:0.0, [INFO] [stderr] 32 | | p:v3f{x:0.0,y:0.0,z:0.0}, [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for math3d::HitRecord { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait method `Hit` should have a snake case name such as `hit` [INFO] [stderr] --> src/math3d.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | fn Hit(&self,r:Ray,t_min:f32,t_max:f32,rec:& mut HitRecord)->bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: trait method `GetMaterial` should have a snake case name such as `get_material` [INFO] [stderr] --> src/math3d.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | fn GetMaterial(&self)->& Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/math3d.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | fn GetMaterial(&self)->& Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&Material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `math3d::Vec3D` [INFO] [stderr] --> src/math3d.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new()->Self{ [INFO] [stderr] 46 | | v3f{ [INFO] [stderr] 47 | | x:0.0, [INFO] [stderr] 48 | | y:0.0, [INFO] [stderr] 49 | | z:0.0 [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `Length` should have a snake case name such as `length` [INFO] [stderr] --> src/math3d.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn Length(&self)-> f32{ [INFO] [stderr] 54 | | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] 55 | | value.sqrt() [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `SquaredLength` should have a snake case name such as `squared_length` [INFO] [stderr] --> src/math3d.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn SquaredLength(&self)-> f32{ [INFO] [stderr] 59 | | let mut value:f32=self.x*self.x+self.y*self.y+self.z*self.z; [INFO] [stderr] 60 | | value [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `ToI32` should have a snake case name such as `to_i32` [INFO] [stderr] --> src/math3d.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn ToI32(&self)->Vec3D{ [INFO] [stderr] 64 | | Vec3D{x:self.x as i32,y:self.y as i32,z:self.z as i32} [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `math3d::Ray` [INFO] [stderr] --> src/math3d.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new()->Self{ [INFO] [stderr] 76 | | Ray{ [INFO] [stderr] 77 | | origin:v3f{x:0.0,y:0.0,z:0.0}, [INFO] [stderr] 78 | | direction:v3f{x:0.0,y:0.0,z:0.0}, [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | impl Default for math3d::Ray { [INFO] [stderr] 75 | fn default() -> Self { [INFO] [stderr] 76 | Self::new() [INFO] [stderr] 77 | } [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `PointAtParameter` should have a snake case name such as `point_at_parameter` [INFO] [stderr] --> src/math3d.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn PointAtParameter(&self,t:f32) -> v3f{ [INFO] [stderr] 83 | | let v=VecMul3D(&self.direction,t); [INFO] [stderr] 84 | | let r=VecAdd3D(&self.origin,&v); [INFO] [stderr] 85 | | r [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `VecDot3D` should have a snake case name such as `vec_dot3_d` [INFO] [stderr] --> src/math3d.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn VecDot3D(v1:&Vec3D,v2:&Vec3D)-> f32{ [INFO] [stderr] 91 | | (v1.x*v2.x+v1.y*v2.y+v1.z*v2.z) [INFO] [stderr] 92 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecCross3D` should have a snake case name such as `vec_cross3_d` [INFO] [stderr] --> src/math3d.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn VecCross3D(v1:&Vec3D,v2:&Vec3D)-> Vec3D{ [INFO] [stderr] 95 | | let x=v1.y*v2.z-v1.z*v2.y; [INFO] [stderr] 96 | | let y=-(v1.x*v2.z)-v1.z*v2.x; [INFO] [stderr] 97 | | let z=v1.x*v2.y-v1.y*v2.x; [INFO] [stderr] 98 | | [INFO] [stderr] 99 | | Vec3D{x:x,y:y,z:z} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecAdd3D` should have a snake case name such as `vec_add3_d` [INFO] [stderr] --> src/math3d.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn VecAdd3D(v1:&Vec3D,v2:&Vec3D)-> Vec3D{ [INFO] [stderr] 103 | | Vec3D{x:v1.x+v2.x,y:v1.y+v2.y,z:v1.z+v2.z} [INFO] [stderr] 104 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecSub3D` should have a snake case name such as `vec_sub3_d` [INFO] [stderr] --> src/math3d.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn VecSub3D(v1:&Vec3D,v2:&Vec3D)-> Vec3D{ [INFO] [stderr] 107 | | Vec3D{x:v1.x-v2.x,y:v1.y-v2.y,z:v1.z-v2.z} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecMul3D` should have a snake case name such as `vec_mul3_d` [INFO] [stderr] --> src/math3d.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn VecMul3D(v:&Vec3D,f:f32)->Vec3D{ [INFO] [stderr] 111 | | Vec3D{x:v.x*f,y:v.y*f,z:v.z*f} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecMulVec3D` should have a snake case name such as `vec_mul_vec3_d` [INFO] [stderr] --> src/math3d.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn VecMulVec3D(v1:&Vec3D,v2:&Vec3D)->Vec3D{ [INFO] [stderr] 115 | | Vec3D{x:v1.x*v2.x,y:v1.y*v2.y,z:v1.z*v2.z} [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecDiv3D` should have a snake case name such as `vec_div3_d` [INFO] [stderr] --> src/math3d.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / pub fn VecDiv3D(v:&v3f,f:f32)->v3f{ [INFO] [stderr] 119 | | [INFO] [stderr] 120 | | //this sucks I'll use an epsilon next time I promise [INFO] [stderr] 121 | | if f!=0.0 { [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `VecNorm3D` should have a snake case name such as `vec_norm3_d` [INFO] [stderr] --> src/math3d.rs:129:1 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn VecNorm3D(v:&v3f)->v3f{ [INFO] [stderr] 130 | | let length=v.Length(); [INFO] [stderr] 131 | | VecDiv3D(v,length) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `Refrect` should have a snake case name such as `refrect` [INFO] [stderr] --> src/math3d.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn Refrect(v:&v3f,n:&v3f)->v3f{ [INFO] [stderr] 135 | | let result=VecDot3D(&v,&n)*2.0; [INFO] [stderr] 136 | | let nn=VecMul3D(&n,result); [INFO] [stderr] 137 | | VecSub3D(&v,&nn) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `GetColor` should have a snake case name such as `get_color` [INFO] [stderr] --> src/math3d.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / pub fn GetColor(mut ray:Ray,world:& World,depth:i16)->v3f{ [INFO] [stderr] 191 | | [INFO] [stderr] 192 | | let b:bool; [INFO] [stderr] 193 | | [INFO] [stderr] ... | [INFO] [stderr] 243 | | [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `HitSphere` should have a snake case name such as `hit_sphere` [INFO] [stderr] --> src/math3d.rs:246:1 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn HitSphere(center:v3f,radius:f32,r:Ray)->f32 { [INFO] [stderr] 247 | | let oc=VecSub3D(&r.origin,¢er); [INFO] [stderr] 248 | | let a=VecDot3D(&r.direction,&r.direction); [INFO] [stderr] 249 | | let b=2.0*VecDot3D(&oc,&r.direction); [INFO] [stderr] ... | [INFO] [stderr] 258 | | [INFO] [stderr] 259 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `math3d::World` [INFO] [stderr] --> src/math3d.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / pub fn new()->Self { [INFO] [stderr] 268 | | World{ [INFO] [stderr] 269 | | objects:Vec::new(), [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 262 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `Hit` should have a snake case name such as `hit` [INFO] [stderr] --> src/math3d.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / fn Hit(&self,r:Ray,t_min:f32,t_max:f32,rec:& mut HitRecord)->bool{ [INFO] [stderr] 277 | | [INFO] [stderr] 278 | | let mut hit_anything:bool=false; [INFO] [stderr] 279 | | [INFO] [stderr] ... | [INFO] [stderr] 307 | | //return None; [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in &self.objects.enumerate()` or similar iterators [INFO] [stderr] --> src/math3d.rs:286:24 [INFO] [stderr] | [INFO] [stderr] 286 | for obj in &self.objects { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:293:31 [INFO] [stderr] | [INFO] [stderr] 293 | rec.p=temp_rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `temp_rec.p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:294:36 [INFO] [stderr] | [INFO] [stderr] 294 | rec.normal=temp_rec.normal.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `temp_rec.normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/math3d.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | / if hit_anything{ [INFO] [stderr] 302 | | return true [INFO] [stderr] 303 | | }else{ [INFO] [stderr] 304 | | return false; [INFO] [stderr] 305 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return hit_anything` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: method `GetRay` should have a snake case name such as `get_ray` [INFO] [stderr] --> src/math3d.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | / pub fn GetRay(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] 337 | | let mut v1=VecMul3D(&self.horizontal,u); [INFO] [stderr] 338 | | let v2=VecMul3D(&self.vertical,v); [INFO] [stderr] 339 | | [INFO] [stderr] ... | [INFO] [stderr] 348 | | r [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `RandomInUnitDisk` should have a snake case name such as `random_in_unit_disk` [INFO] [stderr] --> src/math3d.rs:354:1 [INFO] [stderr] | [INFO] [stderr] 354 | / pub fn RandomInUnitDisk()->v3f { [INFO] [stderr] 355 | | [INFO] [stderr] 356 | | let mut do_loop=true; [INFO] [stderr] 357 | | let mut p=v3f::new(); [INFO] [stderr] ... | [INFO] [stderr] 375 | | [INFO] [stderr] 376 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:407:40 [INFO] [stderr] | [INFO] [stderr] 407 | let mut lower_left_corner_=look_from.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `look_from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: method `GetRayOld` should have a snake case name such as `get_ray_old` [INFO] [stderr] --> src/math3d.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | / pub fn GetRayOld(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] 437 | | let mut v1=VecMul3D(&self.horizontal,u); [INFO] [stderr] 438 | | let v2=VecMul3D(&self.vertical,v); [INFO] [stderr] 439 | | [INFO] [stderr] ... | [INFO] [stderr] 448 | | r [INFO] [stderr] 449 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `GetRay` should have a snake case name such as `get_ray` [INFO] [stderr] --> src/math3d.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | / pub fn GetRay(&self,u:f32,v:f32)->Ray{ [INFO] [stderr] 452 | | [INFO] [stderr] 453 | | let rd_=RandomInUnitDisk(); [INFO] [stderr] 454 | | let rd=VecMul3D(&rd_,self.lens_radius); [INFO] [stderr] ... | [INFO] [stderr] 475 | | r [INFO] [stderr] 476 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function `RandomInUnitSphere` should have a snake case name such as `random_in_unit_sphere` [INFO] [stderr] --> src/math3d.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / pub fn RandomInUnitSphere()->v3f{ [INFO] [stderr] 481 | | let mut p=v3f{x:0.0,y:0.0,z:0.0}; [INFO] [stderr] 482 | | loop { [INFO] [stderr] 483 | | let r1=thread_rng().gen_range(0.0,1.0); [INFO] [stderr] ... | [INFO] [stderr] 490 | | p [INFO] [stderr] 491 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: trait method `Scatter` should have a snake case name such as `scatter` [INFO] [stderr] --> src/math3d.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | fn Scatter(&self,r_in:&Ray,rec:&HitRecord,attenuation:&mut v3f,scattered:&mut Ray)->bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:522:26 [INFO] [stderr] | [INFO] [stderr] 522 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:523:29 [INFO] [stderr] | [INFO] [stderr] 523 | scattered.direction=dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:557:30 [INFO] [stderr] | [INFO] [stderr] 557 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:558:33 [INFO] [stderr] | [INFO] [stderr] 558 | scattered.direction=fuzz_reflected.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `fuzz_reflected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: function `Reflect` should have a snake case name such as `reflect` [INFO] [stderr] --> src/math3d.rs:573:1 [INFO] [stderr] | [INFO] [stderr] 573 | / pub fn Reflect(v:&v3f,n:&v3f)->v3f{ [INFO] [stderr] 574 | | let dot=2.0*VecDot3D(v,n); [INFO] [stderr] 575 | | let t=VecMul3D(n,dot); [INFO] [stderr] 576 | | VecSub3D(v,&t) [INFO] [stderr] 577 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `Refract` should have a snake case name such as `refract` [INFO] [stderr] --> src/math3d.rs:579:1 [INFO] [stderr] | [INFO] [stderr] 579 | / pub fn Refract(v:&v3f,n:&v3f,ni_over_nt:f32,refracted:& mut v3f)-> bool{ [INFO] [stderr] 580 | | [INFO] [stderr] 581 | | let uv=VecNorm3D(v); [INFO] [stderr] 582 | | [INFO] [stderr] ... | [INFO] [stderr] 612 | | false [INFO] [stderr] 613 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `Schlick` should have a snake case name such as `schlick` [INFO] [stderr] --> src/math3d.rs:615:1 [INFO] [stderr] | [INFO] [stderr] 615 | / pub fn Schlick(cosine:f32,ref_idx:f32)->f32{ [INFO] [stderr] 616 | | let mut r0=(1.0-ref_idx)/(1.0+ref_idx); [INFO] [stderr] 617 | | r0=r0*r0; [INFO] [stderr] 618 | | return r0+ ( (1.0-r0)*( (1.0-cosine).powf(5.0) ) ); [INFO] [stderr] 619 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:684:34 [INFO] [stderr] | [INFO] [stderr] 684 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:685:37 [INFO] [stderr] | [INFO] [stderr] 685 | scattered.direction=reflected.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `reflected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:688:34 [INFO] [stderr] | [INFO] [stderr] 688 | scattered.origin=rec.p.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `rec.p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/math3d.rs:689:37 [INFO] [stderr] | [INFO] [stderr] 689 | scattered.direction=refracted.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `refracted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: function `CreateRandomScene` should have a snake case name such as `create_random_scene` [INFO] [stderr] --> src/main.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn CreateRandomScene(world:& mut math3d::World){ [INFO] [stderr] 11 | | let n=500; [INFO] [stderr] 12 | | [INFO] [stderr] 13 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `v3f` should have a camel case name such as `V3f` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | type v3f=math3d::Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `v3i` should have a camel case name such as `V3i` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | type v3i=math3d::Vec3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | writeln!(buffer,"P3"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | writeln!(buffer,"{} {}",nx,ny); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | writeln!(buffer,"255"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | writeln!(buffer,"{} {} {}",iclr.x,iclr.y,iclr.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "64962cfbaf8c8e8bd62c119c44bbaa3cf6237394c870ea940bf4f03408dc7d2a"` [INFO] running `"docker" "rm" "-f" "64962cfbaf8c8e8bd62c119c44bbaa3cf6237394c870ea940bf4f03408dc7d2a"` [INFO] [stdout] 64962cfbaf8c8e8bd62c119c44bbaa3cf6237394c870ea940bf4f03408dc7d2a