[INFO] updating cached repository pcleavelin/nes_emu_rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/pcleavelin/nes_emu_rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/pcleavelin/nes_emu_rust" "work/ex/clippy-test-run/sources/stable/gh/pcleavelin/nes_emu_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pcleavelin/nes_emu_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/pcleavelin/nes_emu_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pcleavelin/nes_emu_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pcleavelin/nes_emu_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2110e7046e6fb3c9c04ba5c50d211ec63da8f221
[INFO] sha for GitHub repo pcleavelin/nes_emu_rust: 2110e7046e6fb3c9c04ba5c50d211ec63da8f221
[INFO] validating manifest of pcleavelin/nes_emu_rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pcleavelin/nes_emu_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pcleavelin/nes_emu_rust
[INFO] finished frobbing pcleavelin/nes_emu_rust
[INFO] frobbed toml for pcleavelin/nes_emu_rust written to work/ex/clippy-test-run/sources/stable/gh/pcleavelin/nes_emu_rust/Cargo.toml
[INFO] started frobbing pcleavelin/nes_emu_rust
[INFO] finished frobbing pcleavelin/nes_emu_rust
[INFO] frobbed toml for pcleavelin/nes_emu_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pcleavelin/nes_emu_rust/Cargo.toml
[INFO] crate pcleavelin/nes_emu_rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pcleavelin/nes_emu_rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pcleavelin/nes_emu_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5e5be3ad2b7393e934e3b52665fb8f8ddacdff19277fc1ec247195a3bea56b60
[INFO] running `"docker" "start" "-a" "5e5be3ad2b7393e934e3b52665fb8f8ddacdff19277fc1ec247195a3bea56b60"`
[INFO] [stderr]    Compiling gcc v0.3.50
[INFO] [stderr]     Checking dylib v0.0.1
[INFO] [stderr]     Checking x11-dl v2.2.1
[INFO] [stderr]    Compiling minifb v0.9.1
[INFO] [stderr]     Checking nes_emu_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/nes/cart.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/nes/cart.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::opcode::Op::*`
[INFO] [stderr]  --> src/nes/cpu.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use super::opcode::Op::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/nes/cpu.rs:420:9
[INFO] [stderr]     |
[INFO] [stderr] 420 |         val
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/nes/cpu.rs:418:19
[INFO] [stderr]     |
[INFO] [stderr] 418 |         let val = interconnect.read_mem(0x100 + self.s as usize);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Key`, `Scale`, `WindowOptions`
[INFO] [stderr]  --> src/nes/ppu.rs:1:14
[INFO] [stderr]   |
[INFO] [stderr] 1 | use minifb::{WindowOptions, Window, Key, Scale};
[INFO] [stderr]   |              ^^^^^^^^^^^^^          ^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::interconnect::Interconnect`
[INFO] [stderr]  --> src/nes/ppu.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use super::interconnect::Interconnect;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/nes/ppu.rs:209:48
[INFO] [stderr]     |
[INFO] [stderr] 209 |                     self.vram[x + (y*WIDTH)] = 0xFF0000;
[INFO] [stderr]     |                                                ^^^^^^^^ help: consider: `0x00FF_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/nes/ppu.rs:212:48
[INFO] [stderr]     |
[INFO] [stderr] 212 |                     self.vram[x + (y*WIDTH)] = 0x00FF00;
[INFO] [stderr]     |                                                ^^^^^^^^ help: consider: `0x0000_FF00`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/nes/ppu.rs:215:48
[INFO] [stderr]     |
[INFO] [stderr] 215 |                     self.vram[x + (y*WIDTH)] = 0x0000FF;
[INFO] [stderr]     |                                                ^^^^^^^^ help: consider: `0x0000_00FF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nes/cart.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         return &self.data.as_slice()[addr..(addr+0x1000)];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.data.as_slice()[addr..(addr+0x1000)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Key`, `Scale`, `WindowOptions`
[INFO] [stderr]  --> src/nes/interconnect.rs:1:14
[INFO] [stderr]   |
[INFO] [stderr] 1 | use minifb::{WindowOptions, Window, Key, Scale};
[INFO] [stderr]   |              ^^^^^^^^^^^^^          ^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nes/interconnect.rs:122:17
[INFO] [stderr]     |
[INFO] [stderr] 122 |                 return 0;
[INFO] [stderr]     |                 ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:144:23
[INFO] [stderr]     |
[INFO] [stderr] 144 |         self.read_mem((addr + x))
[INFO] [stderr]     |                       ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/nes/interconnect.rs:144:23
[INFO] [stderr]     |
[INFO] [stderr] 144 |         self.read_mem((addr + x))
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:148:23
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.read_mem((addr + y))
[INFO] [stderr]     |                       ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/nes/interconnect.rs:148:23
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.read_mem((addr + y))
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:222:24
[INFO] [stderr]     |
[INFO] [stderr] 222 |         self.write_mem((addr + x), val);
[INFO] [stderr]     |                        ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:226:24
[INFO] [stderr]     |
[INFO] [stderr] 226 |         self.write_mem((addr + y), val);
[INFO] [stderr]     |                        ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::opcode::Op::*`
[INFO] [stderr]  --> src/nes/cpu.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | use super::opcode::Op::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/nes/cpu.rs:420:9
[INFO] [stderr]     |
[INFO] [stderr] 420 |         val
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/nes/cpu.rs:418:19
[INFO] [stderr]     |
[INFO] [stderr] 418 |         let val = interconnect.read_mem(0x100 + self.s as usize);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Key`, `Scale`, `WindowOptions`
[INFO] [stderr]  --> src/nes/ppu.rs:1:14
[INFO] [stderr]   |
[INFO] [stderr] 1 | use minifb::{WindowOptions, Window, Key, Scale};
[INFO] [stderr]   |              ^^^^^^^^^^^^^          ^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::interconnect::Interconnect`
[INFO] [stderr]  --> src/nes/ppu.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use super::interconnect::Interconnect;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/nes/ppu.rs:209:48
[INFO] [stderr]     |
[INFO] [stderr] 209 |                     self.vram[x + (y*WIDTH)] = 0xFF0000;
[INFO] [stderr]     |                                                ^^^^^^^^ help: consider: `0x00FF_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/nes/ppu.rs:212:48
[INFO] [stderr]     |
[INFO] [stderr] 212 |                     self.vram[x + (y*WIDTH)] = 0x00FF00;
[INFO] [stderr]     |                                                ^^^^^^^^ help: consider: `0x0000_FF00`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/nes/ppu.rs:215:48
[INFO] [stderr]     |
[INFO] [stderr] 215 |                     self.vram[x + (y*WIDTH)] = 0x0000FF;
[INFO] [stderr]     |                                                ^^^^^^^^ help: consider: `0x0000_00FF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nes/cart.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         return &self.data.as_slice()[addr..(addr+0x1000)];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.data.as_slice()[addr..(addr+0x1000)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Key`, `Scale`, `WindowOptions`
[INFO] [stderr]  --> src/nes/interconnect.rs:1:14
[INFO] [stderr]   |
[INFO] [stderr] 1 | use minifb::{WindowOptions, Window, Key, Scale};
[INFO] [stderr]   |              ^^^^^^^^^^^^^          ^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nes/interconnect.rs:122:17
[INFO] [stderr]     |
[INFO] [stderr] 122 |                 return 0;
[INFO] [stderr]     |                 ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:144:23
[INFO] [stderr]     |
[INFO] [stderr] 144 |         self.read_mem((addr + x))
[INFO] [stderr]     |                       ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/nes/interconnect.rs:144:23
[INFO] [stderr]     |
[INFO] [stderr] 144 |         self.read_mem((addr + x))
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:148:23
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.read_mem((addr + y))
[INFO] [stderr]     |                       ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/nes/interconnect.rs:148:23
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.read_mem((addr + y))
[INFO] [stderr]     |                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:222:24
[INFO] [stderr]     |
[INFO] [stderr] 222 |         self.write_mem((addr + x), val);
[INFO] [stderr]     |                        ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/nes/interconnect.rs:226:24
[INFO] [stderr]     |
[INFO] [stderr] 226 |         self.write_mem((addr + y), val);
[INFO] [stderr]     |                        ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable statement
[INFO] [stderr]   --> src/nes/mod.rs:75:17
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 self.cpu.offset_pc(1);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable statement
[INFO] [stderr]   --> src/nes/mod.rs:75:17
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 self.cpu.offset_pc(1);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:309:13
[INFO] [stderr]     |
[INFO] [stderr] 309 |         let mut val = lhs.wrapping_sub(rhs);
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:356:13
[INFO] [stderr]     |
[INFO] [stderr] 356 |         let mut val = lhs.wrapping_sub(rhs);
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:378:13
[INFO] [stderr]     |
[INFO] [stderr] 378 |         let mut val = lhs & rhs;
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:395:13
[INFO] [stderr]     |
[INFO] [stderr] 395 |         let mut val = lhs | rhs;
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:309:13
[INFO] [stderr]     |
[INFO] [stderr] 309 |         let mut val = lhs.wrapping_sub(rhs);
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:356:13
[INFO] [stderr]     |
[INFO] [stderr] 356 |         let mut val = lhs.wrapping_sub(rhs);
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:378:13
[INFO] [stderr]     |
[INFO] [stderr] 378 |         let mut val = lhs & rhs;
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/nes/cpu.rs:395:13
[INFO] [stderr]     |
[INFO] [stderr] 395 |         let mut val = lhs | rhs;
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let mut pt0 = self.cart.get_pattern_table(0);
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |         let mut pt1 = self.cart.get_pattern_table(1);
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let mut nt1 = &self.internal_ram[(1*0x400)..((1+1)*0x400)];
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let mut pt0 = self.cart.get_pattern_table(0);
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |         let mut pt1 = self.cart.get_pattern_table(1);
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/nes/interconnect.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let mut nt1 = &self.internal_ram[(1*0x400)..((1+1)*0x400)];
[INFO] [stderr]    |             ----^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `a`
[INFO] [stderr]    --> src/nes/cpu.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn a(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `x`
[INFO] [stderr]    --> src/nes/cpu.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |     pub fn x(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `y`
[INFO] [stderr]    --> src/nes/cpu.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 |     pub fn y(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `s`
[INFO] [stderr]    --> src/nes/cpu.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 |     pub fn s(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `p`
[INFO] [stderr]    --> src/nes/cpu.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 |     pub fn p(&self) -> CPUStatus {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `set_p`
[INFO] [stderr]    --> src/nes/cpu.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     pub fn set_p(&mut self, val: CPUStatus) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `offset_a`
[INFO] [stderr]    --> src/nes/cpu.rs:216:5
[INFO] [stderr]     |
[INFO] [stderr] 216 |     pub fn offset_a(&mut self, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add`
[INFO] [stderr]    --> src/nes/cpu.rs:308:5
[INFO] [stderr]     |
[INFO] [stderr] 308 |     fn add(&mut self, lhs: u8, rhs: u8) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `subtract_with_carry`
[INFO] [stderr]    --> src/nes/cpu.rs:330:5
[INFO] [stderr]     |
[INFO] [stderr] 330 |     pub fn subtract_with_carry(&mut self, lhs: u8, rhs: u8) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `addr`
[INFO] [stderr]   --> src/nes/ppu.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     addr: u8,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `oam_dma`
[INFO] [stderr]   --> src/nes/ppu.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     oam_dma: u8,
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `apu`
[INFO] [stderr]   --> src/nes/interconnect.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     apu: NESApu, //Can't wait for this (never done audio before)
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `io`
[INFO] [stderr]   --> src/nes/interconnect.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     io: NESIo,
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `ram`
[INFO] [stderr]   --> src/nes/interconnect.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn ram(&self) -> [u8;0x0800] {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_pattern_table`
[INFO] [stderr]   --> src/nes/interconnect.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn get_pattern_table(&mut self, num: usize) -> &[u8] {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_name_table`
[INFO] [stderr]   --> src/nes/interconnect.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pub fn get_name_table(&mut self, num: usize) -> &[u8] {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `read_zero_paged_indexed_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 |     pub fn read_zero_paged_indexed_y(&mut self, addr: usize, y: usize) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `read_indexed_indirect_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     pub fn read_indexed_indirect_y(&mut self, addr: usize, y: usize) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_zero_paged_indexed_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:217:5
[INFO] [stderr]     |
[INFO] [stderr] 217 |     pub fn write_zero_paged_indexed_y(&mut self, addr: usize, y: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_absolute_indexed_x`
[INFO] [stderr]    --> src/nes/interconnect.rs:221:5
[INFO] [stderr]     |
[INFO] [stderr] 221 |     pub fn write_absolute_indexed_x(&mut self, addr: usize, x: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_absolute_indexed_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:225:5
[INFO] [stderr]     |
[INFO] [stderr] 225 |     pub fn write_absolute_indexed_y(&mut self, addr: usize, y: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_indexed_indirect_x`
[INFO] [stderr]    --> src/nes/interconnect.rs:229:5
[INFO] [stderr]     |
[INFO] [stderr] 229 |     pub fn write_indexed_indirect_x(&mut self, addr: usize, x: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `soft_restart`
[INFO] [stderr]   --> src/nes/mod.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn soft_restart(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/nes/cpu.rs:79:18
[INFO] [stderr]    |
[INFO] [stderr] 79 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:274:26
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let mut result = (lhs as u16) + (rhs as u16);
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `u16::from(lhs)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:274:41
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let mut result = (lhs as u16) + (rhs as u16);
[INFO] [stderr]     |                                         ^^^^^^^^^^^^ help: try: `u16::from(rhs)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/nes/cpu.rs:277:13
[INFO] [stderr]     |
[INFO] [stderr] 277 |             result = result + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:431:23
[INFO] [stderr]     |
[INFO] [stderr] 431 |         let addr_lo = interconnect.read_absolute(0xFFFC) as u16;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFC))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:432:23
[INFO] [stderr]     |
[INFO] [stderr] 432 |         let addr_hi = interconnect.read_absolute(0xFFFD) as u16;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFD))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:440:18
[INFO] [stderr]     |
[INFO] [stderr] 440 |         let op = interconnect.read_mem(self.pc as usize) as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_mem(self.pc as usize))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:441:20
[INFO] [stderr]     |
[INFO] [stderr] 441 |         let imm1 = (interconnect.read_mem((self.pc.wrapping_add(1)) as usize) as u32) << 8;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_mem((self.pc.wrapping_add(1)) as usize))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:442:20
[INFO] [stderr]     |
[INFO] [stderr] 442 |         let imm2 = (interconnect.read_mem((self.pc.wrapping_add(2)) as usize) as u32) << 16;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_mem((self.pc.wrapping_add(2)) as usize))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:450:28
[INFO] [stderr]     |
[INFO] [stderr] 450 |         match Op::from_i32(opcode.op() as i32) {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(opcode.op())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `a`
[INFO] [stderr]    --> src/nes/cpu.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn a(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `x`
[INFO] [stderr]    --> src/nes/cpu.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |     pub fn x(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `y`
[INFO] [stderr]    --> src/nes/cpu.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 |     pub fn y(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `s`
[INFO] [stderr]    --> src/nes/cpu.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 |     pub fn s(&self) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `p`
[INFO] [stderr]    --> src/nes/cpu.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 |     pub fn p(&self) -> CPUStatus {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `set_p`
[INFO] [stderr]    --> src/nes/cpu.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     pub fn set_p(&mut self, val: CPUStatus) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `offset_a`
[INFO] [stderr]    --> src/nes/cpu.rs:216:5
[INFO] [stderr]     |
[INFO] [stderr] 216 |     pub fn offset_a(&mut self, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add`
[INFO] [stderr]    --> src/nes/cpu.rs:308:5
[INFO] [stderr]     |
[INFO] [stderr] 308 |     fn add(&mut self, lhs: u8, rhs: u8) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `subtract_with_carry`
[INFO] [stderr]    --> src/nes/cpu.rs:330:5
[INFO] [stderr]     |
[INFO] [stderr] 330 |     pub fn subtract_with_carry(&mut self, lhs: u8, rhs: u8) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `addr`
[INFO] [stderr]   --> src/nes/ppu.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     addr: u8,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `oam_dma`
[INFO] [stderr]   --> src/nes/ppu.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     oam_dma: u8,
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `apu`
[INFO] [stderr]   --> src/nes/interconnect.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     apu: NESApu, //Can't wait for this (never done audio before)
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `io`
[INFO] [stderr]   --> src/nes/interconnect.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     io: NESIo,
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `ram`
[INFO] [stderr]   --> src/nes/interconnect.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn ram(&self) -> [u8;0x0800] {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_pattern_table`
[INFO] [stderr]   --> src/nes/interconnect.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn get_pattern_table(&mut self, num: usize) -> &[u8] {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_name_table`
[INFO] [stderr]   --> src/nes/interconnect.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pub fn get_name_table(&mut self, num: usize) -> &[u8] {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `read_zero_paged_indexed_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 |     pub fn read_zero_paged_indexed_y(&mut self, addr: usize, y: usize) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `read_indexed_indirect_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     pub fn read_indexed_indirect_y(&mut self, addr: usize, y: usize) -> u8 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_zero_paged_indexed_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:217:5
[INFO] [stderr]     |
[INFO] [stderr] 217 |     pub fn write_zero_paged_indexed_y(&mut self, addr: usize, y: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_absolute_indexed_x`
[INFO] [stderr]    --> src/nes/interconnect.rs:221:5
[INFO] [stderr]     |
[INFO] [stderr] 221 |     pub fn write_absolute_indexed_x(&mut self, addr: usize, x: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_absolute_indexed_y`
[INFO] [stderr]    --> src/nes/interconnect.rs:225:5
[INFO] [stderr]     |
[INFO] [stderr] 225 |     pub fn write_absolute_indexed_y(&mut self, addr: usize, y: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `write_indexed_indirect_x`
[INFO] [stderr]    --> src/nes/interconnect.rs:229:5
[INFO] [stderr]     |
[INFO] [stderr] 229 |     pub fn write_indexed_indirect_x(&mut self, addr: usize, x: usize, val: u8) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `soft_restart`
[INFO] [stderr]   --> src/nes/mod.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn soft_restart(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:465:39
[INFO] [stderr]     |
[INFO] [stderr] 465 |                         let addr_lo = interconnect.read_absolute(0xFFFE) as u16;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFE))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:466:39
[INFO] [stderr]     |
[INFO] [stderr] 466 |                         let addr_hi = interconnect.read_absolute(0xFFFF) as u16;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFF))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/nes/cpu.rs:473:25
[INFO] [stderr]     |
[INFO] [stderr] 473 |                         val = self.a | val;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= self.a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/nes/cpu.rs:501:28
[INFO] [stderr]     |
[INFO] [stderr] 501 |                         if self.p.negative == false {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.p.negative`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:576:34
[INFO] [stderr]     |
[INFO] [stderr] 576 |                         let hi = self.pop_stack(interconnect) as u16;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_stack(interconnect))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:577:34
[INFO] [stderr]     |
[INFO] [stderr] 577 |                         let lo = self.pop_stack(interconnect) as u16;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_stack(interconnect))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/nes/cpu.rs:79:18
[INFO] [stderr]    |
[INFO] [stderr] 79 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/nes/cpu.rs:717:28
[INFO] [stderr]     |
[INFO] [stderr] 717 |                         if self.p.carry == true {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.p.carry`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/nes/cpu.rs:804:28
[INFO] [stderr]     |
[INFO] [stderr] 804 |                         if self.p.zero == false {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.p.zero`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/nes/cpu.rs:844:28
[INFO] [stderr]     |
[INFO] [stderr] 844 |                         if self.p.zero == true {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.p.zero`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:274:26
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let mut result = (lhs as u16) + (rhs as u16);
[INFO] [stderr]     |                          ^^^^^^^^^^^^ help: try: `u16::from(lhs)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:274:41
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let mut result = (lhs as u16) + (rhs as u16);
[INFO] [stderr]     |                                         ^^^^^^^^^^^^ help: try: `u16::from(rhs)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/nes/cpu.rs:277:13
[INFO] [stderr]     |
[INFO] [stderr] 277 |             result = result + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:431:23
[INFO] [stderr]     |
[INFO] [stderr] 431 |         let addr_lo = interconnect.read_absolute(0xFFFC) as u16;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFC))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:432:23
[INFO] [stderr]     |
[INFO] [stderr] 432 |         let addr_hi = interconnect.read_absolute(0xFFFD) as u16;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFD))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros`
[INFO] [stderr]    --> src/nes/ppu.rs:189:29
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 let nt = if self.ctrl&0x3 == 0 || self.ctrl&0x3 == 1 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^ help: try: `self.ctrl.trailing_zeros() >= 2`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::verbose_bit_mask)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:440:18
[INFO] [stderr]     |
[INFO] [stderr] 440 |         let op = interconnect.read_mem(self.pc as usize) as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_mem(self.pc as usize))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:441:20
[INFO] [stderr]     |
[INFO] [stderr] 441 |         let imm1 = (interconnect.read_mem((self.pc.wrapping_add(1)) as usize) as u32) << 8;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_mem((self.pc.wrapping_add(1)) as usize))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:442:20
[INFO] [stderr]     |
[INFO] [stderr] 442 |         let imm2 = (interconnect.read_mem((self.pc.wrapping_add(2)) as usize) as u32) << 16;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(interconnect.read_mem((self.pc.wrapping_add(2)) as usize))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:450:28
[INFO] [stderr]     |
[INFO] [stderr] 450 |         match Op::from_i32(opcode.op() as i32) {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(opcode.op())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:465:39
[INFO] [stderr]     |
[INFO] [stderr] 465 |                         let addr_lo = interconnect.read_absolute(0xFFFE) as u16;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFE))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:466:39
[INFO] [stderr]     |
[INFO] [stderr] 466 |                         let addr_hi = interconnect.read_absolute(0xFFFF) as u16;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(interconnect.read_absolute(0xFFFF))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/nes/cpu.rs:473:25
[INFO] [stderr]     |
[INFO] [stderr] 473 |                         val = self.a | val;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= self.a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/nes/cpu.rs:501:28
[INFO] [stderr]     |
[INFO] [stderr] 501 |                         if self.p.negative == false {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.p.negative`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:576:34
[INFO] [stderr]     |
[INFO] [stderr] 576 |                         let hi = self.pop_stack(interconnect) as u16;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_stack(interconnect))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/nes/cpu.rs:577:34
[INFO] [stderr]     |
[INFO] [stderr] 577 |                         let lo = self.pop_stack(interconnect) as u16;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_stack(interconnect))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/nes/cpu.rs:717:28
[INFO] [stderr]     |
[INFO] [stderr] 717 |                         if self.p.carry == true {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.p.carry`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/cart.rs:70:53
[INFO] [stderr]    |
[INFO] [stderr] 70 |         println!("Size of PRG ROM * 16KB: 0x{:0X}", self.data[4] as u16);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/cart.rs:71:53
[INFO] [stderr]    |
[INFO] [stderr] 71 |         println!("Size of CHR ROM * 8KB:  0x{:0X}", self.data[5] as u16);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/nes/cpu.rs:804:28
[INFO] [stderr]     |
[INFO] [stderr] 804 |                         if self.p.zero == false {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.p.zero`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/nes/cpu.rs:844:28
[INFO] [stderr]     |
[INFO] [stderr] 844 |                         if self.p.zero == true {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.p.zero`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome
[INFO] [stderr]   --> src/nes/interconnect.rs:74:42
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |                                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::erasing_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x400`
[INFO] [stderr]   --> src/nes/interconnect.rs:74:53
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/nes/interconnect.rs:74:54
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |                                                      ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x400`
[INFO] [stderr]   --> src/nes/interconnect.rs:75:42
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let mut nt1 = &self.internal_ram[(1*0x400)..((1+1)*0x400)];
[INFO] [stderr]    |                                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros`
[INFO] [stderr]    --> src/nes/ppu.rs:189:29
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 let nt = if self.ctrl&0x3 == 0 || self.ctrl&0x3 == 1 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^ help: try: `self.ctrl.trailing_zeros() >= 2`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::verbose_bit_mask)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/cart.rs:70:53
[INFO] [stderr]    |
[INFO] [stderr] 70 |         println!("Size of PRG ROM * 16KB: 0x{:0X}", self.data[4] as u16);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/cart.rs:71:53
[INFO] [stderr]    |
[INFO] [stderr] 71 |         println!("Size of CHR ROM * 8KB:  0x{:0X}", self.data[5] as u16);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome
[INFO] [stderr]   --> src/nes/interconnect.rs:74:42
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |                                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::erasing_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x400`
[INFO] [stderr]   --> src/nes/interconnect.rs:74:53
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/nes/interconnect.rs:74:54
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let mut nt0 = &self.internal_ram[(0*0x400)..((0+1)*0x400)];
[INFO] [stderr]    |                                                      ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x400`
[INFO] [stderr]   --> src/nes/interconnect.rs:75:42
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let mut nt1 = &self.internal_ram[(1*0x400)..((1+1)*0x400)];
[INFO] [stderr]    |                                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:162:15
[INFO] [stderr]     |
[INFO] [stderr] 162 |     pub fn op(&self) -> u8 {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:166:17
[INFO] [stderr]     |
[INFO] [stderr] 166 |     pub fn imm1(&self) -> u8 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:170:17
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn imm2(&self) -> u8 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:174:21
[INFO] [stderr]     |
[INFO] [stderr] 174 |     pub fn abs_addr(&self) -> usize {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/nes/integer_casting.rs:9:14
[INFO] [stderr]   |
[INFO] [stderr] 9 |             !(inverse as u16) + 1
[INFO] [stderr]   |              ^^^^^^^^^^^^^^^^ help: try: `u16::from(inverse)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/integer_casting.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             (*self) as u16
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: try: `u16::from((*self))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/mod.rs:67:23
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let addr_lo = self.interconnect.read_absolute(0xFFFE) as u16;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.interconnect.read_absolute(0xFFFE))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/mod.rs:68:23
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let addr_hi = self.interconnect.read_absolute(0xFFFF) as u16;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.interconnect.read_absolute(0xFFFF))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((addr_hi << 8) | addr_lo)`
[INFO] [stderr]   --> src/nes/mod.rs:70:25
[INFO] [stderr]    |
[INFO] [stderr] 70 |         self.cpu.set_pc(((addr_hi << 8) | addr_lo)-0);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/nes/mod.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if self.cpu.do_instruction(&mut self.interconnect) == false {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.cpu.do_instruction(&mut self.interconnect)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:162:15
[INFO] [stderr]     |
[INFO] [stderr] 162 |     pub fn op(&self) -> u8 {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `nes_emu_rust`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:166:17
[INFO] [stderr]     |
[INFO] [stderr] 166 |     pub fn imm1(&self) -> u8 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:170:17
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn imm2(&self) -> u8 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/nes/opcode.rs:174:21
[INFO] [stderr]     |
[INFO] [stderr] 174 |     pub fn abs_addr(&self) -> usize {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/nes/integer_casting.rs:9:14
[INFO] [stderr]   |
[INFO] [stderr] 9 |             !(inverse as u16) + 1
[INFO] [stderr]   |              ^^^^^^^^^^^^^^^^ help: try: `u16::from(inverse)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/integer_casting.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             (*self) as u16
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: try: `u16::from((*self))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/mod.rs:67:23
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let addr_lo = self.interconnect.read_absolute(0xFFFE) as u16;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.interconnect.read_absolute(0xFFFE))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/nes/mod.rs:68:23
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let addr_hi = self.interconnect.read_absolute(0xFFFF) as u16;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.interconnect.read_absolute(0xFFFF))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((addr_hi << 8) | addr_lo)`
[INFO] [stderr]   --> src/nes/mod.rs:70:25
[INFO] [stderr]    |
[INFO] [stderr] 70 |         self.cpu.set_pc(((addr_hi << 8) | addr_lo)-0);
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/nes/mod.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if self.cpu.do_instruction(&mut self.interconnect) == false {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.cpu.do_instruction(&mut self.interconnect)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `nes_emu_rust`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "5e5be3ad2b7393e934e3b52665fb8f8ddacdff19277fc1ec247195a3bea56b60"`
[INFO] running `"docker" "rm" "-f" "5e5be3ad2b7393e934e3b52665fb8f8ddacdff19277fc1ec247195a3bea56b60"`
[INFO] [stdout] 5e5be3ad2b7393e934e3b52665fb8f8ddacdff19277fc1ec247195a3bea56b60