[INFO] updating cached repository pbzweihander/web-tictactoe-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pbzweihander/web-tictactoe-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pbzweihander/web-tictactoe-rs" "work/ex/clippy-test-run/sources/stable/gh/pbzweihander/web-tictactoe-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pbzweihander/web-tictactoe-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pbzweihander/web-tictactoe-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/web-tictactoe-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/web-tictactoe-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8553e9c83a5633afecfab49c12bc3c00d93c2b61 [INFO] sha for GitHub repo pbzweihander/web-tictactoe-rs: 8553e9c83a5633afecfab49c12bc3c00d93c2b61 [INFO] validating manifest of pbzweihander/web-tictactoe-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pbzweihander/web-tictactoe-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pbzweihander/web-tictactoe-rs [INFO] finished frobbing pbzweihander/web-tictactoe-rs [INFO] frobbed toml for pbzweihander/web-tictactoe-rs written to work/ex/clippy-test-run/sources/stable/gh/pbzweihander/web-tictactoe-rs/Cargo.toml [INFO] started frobbing pbzweihander/web-tictactoe-rs [INFO] finished frobbing pbzweihander/web-tictactoe-rs [INFO] frobbed toml for pbzweihander/web-tictactoe-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/web-tictactoe-rs/Cargo.toml [INFO] crate pbzweihander/web-tictactoe-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pbzweihander/web-tictactoe-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pbzweihander/web-tictactoe-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87feeb01a5312b4c7c8bf8a73ba08a1470b081fb5c400bb4f06f9dfa8e401087 [INFO] running `"docker" "start" "-a" "87feeb01a5312b4c7c8bf8a73ba08a1470b081fb5c400bb4f06f9dfa8e401087"` [INFO] [stderr] Compiling stdweb-internal-runtime v0.1.2 [INFO] [stderr] Compiling base-x v0.2.3 [INFO] [stderr] Checking discard v1.0.4 [INFO] [stderr] Compiling ryu v0.2.6 [INFO] [stderr] Compiling stdweb-internal-macros v0.2.2 [INFO] [stderr] Compiling stdweb v0.4.10 [INFO] [stderr] Compiling syn v0.15.14 [INFO] [stderr] Compiling serde_json v1.0.32 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling synstructure v0.10.0 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Compiling stdweb-derive v0.5.1 [INFO] [stderr] Checking yew v0.4.0 [INFO] [stderr] Checking web-tictactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | for line in lines.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | format!("Go to game start") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Go to game start".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | current.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:280:33 [INFO] [stderr] | [INFO] [stderr] 280 | onclick=|i| GameMsg::OnSquareClick(i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `GameMsg::OnSquareClick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `web-tictactoe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | for line in lines.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | format!("Go to game start") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Go to game start".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | current.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:280:33 [INFO] [stderr] | [INFO] [stderr] 280 | onclick=|i| GameMsg::OnSquareClick(i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `GameMsg::OnSquareClick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `web-tictactoe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "87feeb01a5312b4c7c8bf8a73ba08a1470b081fb5c400bb4f06f9dfa8e401087"` [INFO] running `"docker" "rm" "-f" "87feeb01a5312b4c7c8bf8a73ba08a1470b081fb5c400bb4f06f9dfa8e401087"` [INFO] [stdout] 87feeb01a5312b4c7c8bf8a73ba08a1470b081fb5c400bb4f06f9dfa8e401087