[INFO] updating cached repository pbhandari/teapot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pbhandari/teapot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pbhandari/teapot" "work/ex/clippy-test-run/sources/stable/gh/pbhandari/teapot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pbhandari/teapot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pbhandari/teapot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbhandari/teapot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbhandari/teapot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8baad85866d08a74b1fc69fcbcbc708af94f7956 [INFO] sha for GitHub repo pbhandari/teapot: 8baad85866d08a74b1fc69fcbcbc708af94f7956 [INFO] validating manifest of pbhandari/teapot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pbhandari/teapot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pbhandari/teapot [INFO] finished frobbing pbhandari/teapot [INFO] frobbed toml for pbhandari/teapot written to work/ex/clippy-test-run/sources/stable/gh/pbhandari/teapot/Cargo.toml [INFO] started frobbing pbhandari/teapot [INFO] finished frobbing pbhandari/teapot [INFO] frobbed toml for pbhandari/teapot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbhandari/teapot/Cargo.toml [INFO] crate pbhandari/teapot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pbhandari/teapot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pbhandari/teapot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bff1ffa1c1639e696d11e20362ea22d6425767bee3b0b4ead1709fa117b7882 [INFO] running `"docker" "start" "-a" "5bff1ffa1c1639e696d11e20362ea22d6425767bee3b0b4ead1709fa117b7882"` [INFO] [stderr] Checking teapot v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Shutdown` [INFO] [stderr] --> src/server.rs:1:44 [INFO] [stderr] | [INFO] [stderr] 1 | use std::net::{TcpListener, ToSocketAddrs, Shutdown}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `headers` [INFO] [stderr] --> src/connection.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | fn write_headers(&mut self, status: u32, headers: HashMap) { [INFO] [stderr] | ^^^^^^^ help: consider using `_headers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_name` [INFO] [stderr] --> src/connection.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | fn write_file(&mut self, file_name : String) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_file_name` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `rtype` [INFO] [stderr] --> src/request.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rtype : RequestType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/request.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | version : HttpVersion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/connection.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const CR : u8 = '\r' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/connection.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const LF : u8 = '\n' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/connection.rs:76:55 [INFO] [stderr] | [INFO] [stderr] 76 | let pair : Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/connection.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / self.stream.shutdown(Shutdown::Both) [INFO] [stderr] 92 | | .ok().expect("Failed to close stream"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | let mut token = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/server.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(mut stream) => { Connection::new(&mut stream).handle(); } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/server.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | drop(&self.listener) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &std::net::TcpListener [INFO] [stderr] --> src/server.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | drop(&self.listener) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `teapot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `Shutdown` [INFO] [stderr] --> src/server.rs:1:44 [INFO] [stderr] | [INFO] [stderr] 1 | use std::net::{TcpListener, ToSocketAddrs, Shutdown}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `headers` [INFO] [stderr] --> src/connection.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | fn write_headers(&mut self, status: u32, headers: HashMap) { [INFO] [stderr] | ^^^^^^^ help: consider using `_headers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_name` [INFO] [stderr] --> src/connection.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | fn write_file(&mut self, file_name : String) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_file_name` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `rtype` [INFO] [stderr] --> src/request.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | rtype : RequestType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/request.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | version : HttpVersion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/connection.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const CR : u8 = '\r' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/connection.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const LF : u8 = '\n' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/connection.rs:76:55 [INFO] [stderr] | [INFO] [stderr] 76 | let pair : Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/connection.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / self.stream.shutdown(Shutdown::Both) [INFO] [stderr] 92 | | .ok().expect("Failed to close stream"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | let mut token = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/server.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(mut stream) => { Connection::new(&mut stream).handle(); } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/server.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | drop(&self.listener) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &std::net::TcpListener [INFO] [stderr] --> src/server.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | drop(&self.listener) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `teapot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5bff1ffa1c1639e696d11e20362ea22d6425767bee3b0b4ead1709fa117b7882"` [INFO] running `"docker" "rm" "-f" "5bff1ffa1c1639e696d11e20362ea22d6425767bee3b0b4ead1709fa117b7882"` [INFO] [stdout] 5bff1ffa1c1639e696d11e20362ea22d6425767bee3b0b4ead1709fa117b7882