[INFO] updating cached repository paulsevere/server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paulsevere/server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paulsevere/server" "work/ex/clippy-test-run/sources/stable/gh/paulsevere/server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paulsevere/server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paulsevere/server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulsevere/server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulsevere/server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99a2823bde0e258e7b2342bad94976eb7747016b [INFO] sha for GitHub repo paulsevere/server: 99a2823bde0e258e7b2342bad94976eb7747016b [INFO] validating manifest of paulsevere/server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paulsevere/server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paulsevere/server [INFO] finished frobbing paulsevere/server [INFO] frobbed toml for paulsevere/server written to work/ex/clippy-test-run/sources/stable/gh/paulsevere/server/Cargo.toml [INFO] started frobbing paulsevere/server [INFO] finished frobbing paulsevere/server [INFO] frobbed toml for paulsevere/server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulsevere/server/Cargo.toml [INFO] crate paulsevere/server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paulsevere/server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paulsevere/server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59ebcaf56be9a2c75b2b47908f10e0cce828ad8361dd6483f82f580c05d01597 [INFO] running `"docker" "start" "-a" "59ebcaf56be9a2c75b2b47908f10e0cce828ad8361dd6483f82f580c05d01597"` [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking mio v0.6.7 [INFO] [stderr] Checking server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | use mio::tcp::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return String::from(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(message)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | use mio::tcp::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return String::from(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(message)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/main.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | let (mut socket, addr) = server.accept().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `writeResult` should have a snake case name such as `write_result` [INFO] [stderr] --> src/main.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | let writeResult = socket.write(httpResponse().as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | / match writeResult { [INFO] [stderr] 36 | | Ok(_) => { [INFO] [stderr] 37 | | println!("Shutting down"); [INFO] [stderr] 38 | | [INFO] [stderr] ... | [INFO] [stderr] 42 | | Err(_) => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Ok(_) = writeResult { [INFO] [stderr] 36 | println!("Shutting down"); [INFO] [stderr] 37 | [INFO] [stderr] 38 | socket.shutdown(Both); [INFO] [stderr] 39 | [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | socket.shutdown(Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: function `httpResponse` should have a snake case name such as `http_response` [INFO] [stderr] --> src/main.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn httpResponse() -> String { [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | let message = format!(r#"HTTP-Version = HTTP/2.0 [INFO] [stderr] 58 | | Content-Type: text/html [INFO] [stderr] ... | [INFO] [stderr] 63 | | return String::from(message); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | return String::from(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/main.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | let (mut socket, addr) = server.accept().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `writeResult` should have a snake case name such as `write_result` [INFO] [stderr] --> src/main.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | let writeResult = socket.write(httpResponse().as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | / match writeResult { [INFO] [stderr] 36 | | Ok(_) => { [INFO] [stderr] 37 | | println!("Shutting down"); [INFO] [stderr] 38 | | [INFO] [stderr] ... | [INFO] [stderr] 42 | | Err(_) => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Ok(_) = writeResult { [INFO] [stderr] 36 | println!("Shutting down"); [INFO] [stderr] 37 | [INFO] [stderr] 38 | socket.shutdown(Both); [INFO] [stderr] 39 | [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | socket.shutdown(Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: function `httpResponse` should have a snake case name such as `http_response` [INFO] [stderr] --> src/main.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn httpResponse() -> String { [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | let message = format!(r#"HTTP-Version = HTTP/2.0 [INFO] [stderr] 58 | | Content-Type: text/html [INFO] [stderr] ... | [INFO] [stderr] 63 | | return String::from(message); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | return String::from(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.71s [INFO] running `"docker" "inspect" "59ebcaf56be9a2c75b2b47908f10e0cce828ad8361dd6483f82f580c05d01597"` [INFO] running `"docker" "rm" "-f" "59ebcaf56be9a2c75b2b47908f10e0cce828ad8361dd6483f82f580c05d01597"` [INFO] [stdout] 59ebcaf56be9a2c75b2b47908f10e0cce828ad8361dd6483f82f580c05d01597