[INFO] updating cached repository paulghill/pmg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paulghill/pmg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paulghill/pmg" "work/ex/clippy-test-run/sources/stable/gh/paulghill/pmg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paulghill/pmg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paulghill/pmg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulghill/pmg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulghill/pmg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 23e6a838b53dafbee8836a68c357170f307855dd [INFO] sha for GitHub repo paulghill/pmg: 23e6a838b53dafbee8836a68c357170f307855dd [INFO] validating manifest of paulghill/pmg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paulghill/pmg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paulghill/pmg [INFO] finished frobbing paulghill/pmg [INFO] frobbed toml for paulghill/pmg written to work/ex/clippy-test-run/sources/stable/gh/paulghill/pmg/Cargo.toml [INFO] started frobbing paulghill/pmg [INFO] finished frobbing paulghill/pmg [INFO] frobbed toml for paulghill/pmg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulghill/pmg/Cargo.toml [INFO] crate paulghill/pmg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paulghill/pmg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paulghill/pmg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98e86c2b9f4649f0ce281a10367142a0bb256636c26d5516f156c077e4da2247 [INFO] running `"docker" "start" "-a" "98e86c2b9f4649f0ce281a10367142a0bb256636c26d5516f156c077e4da2247"` [INFO] [stderr] Checking pmg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | output [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:201:22 [INFO] [stderr] | [INFO] [stderr] 201 | let output = if is_gnu { [INFO] [stderr] | ______________________^ [INFO] [stderr] 202 | | ArgumentCheck { [INFO] [stderr] 203 | | is_used: true, [INFO] [stderr] 204 | | parse_index: gnu_index, [INFO] [stderr] ... | [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | output [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | let output = if self.accepted_values.contains(&args[parse_result.parse_index].value) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 262 | | let return_index = self.accepted_values.iter() [INFO] [stderr] 263 | | .position(|value| value == &args[parse_result.parse_index].value).unwrap(); [INFO] [stderr] 264 | | &self.return_values[return_index] [INFO] [stderr] ... | [INFO] [stderr] 278 | | &self.default_value [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/main.rs:478:24 [INFO] [stderr] | [INFO] [stderr] 478 | if args.len() >= i + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 478 | if args.len() > i { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | output [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:201:22 [INFO] [stderr] | [INFO] [stderr] 201 | let output = if is_gnu { [INFO] [stderr] | ______________________^ [INFO] [stderr] 202 | | ArgumentCheck { [INFO] [stderr] 203 | | is_used: true, [INFO] [stderr] 204 | | parse_index: gnu_index, [INFO] [stderr] ... | [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | output [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | let output = if self.accepted_values.contains(&args[parse_result.parse_index].value) { [INFO] [stderr] | ______________________^ [INFO] [stderr] 262 | | let return_index = self.accepted_values.iter() [INFO] [stderr] 263 | | .position(|value| value == &args[parse_result.parse_index].value).unwrap(); [INFO] [stderr] 264 | | &self.return_values[return_index] [INFO] [stderr] ... | [INFO] [stderr] 278 | | &self.default_value [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/main.rs:478:24 [INFO] [stderr] | [INFO] [stderr] 478 | if args.len() >= i + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 478 | if args.len() > i { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | &self.print_octets(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.print_octets();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | &self.print_octets(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.print_octets();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | fn check_args(&self, args: &Vec) -> ArgumentCheck { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParsedArgument]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `args` [INFO] [stderr] --> src/main.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | for i in 0..args.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 186 | for (i, ) in args.iter().enumerate(){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:255:38 [INFO] [stderr] | [INFO] [stderr] 255 | fn get_return_value(&self, args: &Vec) -> &T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParsedArgument]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:464:47 [INFO] [stderr] | [INFO] [stderr] 464 | } else if current_arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:480:66 [INFO] [stderr] | [INFO] [stderr] 480 | let arg_value = if !next_arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | &self.print_octets(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.print_octets();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | &self.print_octets(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.print_octets();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | fn check_args(&self, args: &Vec) -> ArgumentCheck { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParsedArgument]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `args` [INFO] [stderr] --> src/main.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | for i in 0..args.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 186 | for (i, ) in args.iter().enumerate(){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:255:38 [INFO] [stderr] | [INFO] [stderr] 255 | fn get_return_value(&self, args: &Vec) -> &T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParsedArgument]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:464:47 [INFO] [stderr] | [INFO] [stderr] 464 | } else if current_arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:480:66 [INFO] [stderr] | [INFO] [stderr] 480 | let arg_value = if !next_arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "98e86c2b9f4649f0ce281a10367142a0bb256636c26d5516f156c077e4da2247"` [INFO] running `"docker" "rm" "-f" "98e86c2b9f4649f0ce281a10367142a0bb256636c26d5516f156c077e4da2247"` [INFO] [stdout] 98e86c2b9f4649f0ce281a10367142a0bb256636c26d5516f156c077e4da2247