[INFO] updating cached repository paulcacheux/raytracer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/paulcacheux/raytracer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/paulcacheux/raytracer" "work/ex/clippy-test-run/sources/stable/gh/paulcacheux/raytracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paulcacheux/raytracer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/paulcacheux/raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulcacheux/raytracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulcacheux/raytracer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] acab0d3e255a2085bd7288c091a51ab5dd96aba7
[INFO] sha for GitHub repo paulcacheux/raytracer: acab0d3e255a2085bd7288c091a51ab5dd96aba7
[INFO] validating manifest of paulcacheux/raytracer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of paulcacheux/raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing paulcacheux/raytracer
[INFO] finished frobbing paulcacheux/raytracer
[INFO] frobbed toml for paulcacheux/raytracer written to work/ex/clippy-test-run/sources/stable/gh/paulcacheux/raytracer/Cargo.toml
[INFO] started frobbing paulcacheux/raytracer
[INFO] finished frobbing paulcacheux/raytracer
[INFO] frobbed toml for paulcacheux/raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulcacheux/raytracer/Cargo.toml
[INFO] crate paulcacheux/raytracer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting paulcacheux/raytracer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paulcacheux/raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 40d378de816c31ee40ea7dc8de3fda93c310dd90435069f76743a1fd10710960
[INFO] running `"docker" "start" "-a" "40d378de816c31ee40ea7dc8de3fda93c310dd90435069f76743a1fd10710960"`
[INFO] [stderr]     Checking pbr v1.0.1
[INFO] [stderr]     Checking perlin_noise v1.0.1
[INFO] [stderr]    Compiling syn v0.15.13
[INFO] [stderr]     Checking num-rational v0.2.1
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking rayon v1.0.2
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]    Compiling num-derive v0.2.3
[INFO] [stderr]     Checking tiff v0.2.1
[INFO] [stderr]     Checking image v0.20.0
[INFO] [stderr]     Checking raytracer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/ray_image.rs:59:17
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 write!(f, "{} {} {}\n", color.red, color.green, color.blue)?;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |         let u = f * s.dot(h);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let q = s.cross(edge1);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |         let v = f * ray.direction.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |         let t = f * edge2.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/ray_image.rs:59:17
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 write!(f, "{} {} {}\n", color.red, color.green, color.blue)?;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |         let u = f * s.dot(h);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let q = s.cross(edge1);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |         let v = f * ray.direction.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/hitable/triangle.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |         let t = f * edge2.dot(q);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Vector::new(self.red as f32 / 255.0, self.green as f32 / 255.0, self.blue as f32 / 255.0)
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: try: `f32::from(self.red)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:36:46
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Vector::new(self.red as f32 / 255.0, self.green as f32 / 255.0, self.blue as f32 / 255.0)
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.green)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:36:73
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Vector::new(self.red as f32 / 255.0, self.green as f32 / 255.0, self.blue as f32 / 255.0)
[INFO] [stderr]    |                                                                         ^^^^^^^^^^^^^^^^ help: try: `f32::from(self.blue)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:45:14
[INFO] [stderr]    |
[INFO] [stderr] 45 |             (c as f32 * coeff) as u8
[INFO] [stderr]    |              ^^^^^^^^ help: try: `f32::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `color::ColorAverager`
[INFO] [stderr]   --> src/color.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 | /     pub fn new() -> ColorAverager {
[INFO] [stderr] 66 | |         ColorAverager {
[INFO] [stderr] 67 | |             red: 0,
[INFO] [stderr] 68 | |             green: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |         }
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 |         self.red += color.red as u64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try: `u64::from(color.red)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:88:23
[INFO] [stderr]    |
[INFO] [stderr] 88 |         self.green += color.green as u64;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(color.green)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |         self.blue += color.blue as u64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color.blue)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray_image.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 | /     pub fn pixel_mut_iter<'a>(&'a mut self) -> RayImagePixelIter<'a> {
[INFO] [stderr] 38 | |         RayImagePixelIter {
[INFO] [stderr] 39 | |             image_start: self.pixels.as_mut_ptr(),
[INFO] [stderr] 40 | |             current: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/hitable/bvh.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 |     pub fn fast_cmp(a: &f32, b: &f32) -> Ordering {
[INFO] [stderr]     |                        ^^^^ help: consider passing by value instead: `f32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/hitable/bvh.rs:103:33
[INFO] [stderr]     |
[INFO] [stderr] 103 |     pub fn fast_cmp(a: &f32, b: &f32) -> Ordering {
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `f32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/hitable/bvh.rs:104:12
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if *a == *b {
[INFO] [stderr]     |            ^^^^^^^^ help: consider comparing them within some error: `(*a - *b).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/hitable/bvh.rs:104:12
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if *a == *b {
[INFO] [stderr]     |            ^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/hitable/triangle.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         if min_x == max_x {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min_x - max_x).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/hitable/triangle.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         if min_x == max_x {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/hitable/triangle.rs:84:12
[INFO] [stderr]    |
[INFO] [stderr] 84 |         if min_y == max_y {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min_y - max_y).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/hitable/triangle.rs:84:12
[INFO] [stderr]    |
[INFO] [stderr] 84 |         if min_y == max_y {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/hitable/triangle.rs:89:12
[INFO] [stderr]    |
[INFO] [stderr] 89 |         if min_z == max_z {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min_z - max_z).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/hitable/triangle.rs:89:12
[INFO] [stderr]    |
[INFO] [stderr] 89 |         if min_z == max_z {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 |             scale: scale as f64
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: try: `f64::from(scale)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:23:53
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let noise = self.perlin.get3d([self.scale * point.x as f64, self.scale * point.y as f64, self.scale * point.z as f64]);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^ help: try: `f64::from(point.x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:23:82
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let noise = self.perlin.get3d([self.scale * point.x as f64, self.scale * point.y as f64, self.scale * point.z as f64]);
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^^^^^ help: try: `f64::from(point.y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:23:111
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let noise = self.perlin.get3d([self.scale * point.x as f64, self.scale * point.y as f64, self.scale * point.z as f64]);
[INFO] [stderr]    |                                                                                                               ^^^^^^^^^^^^^^ help: try: `f64::from(point.z)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         color.apply_func(|c| (c as f64 / noise) as u8);
[INFO] [stderr]    |                               ^^^^^^^^ help: try: `f64::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `raytracer`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Vector::new(self.red as f32 / 255.0, self.green as f32 / 255.0, self.blue as f32 / 255.0)
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: try: `f32::from(self.red)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:36:46
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Vector::new(self.red as f32 / 255.0, self.green as f32 / 255.0, self.blue as f32 / 255.0)
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.green)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:36:73
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Vector::new(self.red as f32 / 255.0, self.green as f32 / 255.0, self.blue as f32 / 255.0)
[INFO] [stderr]    |                                                                         ^^^^^^^^^^^^^^^^ help: try: `f32::from(self.blue)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:45:14
[INFO] [stderr]    |
[INFO] [stderr] 45 |             (c as f32 * coeff) as u8
[INFO] [stderr]    |              ^^^^^^^^ help: try: `f32::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `color::ColorAverager`
[INFO] [stderr]   --> src/color.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 | /     pub fn new() -> ColorAverager {
[INFO] [stderr] 66 | |         ColorAverager {
[INFO] [stderr] 67 | |             red: 0,
[INFO] [stderr] 68 | |             green: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |         }
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 |         self.red += color.red as u64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try: `u64::from(color.red)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:88:23
[INFO] [stderr]    |
[INFO] [stderr] 88 |         self.green += color.green as u64;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(color.green)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/color.rs:89:22
[INFO] [stderr]    |
[INFO] [stderr] 89 |         self.blue += color.blue as u64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color.blue)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray_image.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 | /     pub fn pixel_mut_iter<'a>(&'a mut self) -> RayImagePixelIter<'a> {
[INFO] [stderr] 38 | |         RayImagePixelIter {
[INFO] [stderr] 39 | |             image_start: self.pixels.as_mut_ptr(),
[INFO] [stderr] 40 | |             current: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/hitable/bvh.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 |     pub fn fast_cmp(a: &f32, b: &f32) -> Ordering {
[INFO] [stderr]     |                        ^^^^ help: consider passing by value instead: `f32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/hitable/bvh.rs:103:33
[INFO] [stderr]     |
[INFO] [stderr] 103 |     pub fn fast_cmp(a: &f32, b: &f32) -> Ordering {
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `f32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/hitable/bvh.rs:104:12
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if *a == *b {
[INFO] [stderr]     |            ^^^^^^^^ help: consider comparing them within some error: `(*a - *b).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/hitable/bvh.rs:104:12
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if *a == *b {
[INFO] [stderr]     |            ^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/hitable/triangle.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         if min_x == max_x {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min_x - max_x).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/hitable/triangle.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         if min_x == max_x {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/hitable/triangle.rs:84:12
[INFO] [stderr]    |
[INFO] [stderr] 84 |         if min_y == max_y {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min_y - max_y).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/hitable/triangle.rs:84:12
[INFO] [stderr]    |
[INFO] [stderr] 84 |         if min_y == max_y {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/hitable/triangle.rs:89:12
[INFO] [stderr]    |
[INFO] [stderr] 89 |         if min_z == max_z {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min_z - max_z).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/hitable/triangle.rs:89:12
[INFO] [stderr]    |
[INFO] [stderr] 89 |         if min_z == max_z {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 |             scale: scale as f64
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: try: `f64::from(scale)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:23:53
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let noise = self.perlin.get3d([self.scale * point.x as f64, self.scale * point.y as f64, self.scale * point.z as f64]);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^ help: try: `f64::from(point.x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:23:82
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let noise = self.perlin.get3d([self.scale * point.x as f64, self.scale * point.y as f64, self.scale * point.z as f64]);
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^^^^^ help: try: `f64::from(point.y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:23:111
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let noise = self.perlin.get3d([self.scale * point.x as f64, self.scale * point.y as f64, self.scale * point.z as f64]);
[INFO] [stderr]    |                                                                                                               ^^^^^^^^^^^^^^ help: try: `f64::from(point.z)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/texture/perlin.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |         color.apply_func(|c| (c as f64 / noise) as u8);
[INFO] [stderr]    |                               ^^^^^^^^ help: try: `f64::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `raytracer`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "40d378de816c31ee40ea7dc8de3fda93c310dd90435069f76743a1fd10710960"`
[INFO] running `"docker" "rm" "-f" "40d378de816c31ee40ea7dc8de3fda93c310dd90435069f76743a1fd10710960"`
[INFO] [stdout] 40d378de816c31ee40ea7dc8de3fda93c310dd90435069f76743a1fd10710960