[INFO] updating cached repository paulcacheux/mips_emu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paulcacheux/mips_emu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paulcacheux/mips_emu" "work/ex/clippy-test-run/sources/stable/gh/paulcacheux/mips_emu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paulcacheux/mips_emu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paulcacheux/mips_emu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulcacheux/mips_emu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulcacheux/mips_emu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51b84cc37c6874743aa49d30dedecc6003ef4dd3 [INFO] sha for GitHub repo paulcacheux/mips_emu: 51b84cc37c6874743aa49d30dedecc6003ef4dd3 [INFO] validating manifest of paulcacheux/mips_emu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paulcacheux/mips_emu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paulcacheux/mips_emu [INFO] finished frobbing paulcacheux/mips_emu [INFO] frobbed toml for paulcacheux/mips_emu written to work/ex/clippy-test-run/sources/stable/gh/paulcacheux/mips_emu/Cargo.toml [INFO] started frobbing paulcacheux/mips_emu [INFO] finished frobbing paulcacheux/mips_emu [INFO] frobbed toml for paulcacheux/mips_emu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulcacheux/mips_emu/Cargo.toml [INFO] crate paulcacheux/mips_emu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paulcacheux/mips_emu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paulcacheux/mips_emu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3fa4bb1c944ec0c2d67b110892d802fc1de694c177a5d9c3a91e85091b5531b [INFO] running `"docker" "start" "-a" "c3fa4bb1c944ec0c2d67b110892d802fc1de694c177a5d9c3a91e85091b5531b"` [INFO] [stderr] Checking elf v0.0.10 [INFO] [stderr] Checking mips_emu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let _0 = self.get_byte(index + 0) as u16; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let _1 = self.get_byte(index + 1) as u16; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let _0 = self.get_byte(index + 0) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let _0 = self.get_byte(index + 0) as u16; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let _1 = self.get_byte(index + 1) as u16; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let _0 = self.get_byte(index + 0) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let _1 = self.get_byte(index + 1) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let _2 = self.get_byte(index + 2) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let _3 = self.get_byte(index + 3) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let _1 = self.get_byte(index + 1) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let _2 = self.get_byte(index + 2) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/memory.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let _3 = self.get_byte(index + 3) as u32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:122:30 [INFO] [stderr] | [INFO] [stderr] 122 | let data_id = (index & !(0xFFFFFFFF << BLOCK_BIT_LEN)) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | 0b000000 => decode_r_inst(word), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | 0b011100 => decode_r2_inst(word), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | 0b000001 => decode_branch_comp(word), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | 0b000010 => decode_jump(word, Instruction::J), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | 0b000011 => decode_jump(word, Instruction::JAL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | 0b000100 => decode_i_sign_extend(word, Instruction::BEQ), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | 0b000101 => decode_i_sign_extend(word, Instruction::BNE), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | 0b000110 => decode_i_sign_extend(word, |rs, _, imm| Instruction::BLEZ(rs, imm)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | 0b000111 => decode_i_sign_extend(word, |rs, _, imm| Instruction::BGTZ(rs, imm)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | 0b001000 => decode_i_sign_extend(word, Instruction::ADDI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | 0b001001 => decode_i_sign_extend(word, Instruction::ADDIU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | 0b001010 => decode_i_sign_extend(word, Instruction::SLTI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | 0b001011 => decode_i_sign_extend(word, Instruction::SLTIU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | 0b001100 => decode_i_zero_extend(word, Instruction::ANDI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | 0b001101 => decode_i_zero_extend(word, Instruction::ORI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | 0b001110 => decode_i_zero_extend(word, Instruction::XORI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | 0b001111 => decode_i_zero_extend(word, |_, rt, imm| Instruction::LUI(rt, imm)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | 0b100000 => decode_i_sign_extend(word, Instruction::LB), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | 0b100001 => decode_i_sign_extend(word, Instruction::LH), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | 0b100010 => decode_i_sign_extend(word, Instruction::LWL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | 0b100011 => decode_i_sign_extend(word, Instruction::LW), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | 0b100100 => decode_i_sign_extend(word, Instruction::LBU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | 0b100101 => decode_i_sign_extend(word, Instruction::LHU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | 0b100110 => decode_i_sign_extend(word, Instruction::LWR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | 0b101000 => decode_i_sign_extend(word, Instruction::SB), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | 0b101001 => decode_i_sign_extend(word, Instruction::SH), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | 0b101010 => decode_i_sign_extend(word, Instruction::SWL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | 0b101011 => decode_i_sign_extend(word, Instruction::SW), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | 0b101110 => decode_i_sign_extend(word, Instruction::SWR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | 0b000000 => decode_r_shift(word, Instruction::SLL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | 0b000010 => decode_r_shift(word, Instruction::SRL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | 0b000011 => decode_r_shift(word, Instruction::SRA), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | 0b000100 => decode_r_no_shift(word, Instruction::SLLV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | 0b000110 => decode_r_no_shift(word, Instruction::SRLV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | 0b000111 => decode_r_no_shift(word, Instruction::SRAV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | 0b001000 => decode_r_no_shift(word, |rs, _, _| Instruction::JR(rs)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | 0b001001 => decode_r_no_shift(word, |rs, _, rd| Instruction::JALR(rs, rd)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | 0b001010 => decode_r_no_shift(word, Instruction::MOVZ), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | 0b001011 => decode_r_no_shift(word, Instruction::MOVN), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | 0b001100 => Instruction::SYSCALL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | 0b001101 => Instruction::BREAK, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 0b010000 => decode_r_no_shift(word, |_, _, rd| Instruction::MFHI(rd)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | 0b010001 => decode_r_no_shift(word, |rs, _, _| Instruction::MTHI(rs)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | 0b010010 => decode_r_no_shift(word, |_, _, rd| Instruction::MFLO(rd)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | 0b010011 => decode_r_no_shift(word, |rs, _, _| Instruction::MTLO(rs)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | 0b011000 => decode_r_div_mul(word, Instruction::MULT), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | 0b011001 => decode_r_div_mul(word, Instruction::MULTU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | 0b011010 => decode_r_div_mul(word, Instruction::DIV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | 0b011011 => decode_r_div_mul(word, Instruction::DIVU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | 0b100000 => decode_r_no_shift(word, Instruction::ADD), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | 0b100001 => decode_r_no_shift(word, Instruction::ADDU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | 0b100010 => decode_r_no_shift(word, Instruction::SUB), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | 0b100011 => decode_r_no_shift(word, Instruction::SUBU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | 0b100100 => decode_r_no_shift(word, Instruction::AND), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | 0b100101 => decode_r_no_shift(word, Instruction::OR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | 0b100110 => decode_r_no_shift(word, Instruction::XOR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | 0b100111 => decode_r_no_shift(word, Instruction::NOR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | 0b101010 => decode_r_no_shift(word, Instruction::SLT), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | 0b101011 => decode_r_no_shift(word, Instruction::SLTU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | 0b110100 => decode_r_no_shift(word, |rs, rt, _| Instruction::TEQ(rs, rt)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | 0b000010 => decode_r_no_shift(word, Instruction::MUL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:255:29 [INFO] [stderr] | [INFO] [stderr] 255 | rt_value & (0xFFFFFFFFu32 >> (8 * (unaligned_offset + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/executer.rs:270:28 [INFO] [stderr] | [INFO] [stderr] 270 | let mem_part = cpu.memory.get_word(addr - unaligned_offset) >> 8 * unaligned_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `cpu.memory.get_word(addr - unaligned_offset) >> (8 * unaligned_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:272:29 [INFO] [stderr] | [INFO] [stderr] 272 | rt_value & (0xFFFFFFFFu32 << (8 * (4 - unaligned_offset))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:473:24 [INFO] [stderr] | [INFO] [stderr] 473 | & (0xFFFFFFFFu32 << (8 * (unaligned_offset + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/executer.rs:489:24 [INFO] [stderr] | [INFO] [stderr] 489 | & (0xFFFFFFFFu32 >> 8 * (4 - unaligned_offset)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0xFFFFFFFFu32 >> (8 * (4 - unaligned_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:489:24 [INFO] [stderr] | [INFO] [stderr] 489 | & (0xFFFFFFFFu32 >> 8 * (4 - unaligned_offset)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/executer.rs:493:28 [INFO] [stderr] | [INFO] [stderr] 493 | let reg_part = rt_value << 8 * unaligned_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `rt_value << (8 * unaligned_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:122:30 [INFO] [stderr] | [INFO] [stderr] 122 | let data_id = (index & !(0xFFFFFFFF << BLOCK_BIT_LEN)) as usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | 0b000000 => decode_r_inst(word), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | 0b011100 => decode_r2_inst(word), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | 0b000001 => decode_branch_comp(word), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | 0b000010 => decode_jump(word, Instruction::J), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | 0b000011 => decode_jump(word, Instruction::JAL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | 0b000100 => decode_i_sign_extend(word, Instruction::BEQ), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | 0b000101 => decode_i_sign_extend(word, Instruction::BNE), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | 0b000110 => decode_i_sign_extend(word, |rs, _, imm| Instruction::BLEZ(rs, imm)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | 0b000111 => decode_i_sign_extend(word, |rs, _, imm| Instruction::BGTZ(rs, imm)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | 0b001000 => decode_i_sign_extend(word, Instruction::ADDI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | 0b001001 => decode_i_sign_extend(word, Instruction::ADDIU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | 0b001010 => decode_i_sign_extend(word, Instruction::SLTI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | 0b001011 => decode_i_sign_extend(word, Instruction::SLTIU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | 0b001100 => decode_i_zero_extend(word, Instruction::ANDI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | 0b001101 => decode_i_zero_extend(word, Instruction::ORI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | 0b001110 => decode_i_zero_extend(word, Instruction::XORI), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | 0b001111 => decode_i_zero_extend(word, |_, rt, imm| Instruction::LUI(rt, imm)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | 0b100000 => decode_i_sign_extend(word, Instruction::LB), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | 0b100001 => decode_i_sign_extend(word, Instruction::LH), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | 0b100010 => decode_i_sign_extend(word, Instruction::LWL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | 0b100011 => decode_i_sign_extend(word, Instruction::LW), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | 0b100100 => decode_i_sign_extend(word, Instruction::LBU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | 0b100101 => decode_i_sign_extend(word, Instruction::LHU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | 0b100110 => decode_i_sign_extend(word, Instruction::LWR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | 0b101000 => decode_i_sign_extend(word, Instruction::SB), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | 0b101001 => decode_i_sign_extend(word, Instruction::SH), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | 0b101010 => decode_i_sign_extend(word, Instruction::SWL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | 0b101011 => decode_i_sign_extend(word, Instruction::SW), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | 0b101110 => decode_i_sign_extend(word, Instruction::SWR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | 0b000000 => decode_r_shift(word, Instruction::SLL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | 0b000010 => decode_r_shift(word, Instruction::SRL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | 0b000011 => decode_r_shift(word, Instruction::SRA), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | 0b000100 => decode_r_no_shift(word, Instruction::SLLV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | 0b000110 => decode_r_no_shift(word, Instruction::SRLV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | 0b000111 => decode_r_no_shift(word, Instruction::SRAV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | 0b001000 => decode_r_no_shift(word, |rs, _, _| Instruction::JR(rs)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | 0b001001 => decode_r_no_shift(word, |rs, _, rd| Instruction::JALR(rs, rd)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | 0b001010 => decode_r_no_shift(word, Instruction::MOVZ), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | 0b001011 => decode_r_no_shift(word, Instruction::MOVN), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | 0b001100 => Instruction::SYSCALL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | 0b001101 => Instruction::BREAK, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 0b010000 => decode_r_no_shift(word, |_, _, rd| Instruction::MFHI(rd)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | 0b010001 => decode_r_no_shift(word, |rs, _, _| Instruction::MTHI(rs)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | 0b010010 => decode_r_no_shift(word, |_, _, rd| Instruction::MFLO(rd)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | 0b010011 => decode_r_no_shift(word, |rs, _, _| Instruction::MTLO(rs)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | 0b011000 => decode_r_div_mul(word, Instruction::MULT), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | 0b011001 => decode_r_div_mul(word, Instruction::MULTU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | 0b011010 => decode_r_div_mul(word, Instruction::DIV), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | 0b011011 => decode_r_div_mul(word, Instruction::DIVU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | 0b100000 => decode_r_no_shift(word, Instruction::ADD), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | 0b100001 => decode_r_no_shift(word, Instruction::ADDU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | 0b100010 => decode_r_no_shift(word, Instruction::SUB), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | 0b100011 => decode_r_no_shift(word, Instruction::SUBU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | 0b100100 => decode_r_no_shift(word, Instruction::AND), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | 0b100101 => decode_r_no_shift(word, Instruction::OR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | 0b100110 => decode_r_no_shift(word, Instruction::XOR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | 0b100111 => decode_r_no_shift(word, Instruction::NOR), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | 0b101010 => decode_r_no_shift(word, Instruction::SLT), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | 0b101011 => decode_r_no_shift(word, Instruction::SLTU), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | 0b110100 => decode_r_no_shift(word, |rs, rt, _| Instruction::TEQ(rs, rt)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoder.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | 0b000010 => decode_r_no_shift(word, Instruction::MUL), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:255:29 [INFO] [stderr] | [INFO] [stderr] 255 | rt_value & (0xFFFFFFFFu32 >> (8 * (unaligned_offset + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/executer.rs:270:28 [INFO] [stderr] | [INFO] [stderr] 270 | let mem_part = cpu.memory.get_word(addr - unaligned_offset) >> 8 * unaligned_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `cpu.memory.get_word(addr - unaligned_offset) >> (8 * unaligned_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:272:29 [INFO] [stderr] | [INFO] [stderr] 272 | rt_value & (0xFFFFFFFFu32 << (8 * (4 - unaligned_offset))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:473:24 [INFO] [stderr] | [INFO] [stderr] 473 | & (0xFFFFFFFFu32 << (8 * (unaligned_offset + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/executer.rs:489:24 [INFO] [stderr] | [INFO] [stderr] 489 | & (0xFFFFFFFFu32 >> 8 * (4 - unaligned_offset)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0xFFFFFFFFu32 >> (8 * (4 - unaligned_offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/executer.rs:489:24 [INFO] [stderr] | [INFO] [stderr] 489 | & (0xFFFFFFFFu32 >> 8 * (4 - unaligned_offset)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/executer.rs:493:28 [INFO] [stderr] | [INFO] [stderr] 493 | let reg_part = rt_value << 8 * unaligned_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `rt_value << (8 * unaligned_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | let result = (base as i64) + (offset as i64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(base)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:2:34 [INFO] [stderr] | [INFO] [stderr] 2 | let result = (base as i64) + (offset as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | assert!(result == result_word as i64, "OVERFLOW ERROR"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(result_word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::Memory` [INFO] [stderr] --> src/memory.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Memory { [INFO] [stderr] 14 | | Memory { [INFO] [stderr] 15 | | blocks: BTreeMap::new(), [INFO] [stderr] 16 | | cache: RefCell::new(None) [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | let _0 = self.get_byte(index + 0) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_byte(index + 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | let _0 = self.get_byte(index + 0) as u16; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | let _1 = self.get_byte(index + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_byte(index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | self.set_byte(index + 0, half_word as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | let _0 = self.get_byte(index + 0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:65:32 [INFO] [stderr] | [INFO] [stderr] 65 | let _0 = self.get_byte(index + 0) as u32; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | let _1 = self.get_byte(index + 1) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let _2 = self.get_byte(index + 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | let _3 = self.get_byte(index + 3) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | self.set_byte(index + 0, word as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/memory.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..(1 << BLOCK_BIT_LEN) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for (i, ) in data.iter_mut().enumerate().take((1 << BLOCK_BIT_LEN)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/memory.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..(1 << BLOCK_BIT_LEN) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `data[..(1 << BLOCK_BIT_LEN)].clone_from_slice(&self.data[..(1 << BLOCK_BIT_LEN)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | let result = (base as i64) + (offset as i64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(base)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:2:34 [INFO] [stderr] | [INFO] [stderr] 2 | let result = (base as i64) + (offset as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | assert!(result == result_word as i64, "OVERFLOW ERROR"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(result_word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `memory::Memory` [INFO] [stderr] --> src/memory.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Memory { [INFO] [stderr] 14 | | Memory { [INFO] [stderr] 15 | | blocks: BTreeMap::new(), [INFO] [stderr] 16 | | cache: RefCell::new(None) [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | let _0 = self.get_byte(index + 0) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_byte(index + 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | let _0 = self.get_byte(index + 0) as u16; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | let _1 = self.get_byte(index + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_byte(index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | self.set_byte(index + 0, half_word as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | let _0 = self.get_byte(index + 0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:65:32 [INFO] [stderr] | [INFO] [stderr] 65 | let _0 = self.get_byte(index + 0) as u32; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | let _1 = self.get_byte(index + 1) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let _2 = self.get_byte(index + 2) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | let _3 = self.get_byte(index + 3) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_byte(index + 3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/memory.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | self.set_byte(index + 0, word as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::Cpu` [INFO] [stderr] --> src/cpu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Cpu { [INFO] [stderr] 23 | | Cpu { [INFO] [stderr] 24 | | registers: [0; 31], [INFO] [stderr] 25 | | hi: 0, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for cpu::Cpu { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data` [INFO] [stderr] --> src/memory.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..(1 << BLOCK_BIT_LEN) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for (i, ) in data.iter_mut().enumerate().take((1 << BLOCK_BIT_LEN)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/memory.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..(1 << BLOCK_BIT_LEN) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `data[..(1 << BLOCK_BIT_LEN)].clone_from_slice(&self.data[..(1 << BLOCK_BIT_LEN)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::Cpu` [INFO] [stderr] --> src/cpu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Cpu { [INFO] [stderr] 23 | | Cpu { [INFO] [stderr] 24 | | registers: [0; 31], [INFO] [stderr] 25 | | hi: 0, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for cpu::Cpu { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:208:45 [INFO] [stderr] | [INFO] [stderr] 208 | cpu.set_register(rt, utils::i2u(byte as i32)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:215:34 [INFO] [stderr] | [INFO] [stderr] 215 | cpu.set_register(rt, byte as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:223:45 [INFO] [stderr] | [INFO] [stderr] 223 | cpu.set_register(rt, utils::i2u(half as i32)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(half)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:231:34 [INFO] [stderr] | [INFO] [stderr] 231 | cpu.set_register(rt, half as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(half)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:316:28 [INFO] [stderr] | [INFO] [stderr] 316 | let rs_value = utils::u2i(cpu.get_register(rs)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rs)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let rt_value = utils::u2i(cpu.get_register(rt)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rt)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:325:28 [INFO] [stderr] | [INFO] [stderr] 325 | let rs_value = utils::u2i(cpu.get_register(rs)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rs)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:326:28 [INFO] [stderr] | [INFO] [stderr] 326 | let rt_value = utils::u2i(cpu.get_register(rt)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rt)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:334:28 [INFO] [stderr] | [INFO] [stderr] 334 | let rs_value = cpu.get_register(rs) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cpu.get_register(rs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:335:28 [INFO] [stderr] | [INFO] [stderr] 335 | let rt_value = cpu.get_register(rt) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cpu.get_register(rt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:208:45 [INFO] [stderr] | [INFO] [stderr] 208 | cpu.set_register(rt, utils::i2u(byte as i32)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:215:34 [INFO] [stderr] | [INFO] [stderr] 215 | cpu.set_register(rt, byte as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:223:45 [INFO] [stderr] | [INFO] [stderr] 223 | cpu.set_register(rt, utils::i2u(half as i32)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(half)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:231:34 [INFO] [stderr] | [INFO] [stderr] 231 | cpu.set_register(rt, half as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(half)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:316:28 [INFO] [stderr] | [INFO] [stderr] 316 | let rs_value = utils::u2i(cpu.get_register(rs)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rs)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let rt_value = utils::u2i(cpu.get_register(rt)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rt)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:325:28 [INFO] [stderr] | [INFO] [stderr] 325 | let rs_value = utils::u2i(cpu.get_register(rs)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rs)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:326:28 [INFO] [stderr] | [INFO] [stderr] 326 | let rt_value = utils::u2i(cpu.get_register(rt)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(utils::u2i(cpu.get_register(rt)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:334:28 [INFO] [stderr] | [INFO] [stderr] 334 | let rs_value = cpu.get_register(rs) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cpu.get_register(rs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/executer.rs:335:28 [INFO] [stderr] | [INFO] [stderr] 335 | let rt_value = cpu.get_register(rt) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cpu.get_register(rt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/debugger.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 207 | | if let Ok(n) = args[0].parse::() { [INFO] [stderr] 208 | | n [INFO] [stderr] 209 | | } else { [INFO] [stderr] 210 | | return Err(format!("Can't parse {}.", args[0])); [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 206 | } else if let Ok(n) = args[0].parse::() { [INFO] [stderr] 207 | n [INFO] [stderr] 208 | } else { [INFO] [stderr] 209 | return Err(format!("Can't parse {}.", args[0])); [INFO] [stderr] 210 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/debugger.rs:244:16 [INFO] [stderr] | [INFO] [stderr] 244 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 245 | | if let Some(capt) = MEMORY_REGEX.captures(args[0]) { [INFO] [stderr] 246 | | let pc = u32::from_str_radix(&capt[1], 16).unwrap(); [INFO] [stderr] 247 | | dbg.cpu.add_or_remove_breakpoint(pc); [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 244 | } else if let Some(capt) = MEMORY_REGEX.captures(args[0]) { [INFO] [stderr] 245 | let pc = u32::from_str_radix(&capt[1], 16).unwrap(); [INFO] [stderr] 246 | dbg.cpu.add_or_remove_breakpoint(pc); [INFO] [stderr] 247 | } else { [INFO] [stderr] 248 | return Err("Can't parse the address.".to_string()); [INFO] [stderr] 249 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/debugger.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 207 | | if let Ok(n) = args[0].parse::() { [INFO] [stderr] 208 | | n [INFO] [stderr] 209 | | } else { [INFO] [stderr] 210 | | return Err(format!("Can't parse {}.", args[0])); [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 206 | } else if let Ok(n) = args[0].parse::() { [INFO] [stderr] 207 | n [INFO] [stderr] 208 | } else { [INFO] [stderr] 209 | return Err(format!("Can't parse {}.", args[0])); [INFO] [stderr] 210 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/debugger.rs:244:16 [INFO] [stderr] | [INFO] [stderr] 244 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 245 | | if let Some(capt) = MEMORY_REGEX.captures(args[0]) { [INFO] [stderr] 246 | | let pc = u32::from_str_radix(&capt[1], 16).unwrap(); [INFO] [stderr] 247 | | dbg.cpu.add_or_remove_breakpoint(pc); [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 244 | } else if let Some(capt) = MEMORY_REGEX.captures(args[0]) { [INFO] [stderr] 245 | let pc = u32::from_str_radix(&capt[1], 16).unwrap(); [INFO] [stderr] 246 | dbg.cpu.add_or_remove_breakpoint(pc); [INFO] [stderr] 247 | } else { [INFO] [stderr] 248 | return Err("Can't parse the address.".to_string()); [INFO] [stderr] 249 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugger.rs:204:20 [INFO] [stderr] | [INFO] [stderr] 204 | let n = if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/debugger.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | / match signal { [INFO] [stderr] 218 | | Signal::Exit => break, [INFO] [stderr] 219 | | _ => {} [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Signal::Exit = signal { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugger.rs:239:12 [INFO] [stderr] | [INFO] [stderr] 239 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugger.rs:204:20 [INFO] [stderr] | [INFO] [stderr] 204 | let n = if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/debugger.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | / match signal { [INFO] [stderr] 218 | | Signal::Exit => break, [INFO] [stderr] 219 | | _ => {} [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Signal::Exit = signal { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugger.rs:239:12 [INFO] [stderr] | [INFO] [stderr] 239 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.95s [INFO] running `"docker" "inspect" "c3fa4bb1c944ec0c2d67b110892d802fc1de694c177a5d9c3a91e85091b5531b"` [INFO] running `"docker" "rm" "-f" "c3fa4bb1c944ec0c2d67b110892d802fc1de694c177a5d9c3a91e85091b5531b"` [INFO] [stdout] c3fa4bb1c944ec0c2d67b110892d802fc1de694c177a5d9c3a91e85091b5531b