[INFO] updating cached repository patternseek/resticmgr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/patternseek/resticmgr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/patternseek/resticmgr" "work/ex/clippy-test-run/sources/stable/gh/patternseek/resticmgr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/patternseek/resticmgr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/patternseek/resticmgr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patternseek/resticmgr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patternseek/resticmgr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4142dc28582b1157074b34b658cfeadccfd5dc43 [INFO] sha for GitHub repo patternseek/resticmgr: 4142dc28582b1157074b34b658cfeadccfd5dc43 [INFO] validating manifest of patternseek/resticmgr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of patternseek/resticmgr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing patternseek/resticmgr [INFO] finished frobbing patternseek/resticmgr [INFO] frobbed toml for patternseek/resticmgr written to work/ex/clippy-test-run/sources/stable/gh/patternseek/resticmgr/Cargo.toml [INFO] started frobbing patternseek/resticmgr [INFO] finished frobbing patternseek/resticmgr [INFO] frobbed toml for patternseek/resticmgr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patternseek/resticmgr/Cargo.toml [INFO] crate patternseek/resticmgr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting patternseek/resticmgr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/patternseek/resticmgr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5784a6f540db0113d631c56b46729fcc83253714b5beee30778f6b7c75e68a22 [INFO] running `"docker" "start" "-a" "5784a6f540db0113d631c56b46729fcc83253714b5beee30778f6b7c75e68a22"` [INFO] [stderr] Compiling openssl v0.9.23 [INFO] [stderr] Compiling openssl-sys v0.9.24 [INFO] [stderr] Checking rand v0.3.20 [INFO] [stderr] Checking serde_json v1.0.8 [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Compiling email v0.0.18 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Compiling structopt-derive v0.1.6 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking lettre v0.7.0 [INFO] [stderr] Checking lettre_email v0.7.0 [INFO] [stderr] Checking resticmgr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:242:34 [INFO] [stderr] | [INFO] [stderr] 242 | Ok(out) => msgs.push(format!("{}", out)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `out.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:248:8 [INFO] [stderr] | [INFO] [stderr] 248 | if msgs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msgs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:258:8 [INFO] [stderr] | [INFO] [stderr] 258 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:242:34 [INFO] [stderr] | [INFO] [stderr] 242 | Ok(out) => msgs.push(format!("{}", out)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `out.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:248:8 [INFO] [stderr] | [INFO] [stderr] 248 | if msgs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msgs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:258:8 [INFO] [stderr] | [INFO] [stderr] 258 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.60s [INFO] running `"docker" "inspect" "5784a6f540db0113d631c56b46729fcc83253714b5beee30778f6b7c75e68a22"` [INFO] running `"docker" "rm" "-f" "5784a6f540db0113d631c56b46729fcc83253714b5beee30778f6b7c75e68a22"` [INFO] [stdout] 5784a6f540db0113d631c56b46729fcc83253714b5beee30778f6b7c75e68a22