[INFO] updating cached repository patricksjackson/kolakoski [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/patricksjackson/kolakoski [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/patricksjackson/kolakoski" "work/ex/clippy-test-run/sources/stable/gh/patricksjackson/kolakoski"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/patricksjackson/kolakoski'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/patricksjackson/kolakoski" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patricksjackson/kolakoski"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patricksjackson/kolakoski'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 03946e3dd0ca91fe720098e4096854841de0b8be [INFO] sha for GitHub repo patricksjackson/kolakoski: 03946e3dd0ca91fe720098e4096854841de0b8be [INFO] validating manifest of patricksjackson/kolakoski on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of patricksjackson/kolakoski on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing patricksjackson/kolakoski [INFO] finished frobbing patricksjackson/kolakoski [INFO] frobbed toml for patricksjackson/kolakoski written to work/ex/clippy-test-run/sources/stable/gh/patricksjackson/kolakoski/Cargo.toml [INFO] started frobbing patricksjackson/kolakoski [INFO] finished frobbing patricksjackson/kolakoski [INFO] frobbed toml for patricksjackson/kolakoski written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patricksjackson/kolakoski/Cargo.toml [INFO] crate patricksjackson/kolakoski has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting patricksjackson/kolakoski against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/patricksjackson/kolakoski:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 23d75ac456a795b66d1cb53d3cb5891de2e789d5dc212f542528a7e9b322b8ff [INFO] running `"docker" "start" "-a" "23d75ac456a795b66d1cb53d3cb5891de2e789d5dc212f542528a7e9b322b8ff"` [INFO] [stderr] Checking kolakoski v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | MyU128 { hi: 0, lo: lo } [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | Self { hi: hi, lo: lo } [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | Self { hi: hi, lo: lo } [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | MyU128 { hi: 0, lo: lo } [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | Self { hi: hi, lo: lo } [INFO] [stderr] | ^^^^^^ help: replace it with: `hi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | Self { hi: hi, lo: lo } [INFO] [stderr] | ^^^^^^ help: replace it with: `lo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | lo |= (self.hi & ((1 << rhs) - 1)) << 64 - rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.hi & ((1 << rhs) - 1)) << (64 - rhs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | lo |= (self.hi & ((1 << rhs) - 1)) << 64 - rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.hi & ((1 << rhs) - 1)) << (64 - rhs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / let mut tmp = self.lo; [INFO] [stderr] 37 | | if self.hi != 0 { [INFO] [stderr] 38 | | r += 64; [INFO] [stderr] 39 | | tmp = self.hi; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let tmp = if self.hi != 0 { ..; self.hi } else { self.lo };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kolakoski`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / let mut tmp = self.lo; [INFO] [stderr] 37 | | if self.hi != 0 { [INFO] [stderr] 38 | | r += 64; [INFO] [stderr] 39 | | tmp = self.hi; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let tmp = if self.hi != 0 { ..; self.hi } else { self.lo };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kolakoski`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "23d75ac456a795b66d1cb53d3cb5891de2e789d5dc212f542528a7e9b322b8ff"` [INFO] running `"docker" "rm" "-f" "23d75ac456a795b66d1cb53d3cb5891de2e789d5dc212f542528a7e9b322b8ff"` [INFO] [stdout] 23d75ac456a795b66d1cb53d3cb5891de2e789d5dc212f542528a7e9b322b8ff