[INFO] updating cached repository patrickf2000/rshell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/patrickf2000/rshell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/patrickf2000/rshell" "work/ex/clippy-test-run/sources/stable/gh/patrickf2000/rshell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/patrickf2000/rshell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/patrickf2000/rshell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patrickf2000/rshell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patrickf2000/rshell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 97601293dfa8407bb5ccc3463d0f6e30a906818d
[INFO] sha for GitHub repo patrickf2000/rshell: 97601293dfa8407bb5ccc3463d0f6e30a906818d
[INFO] validating manifest of patrickf2000/rshell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of patrickf2000/rshell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing patrickf2000/rshell
[INFO] finished frobbing patrickf2000/rshell
[INFO] frobbed toml for patrickf2000/rshell written to work/ex/clippy-test-run/sources/stable/gh/patrickf2000/rshell/Cargo.toml
[INFO] started frobbing patrickf2000/rshell
[INFO] finished frobbing patrickf2000/rshell
[INFO] frobbed toml for patrickf2000/rshell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/patrickf2000/rshell/Cargo.toml
[INFO] crate patrickf2000/rshell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting patrickf2000/rshell against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/patrickf2000/rshell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9d4bd2b8c37448e96508bd5791a0754c95d0b0f7731d0599477a52b19c859b44
[INFO] running `"docker" "start" "-a" "9d4bd2b8c37448e96508bd5791a0754c95d0b0f7731d0599477a52b19c859b44"`
[INFO] [stderr]     Checking rshell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/str_utils.rs:53:10
[INFO] [stderr]    |
[INFO] [stderr] 53 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 54 | |             if found {
[INFO] [stderr] 55 | |                 ret.push(c);
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if found {
[INFO] [stderr] 54 |     ret.push(c);
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/str_utils.rs:53:10
[INFO] [stderr]    |
[INFO] [stderr] 53 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 54 | |             if found {
[INFO] [stderr] 55 | |                 ret.push(c);
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if found {
[INFO] [stderr] 54 |     ret.push(c);
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/shell.rs:56:31
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn find(cmd:String, paths:&Vec<String>) -> String {
[INFO] [stderr]    |                               ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/shell.rs:76:2
[INFO] [stderr]    |
[INFO] [stderr] 76 |       let mut child = Command::new(path.clone())
[INFO] [stderr]    |  _____^
[INFO] [stderr] 77 | |             .stdout(Stdio::piped())
[INFO] [stderr] 78 | |             .spawn()
[INFO] [stderr] 79 | |             .expect("Unable to execute command.");
[INFO] [stderr] ...  |
[INFO] [stderr] 86 | |             .expect("Unable to execute command.");
[INFO] [stderr] 87 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]    |
[INFO] [stderr] 76 |     let <mut> child = if args.len()>0 { Command::new(path)
[INFO] [stderr] 77 |             .stdout(Stdio::piped())
[INFO] [stderr] 78 |             .args(args)
[INFO] [stderr] 79 |             .spawn()
[INFO] [stderr] 80 |             .expect("Unable to execute command.") } else { Command::new(path.clone())
[INFO] [stderr] 81 |             .stdout(Stdio::piped())
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/shell.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if args.len()>0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/command.rs:62:6
[INFO] [stderr]    |
[INFO] [stderr] 62 |         if current.len()>0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/shell.rs:56:31
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn find(cmd:String, paths:&Vec<String>) -> String {
[INFO] [stderr]    |                               ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/shell.rs:76:2
[INFO] [stderr]    |
[INFO] [stderr] 76 |       let mut child = Command::new(path.clone())
[INFO] [stderr]    |  _____^
[INFO] [stderr] 77 | |             .stdout(Stdio::piped())
[INFO] [stderr] 78 | |             .spawn()
[INFO] [stderr] 79 | |             .expect("Unable to execute command.");
[INFO] [stderr] ...  |
[INFO] [stderr] 86 | |             .expect("Unable to execute command.");
[INFO] [stderr] 87 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]    |
[INFO] [stderr] 76 |     let <mut> child = if args.len()>0 { Command::new(path)
[INFO] [stderr] 77 |             .stdout(Stdio::piped())
[INFO] [stderr] 78 |             .args(args)
[INFO] [stderr] 79 |             .spawn()
[INFO] [stderr] 80 |             .expect("Unable to execute command.") } else { Command::new(path.clone())
[INFO] [stderr] 81 |             .stdout(Stdio::piped())
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/shell.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if args.len()>0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/command.rs:62:6
[INFO] [stderr]    |
[INFO] [stderr] 62 |         if current.len()>0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.69s
[INFO] running `"docker" "inspect" "9d4bd2b8c37448e96508bd5791a0754c95d0b0f7731d0599477a52b19c859b44"`
[INFO] running `"docker" "rm" "-f" "9d4bd2b8c37448e96508bd5791a0754c95d0b0f7731d0599477a52b19c859b44"`
[INFO] [stdout] 9d4bd2b8c37448e96508bd5791a0754c95d0b0f7731d0599477a52b19c859b44