[INFO] updating cached repository passy/revmenu
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/passy/revmenu
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/passy/revmenu" "work/ex/clippy-test-run/sources/stable/gh/passy/revmenu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/passy/revmenu'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/passy/revmenu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/passy/revmenu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/passy/revmenu'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2dad88e8f4a08d6ea690cd96d100d71e4148d6d4
[INFO] sha for GitHub repo passy/revmenu: 2dad88e8f4a08d6ea690cd96d100d71e4148d6d4
[INFO] validating manifest of passy/revmenu on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of passy/revmenu on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing passy/revmenu
[INFO] finished frobbing passy/revmenu
[INFO] frobbed toml for passy/revmenu written to work/ex/clippy-test-run/sources/stable/gh/passy/revmenu/Cargo.toml
[INFO] started frobbing passy/revmenu
[INFO] finished frobbing passy/revmenu
[INFO] frobbed toml for passy/revmenu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/passy/revmenu/Cargo.toml
[INFO] crate passy/revmenu has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting passy/revmenu against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/passy/revmenu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 56cd161240aee7f357ee065395d27f3d3477a15b93fadf765b2752377478fdcd
[INFO] running `"docker" "start" "-a" "56cd161240aee7f357ee065395d27f3d3477a15b93fadf765b2752377478fdcd"`
[INFO] [stderr]     Checking exitcode v1.1.2
[INFO] [stderr]     Checking termios v0.2.2
[INFO] [stderr]     Checking clicolors-control v0.2.0
[INFO] [stderr]    Compiling rustc_version v0.2.2
[INFO] [stderr]     Checking nom v4.0.0
[INFO] [stderr]     Checking tempdir v0.3.7
[INFO] [stderr]     Checking parking_lot_core v0.2.14
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking os_type v2.2.0
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]    Compiling im v10.2.0
[INFO] [stderr]     Checking parking_lot v0.6.2
[INFO] [stderr]     Checking human-panic v1.0.1
[INFO] [stderr]     Checking console v0.6.1
[INFO] [stderr]     Checking revmenu v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/highlight.rs:10:15
[INFO] [stderr]    |
[INFO] [stderr] 10 |     selected: &Option<&parser::Located<parser::RefLike>>,
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&parser::Located<parser::RefLike>>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/highlight.rs:36:45
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn line<'a, I>(str: &str, rls: I, selected: &Option<&RevLocation>) -> String
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&RevLocation>`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/vcs/git.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new(root: &Path) -> Option<Box<dyn VCS>> {
[INFO] [stderr] 17 | |         if root.join(".git").exists() {
[INFO] [stderr] 18 | |             Some(Box::new(Git {
[INFO] [stderr] 19 | |                 root: root.to_path_buf(),
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/vcs/hg.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new(root: &Path) -> Option<Box<dyn VCS>> {
[INFO] [stderr] 17 | |         if root.join(".hg").exists() {
[INFO] [stderr] 18 | |             Some(Box::new(Hg {
[INFO] [stderr] 19 | |                 root: root.to_path_buf(),
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/vcs/mod.rs:15:23
[INFO] [stderr]    |
[INFO] [stderr] 15 | static SUPPORTED_VCS: [fn(&Path) -> Option<Box<dyn VCS>>; 2] = [Git::new, Hg::new];
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/highlight.rs:10:15
[INFO] [stderr]    |
[INFO] [stderr] 10 |     selected: &Option<&parser::Located<parser::RefLike>>,
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&parser::Located<parser::RefLike>>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/highlight.rs:36:45
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn line<'a, I>(str: &str, rls: I, selected: &Option<&RevLocation>) -> String
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&RevLocation>`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/vcs/git.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new(root: &Path) -> Option<Box<dyn VCS>> {
[INFO] [stderr] 17 | |         if root.join(".git").exists() {
[INFO] [stderr] 18 | |             Some(Box::new(Git {
[INFO] [stderr] 19 | |                 root: root.to_path_buf(),
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/vcs/hg.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new(root: &Path) -> Option<Box<dyn VCS>> {
[INFO] [stderr] 17 | |         if root.join(".hg").exists() {
[INFO] [stderr] 18 | |             Some(Box::new(Hg {
[INFO] [stderr] 19 | |                 root: root.to_path_buf(),
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/vcs/mod.rs:15:23
[INFO] [stderr]    |
[INFO] [stderr] 15 | static SUPPORTED_VCS: [fn(&Path) -> Option<Box<dyn VCS>>; 2] = [Git::new, Hg::new];
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.16s
[INFO] running `"docker" "inspect" "56cd161240aee7f357ee065395d27f3d3477a15b93fadf765b2752377478fdcd"`
[INFO] running `"docker" "rm" "-f" "56cd161240aee7f357ee065395d27f3d3477a15b93fadf765b2752377478fdcd"`
[INFO] [stdout] 56cd161240aee7f357ee065395d27f3d3477a15b93fadf765b2752377478fdcd