[INFO] updating cached repository paskvale/todo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paskvale/todo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paskvale/todo" "work/ex/clippy-test-run/sources/stable/gh/paskvale/todo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paskvale/todo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paskvale/todo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paskvale/todo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paskvale/todo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 178f6b41a516e28b105c82c6eadf997db88e45dd [INFO] sha for GitHub repo paskvale/todo: 178f6b41a516e28b105c82c6eadf997db88e45dd [INFO] validating manifest of paskvale/todo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paskvale/todo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paskvale/todo [INFO] finished frobbing paskvale/todo [INFO] frobbed toml for paskvale/todo written to work/ex/clippy-test-run/sources/stable/gh/paskvale/todo/Cargo.toml [INFO] started frobbing paskvale/todo [INFO] finished frobbing paskvale/todo [INFO] frobbed toml for paskvale/todo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paskvale/todo/Cargo.toml [INFO] crate paskvale/todo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paskvale/todo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paskvale/todo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2a8e08f0bfd54306b33106153343d3d0c0a69aa63c65a1541d855de028dabb4a [INFO] running `"docker" "start" "-a" "2a8e08f0bfd54306b33106153343d3d0c0a69aa63c65a1541d855de028dabb4a"` [INFO] [stderr] Compiling serde v1.0.64 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling proc-macro2 v0.4.4 [INFO] [stderr] Compiling wayland-scanner v0.20.8 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Checking wayland-sys v0.20.8 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking wayland-commons v0.20.8 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling wayland-client v0.20.8 [INFO] [stderr] Compiling wayland-protocols v0.20.8 [INFO] [stderr] Compiling syn v0.14.1 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.64 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.1 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking winit v0.15.0 [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking glium v0.21.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking conrod v0.60.0 [INFO] [stderr] Checking todo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_manipulation.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | return FileManipulator {path: path, handle: handle, contents: None}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_manipulation.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | return FileManipulator {path: path, handle: handle, contents: None}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom_text.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_manipulation.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | return FileManipulator {path: path, handle: handle, contents: None}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_manipulation.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | return FileManipulator {path: path, handle: handle, contents: None}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom_text.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return FileManipulator {path: path, handle: handle, contents: None}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FileManipulator {path: path, handle: handle, contents: None}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | return hm; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:41:40 [INFO] [stderr] | [INFO] [stderr] 41 | .map_err(|err| return err.to_string())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:42:67 [INFO] [stderr] | [INFO] [stderr] 42 | .read_to_end(&mut contents).map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:44:56 [INFO] [stderr] | [INFO] [stderr] 44 | .map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:49:56 [INFO] [stderr] | [INFO] [stderr] 49 | .map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:62:65 [INFO] [stderr] | [INFO] [stderr] 62 | json = serde_json::to_string(&hm).map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/gui.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return FileManipulator {path: path, handle: handle, contents: None}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FileManipulator {path: path, handle: handle, contents: None}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | return hm; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:41:40 [INFO] [stderr] | [INFO] [stderr] 41 | .map_err(|err| return err.to_string())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:42:67 [INFO] [stderr] | [INFO] [stderr] 42 | .read_to_end(&mut contents).map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:44:56 [INFO] [stderr] | [INFO] [stderr] 44 | .map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:49:56 [INFO] [stderr] | [INFO] [stderr] 49 | .map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_manipulation.rs:62:65 [INFO] [stderr] | [INFO] [stderr] 62 | json = serde_json::to_string(&hm).map_err(|err| return err.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/gui.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `json` is never read [INFO] [stderr] --> src/file_manipulation.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let mut json = String::new(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_item` [INFO] [stderr] --> src/file_manipulation.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn new_item(&mut self, s: String) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `generate_string` [INFO] [stderr] --> src/file_manipulation.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | fn generate_string(length: u8) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `start` [INFO] [stderr] --> src/counter.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn start() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/file_manipulation.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if hm.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hm.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/file_manipulation.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match res { [INFO] [stderr] 73 | | Err(e) => {eprintln!("Error adding item '{}': {}", json, e);}, [INFO] [stderr] 74 | | _ => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = res {eprintln!("Error adding item '{}': {}", json, e);}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/file_manipulation.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | if rand::random::() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `rand::random::()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: value assigned to `json` is never read [INFO] [stderr] --> src/file_manipulation.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let mut json = String::new(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_item` [INFO] [stderr] --> src/file_manipulation.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn new_item(&mut self, s: String) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `generate_string` [INFO] [stderr] --> src/file_manipulation.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | fn generate_string(length: u8) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `start` [INFO] [stderr] --> src/counter.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn start() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/file_manipulation.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | if hm.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hm.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/file_manipulation.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match res { [INFO] [stderr] 73 | | Err(e) => {eprintln!("Error adding item '{}': {}", json, e);}, [INFO] [stderr] 74 | | _ => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = res {eprintln!("Error adding item '{}': {}", json, e);}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/file_manipulation.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | if rand::random::() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `rand::random::()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `"docker" "inspect" "2a8e08f0bfd54306b33106153343d3d0c0a69aa63c65a1541d855de028dabb4a"` [INFO] running `"docker" "rm" "-f" "2a8e08f0bfd54306b33106153343d3d0c0a69aa63c65a1541d855de028dabb4a"` [INFO] [stdout] 2a8e08f0bfd54306b33106153343d3d0c0a69aa63c65a1541d855de028dabb4a