[INFO] updating cached repository parth-shel/pshell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/parth-shel/pshell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/parth-shel/pshell" "work/ex/clippy-test-run/sources/stable/gh/parth-shel/pshell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/parth-shel/pshell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/parth-shel/pshell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/parth-shel/pshell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/parth-shel/pshell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5faed515e703066f8865f0287fdca770bc4f0aa7
[INFO] sha for GitHub repo parth-shel/pshell: 5faed515e703066f8865f0287fdca770bc4f0aa7
[INFO] validating manifest of parth-shel/pshell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of parth-shel/pshell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing parth-shel/pshell
[INFO] finished frobbing parth-shel/pshell
[INFO] frobbed toml for parth-shel/pshell written to work/ex/clippy-test-run/sources/stable/gh/parth-shel/pshell/Cargo.toml
[INFO] started frobbing parth-shel/pshell
[INFO] finished frobbing parth-shel/pshell
[INFO] frobbed toml for parth-shel/pshell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/parth-shel/pshell/Cargo.toml
[INFO] crate parth-shel/pshell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting parth-shel/pshell against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/parth-shel/pshell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 468d9e069017a887814bacd1f84d83c8c7988e9c4e5d23ad4a537fd00c8c74f1
[INFO] running `"docker" "start" "-a" "468d9e069017a887814bacd1f84d83c8c7988e9c4e5d23ad4a537fd00c8c74f1"`
[INFO] [stderr]     Checking utf8parse v0.1.0
[INFO] [stderr]     Checking commands v0.0.5
[INFO] [stderr]     Checking rustyline v2.1.0
[INFO] [stderr]     Checking pshell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused imports: `Child`, `Output`
[INFO] [stderr]  --> src/pshell.rs:6:34
[INFO] [stderr]   |
[INFO] [stderr] 6 | use std::process::{Stdio,Command,Child,Output,exit};
[INFO] [stderr]   |                                  ^^^^^ ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `FromRawFd`
[INFO] [stderr]  --> src/pshell.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::os::unix::io::{FromRawFd, AsRawFd};
[INFO] [stderr]   |                         ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::os::unix::process::CommandExt`
[INFO] [stderr]  --> src/pshell.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::os::unix::process::CommandExt;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nix::unistd::pipe`
[INFO] [stderr]   --> src/pshell.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use nix::unistd::pipe;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:186:2
[INFO] [stderr]     |
[INFO] [stderr] 186 |     return 0;
[INFO] [stderr]     |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:228:4
[INFO] [stderr]     |
[INFO] [stderr] 228 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:235:4
[INFO] [stderr]     |
[INFO] [stderr] 235 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:241:4
[INFO] [stderr]     |
[INFO] [stderr] 241 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:254:4
[INFO] [stderr]     |
[INFO] [stderr] 254 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:257:4
[INFO] [stderr]     |
[INFO] [stderr] 257 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:259:4
[INFO] [stderr]     |
[INFO] [stderr] 259 |             return false;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:36:2
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:172:2
[INFO] [stderr]     |
[INFO] [stderr] 172 |     return cmd_table;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cmd_table`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:189:3
[INFO] [stderr]     |
[INFO] [stderr] 189 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:199:3
[INFO] [stderr]     |
[INFO] [stderr] 199 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:203:3
[INFO] [stderr]     |
[INFO] [stderr] 203 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:207:3
[INFO] [stderr]     |
[INFO] [stderr] 207 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Child`, `Output`
[INFO] [stderr]  --> src/pshell.rs:6:34
[INFO] [stderr]   |
[INFO] [stderr] 6 | use std::process::{Stdio,Command,Child,Output,exit};
[INFO] [stderr]   |                                  ^^^^^ ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `FromRawFd`
[INFO] [stderr]  --> src/pshell.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::os::unix::io::{FromRawFd, AsRawFd};
[INFO] [stderr]   |                         ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::os::unix::process::CommandExt`
[INFO] [stderr]  --> src/pshell.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::os::unix::process::CommandExt;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nix::unistd::pipe`
[INFO] [stderr]   --> src/pshell.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use nix::unistd::pipe;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:186:2
[INFO] [stderr]     |
[INFO] [stderr] 186 |     return 0;
[INFO] [stderr]     |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:228:4
[INFO] [stderr]     |
[INFO] [stderr] 228 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:235:4
[INFO] [stderr]     |
[INFO] [stderr] 235 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:241:4
[INFO] [stderr]     |
[INFO] [stderr] 241 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:254:4
[INFO] [stderr]     |
[INFO] [stderr] 254 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:257:4
[INFO] [stderr]     |
[INFO] [stderr] 257 |             return true;
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/pshell.rs:259:4
[INFO] [stderr]     |
[INFO] [stderr] 259 |             return false;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:36:2
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:172:2
[INFO] [stderr]     |
[INFO] [stderr] 172 |     return cmd_table;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cmd_table`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:189:3
[INFO] [stderr]     |
[INFO] [stderr] 189 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:199:3
[INFO] [stderr]     |
[INFO] [stderr] 199 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:203:3
[INFO] [stderr]     |
[INFO] [stderr] 203 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:207:3
[INFO] [stderr]     |
[INFO] [stderr] 207 |         return tokens;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/pshell.rs:212:11
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 match env::home_dir() {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/pshell.rs:212:11
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 match env::home_dir() {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude`
[INFO] [stderr]  --> src/pshell.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `pid`
[INFO] [stderr]   --> src/pshell.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let pid = libc::waitpid(-1, ptr, libc::WNOHANG);
[INFO] [stderr]    |             ^^^ help: consider using `_pid` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ecode`
[INFO] [stderr]    --> src/pshell.rs:175:8
[INFO] [stderr]     |
[INFO] [stderr] 175 |             let ecode = child.wait().expect("pshell failed to wait on child");
[INFO] [stderr]     |                 ^^^^^ help: consider using `_ecode` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `pid`
[INFO] [stderr]    --> src/pshell.rs:178:8
[INFO] [stderr]     |
[INFO] [stderr] 178 |             let pid = child.id();
[INFO] [stderr]     |                 ^^^ help: consider using `_pid` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]    --> src/pshell.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn run_proc(args: Vec<String>, cmd_table: ComplexCommand) -> i32 {
[INFO] [stderr]     |             ^^^^ help: consider using `_args` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cmd_table`
[INFO] [stderr]    --> src/pshell.rs:185:32
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn run_proc(args: Vec<String>, cmd_table: ComplexCommand) -> i32 {
[INFO] [stderr]     |                                ^^^^^^^^^ help: consider using `_cmd_table` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cmd_table`
[INFO] [stderr]    --> src/pshell.rs:189:14
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn run_piped(cmd_table: ComplexCommand) {
[INFO] [stderr]     |              ^^^^^^^^^ help: consider using `_cmd_table` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude`
[INFO] [stderr]  --> src/pshell.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `pid`
[INFO] [stderr]   --> src/pshell.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let pid = libc::waitpid(-1, ptr, libc::WNOHANG);
[INFO] [stderr]    |             ^^^ help: consider using `_pid` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/pshell.rs:70:7
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let mut ecode = 0;
[INFO] [stderr]    |             ----^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ecode`
[INFO] [stderr]    --> src/pshell.rs:175:8
[INFO] [stderr]     |
[INFO] [stderr] 175 |             let ecode = child.wait().expect("pshell failed to wait on child");
[INFO] [stderr]     |                 ^^^^^ help: consider using `_ecode` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `pid`
[INFO] [stderr]    --> src/pshell.rs:178:8
[INFO] [stderr]     |
[INFO] [stderr] 178 |             let pid = child.id();
[INFO] [stderr]     |                 ^^^ help: consider using `_pid` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]    --> src/pshell.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn run_proc(args: Vec<String>, cmd_table: ComplexCommand) -> i32 {
[INFO] [stderr]     |             ^^^^ help: consider using `_args` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cmd_table`
[INFO] [stderr]    --> src/pshell.rs:185:32
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn run_proc(args: Vec<String>, cmd_table: ComplexCommand) -> i32 {
[INFO] [stderr]     |                                ^^^^^^^^^ help: consider using `_cmd_table` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cmd_table`
[INFO] [stderr]    --> src/pshell.rs:189:14
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn run_piped(cmd_table: ComplexCommand) {
[INFO] [stderr]     |              ^^^^^^^^^ help: consider using `_cmd_table` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/pshell.rs:70:7
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let mut ecode = 0;
[INFO] [stderr]    |             ----^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `run_proc`
[INFO] [stderr]    --> src/pshell.rs:185:1
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn run_proc(args: Vec<String>, cmd_table: ComplexCommand) -> i32 {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/pshell.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if cmd_table.simple_commands.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmd_table.simple_commands.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `run_proc`
[INFO] [stderr]    --> src/pshell.rs:185:1
[INFO] [stderr]     |
[INFO] [stderr] 185 | fn run_proc(args: Vec<String>, cmd_table: ComplexCommand) -> i32 {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/pshell.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if cmd_table.simple_commands.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmd_table.simple_commands.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:23:28
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 if to_push.starts_with("\"") && to_push.ends_with("\"") {
[INFO] [stderr]    |                                        ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:23:55
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 if to_push.starts_with("\"") && to_push.ends_with("\"") {
[INFO] [stderr]    |                                                                   ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     if tokens.len() > 0 && tokens[tokens.len() - 1] == "&" {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:23:28
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 if to_push.starts_with("\"") && to_push.ends_with("\"") {
[INFO] [stderr]    |                                        ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:23:55
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 if to_push.starts_with("\"") && to_push.ends_with("\"") {
[INFO] [stderr]    |                                                                   ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:168:5
[INFO] [stderr]     |
[INFO] [stderr] 168 |     if simple_command.args.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_command.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     if tokens.len() > 0 && tokens[tokens.len() - 1] == "&" {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/parser.rs:192:25
[INFO] [stderr]     |
[INFO] [stderr] 192 |     else if token.contains("*") || token.contains("~") {
[INFO] [stderr]     |                            ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/parser.rs:192:48
[INFO] [stderr]     |
[INFO] [stderr] 192 |     else if token.contains("*") || token.contains("~") {
[INFO] [stderr]     |                                                   ^^^ help: try using a char instead: `'~'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:168:5
[INFO] [stderr]     |
[INFO] [stderr] 168 |     if simple_command.args.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_command.args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:61:8
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 if line.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/parser.rs:192:25
[INFO] [stderr]     |
[INFO] [stderr] 192 |     else if token.contains("*") || token.contains("~") {
[INFO] [stderr]     |                            ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/parser.rs:192:48
[INFO] [stderr]     |
[INFO] [stderr] 192 |     else if token.contains("*") || token.contains("~") {
[INFO] [stderr]     |                                                   ^^^ help: try using a char instead: `'~'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:61:8
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 if line.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.51s
[INFO] running `"docker" "inspect" "468d9e069017a887814bacd1f84d83c8c7988e9c4e5d23ad4a537fd00c8c74f1"`
[INFO] running `"docker" "rm" "-f" "468d9e069017a887814bacd1f84d83c8c7988e9c4e5d23ad4a537fd00c8c74f1"`
[INFO] [stdout] 468d9e069017a887814bacd1f84d83c8c7988e9c4e5d23ad4a537fd00c8c74f1