[INFO] updating cached repository paritytech/environmental [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paritytech/environmental [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paritytech/environmental" "work/ex/clippy-test-run/sources/stable/gh/paritytech/environmental"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paritytech/environmental'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paritytech/environmental" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paritytech/environmental"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paritytech/environmental'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c31799ea0a672dda7e859f664a4308b1ec24d12e [INFO] sha for GitHub repo paritytech/environmental: c31799ea0a672dda7e859f664a4308b1ec24d12e [INFO] validating manifest of paritytech/environmental on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paritytech/environmental on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paritytech/environmental [INFO] finished frobbing paritytech/environmental [INFO] frobbed toml for paritytech/environmental written to work/ex/clippy-test-run/sources/stable/gh/paritytech/environmental/Cargo.toml [INFO] started frobbing paritytech/environmental [INFO] finished frobbing paritytech/environmental [INFO] frobbed toml for paritytech/environmental written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paritytech/environmental/Cargo.toml [INFO] crate paritytech/environmental has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paritytech/environmental against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paritytech/environmental:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e811b64fc03fbe6d46866325adf6fbac6e0a9d2bd49fb1d2faa7336dc3cab9c6 [INFO] running `"docker" "start" "-a" "e811b64fc03fbe6d46866325adf6fbac6e0a9d2bd49fb1d2faa7336dc3cab9c6"` [INFO] [stderr] Checking environmental v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:344:16 [INFO] [stderr] | [INFO] [stderr] 344 | self.iter().fold(0, |a, c| a + c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:368:16 [INFO] [stderr] | [INFO] [stderr] 368 | self.iter().fold(1, |a, c| a * c) + P::plus42() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:234:6 [INFO] [stderr] | [INFO] [stderr] 234 | $crate::imp::transmute::<&mut $t, &mut ($t<$concretetype> + 'static)>(protected) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(protected as *mut dyn tests::use_generic_trait::Multiplier as *mut (dyn tests::use_generic_trait::Multiplier + 'static))` [INFO] [stderr] ... [INFO] [stderr] 379 | environmental!(foo: trait Multiplier); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "e811b64fc03fbe6d46866325adf6fbac6e0a9d2bd49fb1d2faa7336dc3cab9c6"` [INFO] running `"docker" "rm" "-f" "e811b64fc03fbe6d46866325adf6fbac6e0a9d2bd49fb1d2faa7336dc3cab9c6"` [INFO] [stdout] e811b64fc03fbe6d46866325adf6fbac6e0a9d2bd49fb1d2faa7336dc3cab9c6