[INFO] updating cached repository paq/rust-git-xlsx-textconv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paq/rust-git-xlsx-textconv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paq/rust-git-xlsx-textconv" "work/ex/clippy-test-run/sources/stable/gh/paq/rust-git-xlsx-textconv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paq/rust-git-xlsx-textconv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paq/rust-git-xlsx-textconv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paq/rust-git-xlsx-textconv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paq/rust-git-xlsx-textconv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 167256a7134394894bd11a3de9286ad01f753639 [INFO] sha for GitHub repo paq/rust-git-xlsx-textconv: 167256a7134394894bd11a3de9286ad01f753639 [INFO] validating manifest of paq/rust-git-xlsx-textconv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paq/rust-git-xlsx-textconv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paq/rust-git-xlsx-textconv [INFO] finished frobbing paq/rust-git-xlsx-textconv [INFO] frobbed toml for paq/rust-git-xlsx-textconv written to work/ex/clippy-test-run/sources/stable/gh/paq/rust-git-xlsx-textconv/Cargo.toml [INFO] started frobbing paq/rust-git-xlsx-textconv [INFO] finished frobbing paq/rust-git-xlsx-textconv [INFO] frobbed toml for paq/rust-git-xlsx-textconv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paq/rust-git-xlsx-textconv/Cargo.toml [INFO] crate paq/rust-git-xlsx-textconv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paq/rust-git-xlsx-textconv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paq/rust-git-xlsx-textconv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b48b7a085593a338df25a8da4bd33a82ed9ddeb1a3ad5b3a7ef4878b1ca19acb [INFO] running `"docker" "start" "-a" "b48b7a085593a338df25a8da4bd33a82ed9ddeb1a3ad5b3a7ef4878b1ca19acb"` [INFO] [stderr] Compiling backtrace v0.3.0 [INFO] [stderr] Checking podio v0.1.5 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking quick-xml v0.4.2 [INFO] [stderr] Checking backtrace-sys v0.1.5 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking msdos_time v0.1.4 [INFO] [stderr] Checking error-chain v0.6.2 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking zip v0.2.0 [INFO] [stderr] Checking calamine v0.3.2 [INFO] [stderr] Checking git-xlsx-textconv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / return match *data_type { [INFO] [stderr] 36 | | DataType::Bool(true) => "TRUE".to_string(), [INFO] [stderr] 37 | | DataType::Bool(false) => "FALSE".to_string(), [INFO] [stderr] 38 | | DataType::Int(value) => value.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 53 | | DataType::Empty => "".to_string(), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | match *data_type { [INFO] [stderr] 36 | DataType::Bool(true) => "TRUE".to_string(), [INFO] [stderr] 37 | DataType::Bool(false) => "FALSE".to_string(), [INFO] [stderr] 38 | DataType::Int(value) => value.to_string(), [INFO] [stderr] 39 | DataType::Float(value) => value.to_string(), [INFO] [stderr] 40 | DataType::String(ref value) => value.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | fn textconv(excel_file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / return match *data_type { [INFO] [stderr] 36 | | DataType::Bool(true) => "TRUE".to_string(), [INFO] [stderr] 37 | | DataType::Bool(false) => "FALSE".to_string(), [INFO] [stderr] 38 | | DataType::Int(value) => value.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 53 | | DataType::Empty => "".to_string(), [INFO] [stderr] 54 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | match *data_type { [INFO] [stderr] 36 | DataType::Bool(true) => "TRUE".to_string(), [INFO] [stderr] 37 | DataType::Bool(false) => "FALSE".to_string(), [INFO] [stderr] 38 | DataType::Int(value) => value.to_string(), [INFO] [stderr] 39 | DataType::Float(value) => value.to_string(), [INFO] [stderr] 40 | DataType::String(ref value) => value.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | fn textconv(excel_file_path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.59s [INFO] running `"docker" "inspect" "b48b7a085593a338df25a8da4bd33a82ed9ddeb1a3ad5b3a7ef4878b1ca19acb"` [INFO] running `"docker" "rm" "-f" "b48b7a085593a338df25a8da4bd33a82ed9ddeb1a3ad5b3a7ef4878b1ca19acb"` [INFO] [stdout] b48b7a085593a338df25a8da4bd33a82ed9ddeb1a3ad5b3a7ef4878b1ca19acb