[INFO] updating cached repository panicbit/toy_rpn_calc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/panicbit/toy_rpn_calc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/panicbit/toy_rpn_calc" "work/ex/clippy-test-run/sources/stable/gh/panicbit/toy_rpn_calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/panicbit/toy_rpn_calc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/panicbit/toy_rpn_calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panicbit/toy_rpn_calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panicbit/toy_rpn_calc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d971b5d64b5698c40e12c6eeeb1e8fa7ee3e9b80 [INFO] sha for GitHub repo panicbit/toy_rpn_calc: d971b5d64b5698c40e12c6eeeb1e8fa7ee3e9b80 [INFO] validating manifest of panicbit/toy_rpn_calc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of panicbit/toy_rpn_calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing panicbit/toy_rpn_calc [INFO] finished frobbing panicbit/toy_rpn_calc [INFO] frobbed toml for panicbit/toy_rpn_calc written to work/ex/clippy-test-run/sources/stable/gh/panicbit/toy_rpn_calc/Cargo.toml [INFO] started frobbing panicbit/toy_rpn_calc [INFO] finished frobbing panicbit/toy_rpn_calc [INFO] frobbed toml for panicbit/toy_rpn_calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panicbit/toy_rpn_calc/Cargo.toml [INFO] crate panicbit/toy_rpn_calc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting panicbit/toy_rpn_calc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/panicbit/toy_rpn_calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ded6433c0fa5275a526cced2954727bdaff0501e25a892cb7005c48388bcce17 [INFO] running `"docker" "start" "-a" "ded6433c0fa5275a526cced2954727bdaff0501e25a892cb7005c48388bcce17"` [INFO] [stderr] Checking stackulon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/def.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(match *self { [INFO] [stderr] | ____________^ [INFO] [stderr] 14 | | Def::Value(n) => calc.eval_expr(Expr::Push(n))?, [INFO] [stderr] 15 | | Def::Fn(f) => f(calc)?, [INFO] [stderr] 16 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 13 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Calc` [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | let mut calc = Self { [INFO] [stderr] 21 | | stack: Vec::new(), [INFO] [stderr] 22 | | defs: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 64 | | calc [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/def.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(match *self { [INFO] [stderr] | ____________^ [INFO] [stderr] 14 | | Def::Value(n) => calc.eval_expr(Expr::Push(n))?, [INFO] [stderr] 15 | | Def::Fn(f) => f(calc)?, [INFO] [stderr] 16 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 13 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Calc` [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | let mut calc = Self { [INFO] [stderr] 21 | | stack: Vec::new(), [INFO] [stderr] 22 | | defs: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 64 | | calc [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | calc.def_fn("drop", |calc| Ok(drop(calc.pop()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 25 | calc.def_fn("drop", |calc| Ok(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | calc.def_fn("clear", |calc| Ok(calc.stack.clear())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 26 | calc.def_fn("clear", |calc| Ok(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | calc.def_fn("drop", |calc| Ok(drop(calc.pop()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 25 | calc.def_fn("drop", |calc| Ok(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | calc.def_fn("clear", |calc| Ok(calc.stack.clear())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 26 | calc.def_fn("clear", |calc| Ok(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | Expr::Drop => drop(self.stack.pop()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type std::option::Option [INFO] [stderr] --> src/lib.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | Expr::Drop => drop(self.stack.pop()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | ensure!(self.stack.len() >= 1, "Need at least 1 element"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stackulon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lib.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | Expr::Drop => drop(self.stack.pop()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type std::option::Option [INFO] [stderr] --> src/lib.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | Expr::Drop => drop(self.stack.pop()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | ensure!(self.stack.len() >= 1, "Need at least 1 element"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stackulon`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ded6433c0fa5275a526cced2954727bdaff0501e25a892cb7005c48388bcce17"` [INFO] running `"docker" "rm" "-f" "ded6433c0fa5275a526cced2954727bdaff0501e25a892cb7005c48388bcce17"` [INFO] [stdout] ded6433c0fa5275a526cced2954727bdaff0501e25a892cb7005c48388bcce17