[INFO] updating cached repository paneb-rs/paneb-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paneb-rs/paneb-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paneb-rs/paneb-rs" "work/ex/clippy-test-run/sources/stable/gh/paneb-rs/paneb-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paneb-rs/paneb-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paneb-rs/paneb-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paneb-rs/paneb-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paneb-rs/paneb-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dde36ba28dadb0864f6880d56cfe5e2f571db22d [INFO] sha for GitHub repo paneb-rs/paneb-rs: dde36ba28dadb0864f6880d56cfe5e2f571db22d [INFO] validating manifest of paneb-rs/paneb-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paneb-rs/paneb-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paneb-rs/paneb-rs [INFO] finished frobbing paneb-rs/paneb-rs [INFO] frobbed toml for paneb-rs/paneb-rs written to work/ex/clippy-test-run/sources/stable/gh/paneb-rs/paneb-rs/Cargo.toml [INFO] started frobbing paneb-rs/paneb-rs [INFO] finished frobbing paneb-rs/paneb-rs [INFO] frobbed toml for paneb-rs/paneb-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paneb-rs/paneb-rs/Cargo.toml [INFO] crate paneb-rs/paneb-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting paneb-rs/paneb-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/paneb-rs/paneb-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b1ac93f676c879759414423503c82540ecf67fb5f2da47279b8f7957009bcaa [INFO] running `"docker" "start" "-a" "6b1ac93f676c879759414423503c82540ecf67fb5f2da47279b8f7957009bcaa"` [INFO] [stderr] Checking libc v0.2.38 [INFO] [stderr] Checking num-complex v0.1.42 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking alga v0.5.3 [INFO] [stderr] Checking nalgebra v0.14.0 [INFO] [stderr] Checking paneb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/linear/classification.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let diff = (expected - sign) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(expected - sign)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/linear/classification.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | weights[0] = weights[0] + alpha * diff * 1.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights[0] += alpha * diff * 1.` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/linear/classification.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | weights[index + 1] = weights[index + 1] + alpha * diff * inputs[index] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights[index + 1] += alpha * diff * inputs[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/linear/classification.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | fn classification_sign(weights: &Vec, inputs: &[f64]) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/linear/classification.rs:66:2 [INFO] [stderr] | [INFO] [stderr] 66 | match acc > 0. { [INFO] [stderr] | _____^ [INFO] [stderr] 67 | | true => 1, [INFO] [stderr] 68 | | false => -1 [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if acc > 0. { 1 } else { -1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:58:75 [INFO] [stderr] | [INFO] [stderr] 58 | unsafe fn compute_neurons_output(nb_layers: i32, layers: &[i32], weights: &Vec>, prefixed_inputs: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DMatrix]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:58:112 [INFO] [stderr] | [INFO] [stderr] 58 | unsafe fn compute_neurons_output(nb_layers: i32, layers: &[i32], weights: &Vec>, prefixed_inputs: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/pmc.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | match is_regression == 1 && l == nb_layers - 1 { [INFO] [stderr] | _____________^ [INFO] [stderr] 81 | | true => layer_output.push(result), [INFO] [stderr] 82 | | false => layer_output.push(result.tanh()) [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if is_regression == 1 && l == nb_layers - 1 { layer_output.push(result) } else { layer_output.push(result.tanh()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:93:74 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &Vec>, expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DMatrix]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:93:110 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &Vec>, expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &[Vec], expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `neurons_output.clone()` to [INFO] [stderr] | [INFO] [stderr] 95 | let mut deltas: Vec> = neurons_output.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:93:143 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &Vec>, expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `expected_output` [INFO] [stderr] --> src/pmc.rs:99:11 [INFO] [stderr] | [INFO] [stderr] 99 | for j in 0..nb_neurons as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 99 | for (j, ) in expected_output.iter().enumerate().take(nb_neurons as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pmc.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..layers[layer_index] as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=layers[layer_index] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pmc.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | for j in 1..nb_neurons_next_layer as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=nb_neurons_next_layer as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:130:107 [INFO] [stderr] | [INFO] [stderr] 130 | unsafe fn update_weights(nb_layers: i32, layers: &[i32], weights: &mut Vec>, neurons_output: &Vec>, neurons_delta: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:130:138 [INFO] [stderr] | [INFO] [stderr] 130 | unsafe fn update_weights(nb_layers: i32, layers: &[i32], weights: &mut Vec>, neurons_output: &Vec>, neurons_delta: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/linear/classification.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let diff = (expected - sign) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(expected - sign)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/linear/classification.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | weights[0] = weights[0] + alpha * diff * 1.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights[0] += alpha * diff * 1.` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/linear/classification.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | weights[index + 1] = weights[index + 1] + alpha * diff * inputs[index] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `weights[index + 1] += alpha * diff * inputs[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/linear/classification.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | fn classification_sign(weights: &Vec, inputs: &[f64]) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/linear/classification.rs:66:2 [INFO] [stderr] | [INFO] [stderr] 66 | match acc > 0. { [INFO] [stderr] | _____^ [INFO] [stderr] 67 | | true => 1, [INFO] [stderr] 68 | | false => -1 [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if acc > 0. { 1 } else { -1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:58:75 [INFO] [stderr] | [INFO] [stderr] 58 | unsafe fn compute_neurons_output(nb_layers: i32, layers: &[i32], weights: &Vec>, prefixed_inputs: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DMatrix]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:58:112 [INFO] [stderr] | [INFO] [stderr] 58 | unsafe fn compute_neurons_output(nb_layers: i32, layers: &[i32], weights: &Vec>, prefixed_inputs: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/pmc.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | match is_regression == 1 && l == nb_layers - 1 { [INFO] [stderr] | _____________^ [INFO] [stderr] 81 | | true => layer_output.push(result), [INFO] [stderr] 82 | | false => layer_output.push(result.tanh()) [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if is_regression == 1 && l == nb_layers - 1 { layer_output.push(result) } else { layer_output.push(result.tanh()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:93:74 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &Vec>, expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[DMatrix]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:93:110 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &Vec>, expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &[Vec], expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `neurons_output.clone()` to [INFO] [stderr] | [INFO] [stderr] 95 | let mut deltas: Vec> = neurons_output.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:93:143 [INFO] [stderr] | [INFO] [stderr] 93 | unsafe fn compute_neurons_delta(nb_layers: i32, layers: &[i32], weights: &Vec>, neurons_output: &Vec>, expected_output: &Vec, is_regression: i32) -> Vec> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `expected_output` [INFO] [stderr] --> src/pmc.rs:99:11 [INFO] [stderr] | [INFO] [stderr] 99 | for j in 0..nb_neurons as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 99 | for (j, ) in expected_output.iter().enumerate().take(nb_neurons as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pmc.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..layers[layer_index] as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=layers[layer_index] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pmc.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | for j in 1..nb_neurons_next_layer as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=nb_neurons_next_layer as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:130:107 [INFO] [stderr] | [INFO] [stderr] 130 | unsafe fn update_weights(nb_layers: i32, layers: &[i32], weights: &mut Vec>, neurons_output: &Vec>, neurons_delta: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pmc.rs:130:138 [INFO] [stderr] | [INFO] [stderr] 130 | unsafe fn update_weights(nb_layers: i32, layers: &[i32], weights: &mut Vec>, neurons_output: &Vec>, neurons_delta: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `weights` [INFO] [stderr] --> src/pmc.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | for index in 0..nb_layers as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (index, ) in weights.iter().enumerate().take(nb_layers as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.74s [INFO] running `"docker" "inspect" "6b1ac93f676c879759414423503c82540ecf67fb5f2da47279b8f7957009bcaa"` [INFO] running `"docker" "rm" "-f" "6b1ac93f676c879759414423503c82540ecf67fb5f2da47279b8f7957009bcaa"` [INFO] [stdout] 6b1ac93f676c879759414423503c82540ecf67fb5f2da47279b8f7957009bcaa