[INFO] updating cached repository palfrey/dawn
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/palfrey/dawn
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/palfrey/dawn" "work/ex/clippy-test-run/sources/stable/gh/palfrey/dawn"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/palfrey/dawn'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/palfrey/dawn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/palfrey/dawn"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/palfrey/dawn'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a71059675ac6699364ba33de842cb8eca2c562b5
[INFO] sha for GitHub repo palfrey/dawn: a71059675ac6699364ba33de842cb8eca2c562b5
[INFO] validating manifest of palfrey/dawn on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of palfrey/dawn on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing palfrey/dawn
[INFO] finished frobbing palfrey/dawn
[INFO] frobbed toml for palfrey/dawn written to work/ex/clippy-test-run/sources/stable/gh/palfrey/dawn/Cargo.toml
[INFO] started frobbing palfrey/dawn
[INFO] finished frobbing palfrey/dawn
[INFO] frobbed toml for palfrey/dawn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/palfrey/dawn/Cargo.toml
[INFO] crate palfrey/dawn has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting palfrey/dawn against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/palfrey/dawn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6096c0762f4db958de5a8460a1acf3a9db913d97c6f84a5af403851869deedbe
[INFO] running `"docker" "start" "-a" "6096c0762f4db958de5a8460a1acf3a9db913d97c6f84a5af403851869deedbe"`
[INFO] [stderr]     Checking arc-swap v0.3.6
[INFO] [stderr]    Compiling flate2-crc v0.1.1
[INFO] [stderr]     Checking c_linked_list v1.1.1
[INFO] [stderr]    Compiling ring v0.13.5
[INFO] [stderr]     Checking itertools v0.7.11
[INFO] [stderr]    Compiling crc32fast v1.1.0
[INFO] [stderr]     Checking hostname v0.1.5
[INFO] [stderr]     Checking socket2 v0.3.8
[INFO] [stderr]     Checking thread-id v3.3.0
[INFO] [stderr]     Checking log v0.4.6
[INFO] [stderr]     Checking serde_yaml v0.8.7
[INFO] [stderr]     Checking miniz-sys v0.1.11
[INFO] [stderr]     Checking brotli-sys v0.3.2
[INFO] [stderr]     Checking resolv-conf v0.6.1
[INFO] [stderr]     Checking get_if_addrs v0.5.3
[INFO] [stderr]     Checking signal-hook v0.1.6
[INFO] [stderr]     Checking serde_urlencoded v0.5.4
[INFO] [stderr]     Checking serde-value v0.5.3
[INFO] [stderr]    Compiling synstructure v0.10.1
[INFO] [stderr]    Compiling actix_derive v0.3.2
[INFO] [stderr]     Checking mio v0.6.16
[INFO] [stderr]     Checking tokio-io v0.1.10
[INFO] [stderr]     Checking want v0.0.6
[INFO] [stderr]     Checking log v0.3.9
[INFO] [stderr]     Checking brotli2 v0.3.2
[INFO] [stderr]     Checking mustache v0.8.2
[INFO] [stderr]     Checking flate2 v1.0.5
[INFO] [stderr]     Checking mio-uds v0.6.7
[INFO] [stderr]     Checking libflate v0.1.19
[INFO] [stderr]     Checking tokio-codec v0.1.1
[INFO] [stderr]     Checking h2 v0.1.13
[INFO] [stderr]     Checking tokio-threadpool v0.1.9
[INFO] [stderr]     Checking tokio-reactor v0.1.7
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking log4rs v0.8.1
[INFO] [stderr]     Checking tokio-uds v0.2.4
[INFO] [stderr]     Checking tokio-udp v0.1.3
[INFO] [stderr]     Checking tokio-tcp v0.1.2
[INFO] [stderr]     Checking tokio-signal v0.2.7
[INFO] [stderr]     Checking tokio-fs v0.1.4
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking trust-dns-proto v0.5.0
[INFO] [stderr]     Checking tokio v0.1.13
[INFO] [stderr]     Checking cookie v0.11.0
[INFO] [stderr]     Checking hyper v0.12.16
[INFO] [stderr]     Checking trust-dns-resolver v0.10.0
[INFO] [stderr]     Checking hyper-tls v0.3.1
[INFO] [stderr]     Checking actix v0.7.7
[INFO] [stderr]     Checking reqwest v0.9.5
[INFO] [stderr]     Checking actix-net v0.2.4
[INFO] [stderr]     Checking actix-web v0.7.14
[INFO] [stderr]     Checking dawn v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return Ok(obj);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(obj)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     return App::new()
[INFO] [stderr] 34 | |         .route("/", Method::GET, root_handler)
[INFO] [stderr] 35 | |         .route("/search", Method::GET, search::search_handler)
[INFO] [stderr] 36 | |         .route("/id/{id}", Method::GET, id::id_handler)
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         .route("/favourite-remove", Method::POST, favourite::remove_favourite)
[INFO] [stderr] 41 | |         .route("/arrivals/{stopid}", Method::GET, arrivals::arrivals_handler);
[INFO] [stderr]    | |______________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 33 |     App::new()
[INFO] [stderr] 34 |         .route("/", Method::GET, root_handler)
[INFO] [stderr] 35 |         .route("/search", Method::GET, search::search_handler)
[INFO] [stderr] 36 |         .route("/id/{id}", Method::GET, id::id_handler)
[INFO] [stderr] 37 |         .route("/nearby", Method::GET, nearby::nearby_handler)
[INFO] [stderr] 38 |         .route("/favourites", Method::GET, favourite::list_favourites)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return Ok(obj);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(obj)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     return App::new()
[INFO] [stderr] 34 | |         .route("/", Method::GET, root_handler)
[INFO] [stderr] 35 | |         .route("/search", Method::GET, search::search_handler)
[INFO] [stderr] 36 | |         .route("/id/{id}", Method::GET, id::id_handler)
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         .route("/favourite-remove", Method::POST, favourite::remove_favourite)
[INFO] [stderr] 41 | |         .route("/arrivals/{stopid}", Method::GET, arrivals::arrivals_handler);
[INFO] [stderr]    | |______________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 33 |     App::new()
[INFO] [stderr] 34 |         .route("/", Method::GET, root_handler)
[INFO] [stderr] 35 |         .route("/search", Method::GET, search::search_handler)
[INFO] [stderr] 36 |         .route("/id/{id}", Method::GET, id::id_handler)
[INFO] [stderr] 37 |         .route("/nearby", Method::GET, nearby::nearby_handler)
[INFO] [stderr] 38 |         .route("/favourites", Method::GET, favourite::list_favourites)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/arrivals.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if member_slice.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `member_slice.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/arrivals.rs:71:50
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     let lf = line_filter.clone().unwrap_or(String::from(""));
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/arrivals.rs:81:34
[INFO] [stderr]    |
[INFO] [stderr] 81 |                                 .expect(&format!("strptime: {}", expected_arrival));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("strptime: {}", expected_arrival))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/common.rs:8:26
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn json_for_url(url: &String) -> Result<json::JsonValue, String> {
[INFO] [stderr]   |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/id.rs:21:42
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let direct_name = query.name.clone().unwrap_or(String::from(""));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/id.rs:26:30
[INFO] [stderr]    |
[INFO] [stderr] 26 |               for naptan_id in obj["lineGroup"]
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 27 | |                 .members()
[INFO] [stderr] 28 | |                 .into_iter()
[INFO] [stderr]    | |____________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 26 |             for naptan_id in obj["lineGroup"]
[INFO] [stderr] 27 |                 .members()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:47:10
[INFO] [stderr]    |
[INFO] [stderr] 47 |         .unwrap_or("8000".to_string())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "8000".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/arrivals.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if member_slice.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `member_slice.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/arrivals.rs:71:50
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     let lf = line_filter.clone().unwrap_or(String::from(""));
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/arrivals.rs:81:34
[INFO] [stderr]    |
[INFO] [stderr] 81 |                                 .expect(&format!("strptime: {}", expected_arrival));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("strptime: {}", expected_arrival))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/common.rs:8:26
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn json_for_url(url: &String) -> Result<json::JsonValue, String> {
[INFO] [stderr]   |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/id.rs:21:42
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let direct_name = query.name.clone().unwrap_or(String::from(""));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/id.rs:26:30
[INFO] [stderr]    |
[INFO] [stderr] 26 |               for naptan_id in obj["lineGroup"]
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 27 | |                 .members()
[INFO] [stderr] 28 | |                 .into_iter()
[INFO] [stderr]    | |____________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 26 |             for naptan_id in obj["lineGroup"]
[INFO] [stderr] 27 |                 .members()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:47:10
[INFO] [stderr]    |
[INFO] [stderr] 47 |         .unwrap_or("8000".to_string())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "8000".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 12s
[INFO] running `"docker" "inspect" "6096c0762f4db958de5a8460a1acf3a9db913d97c6f84a5af403851869deedbe"`
[INFO] running `"docker" "rm" "-f" "6096c0762f4db958de5a8460a1acf3a9db913d97c6f84a5af403851869deedbe"`
[INFO] [stdout] 6096c0762f4db958de5a8460a1acf3a9db913d97c6f84a5af403851869deedbe