[INFO] updating cached repository pajlada/pajbot2-points [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pajlada/pajbot2-points [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pajlada/pajbot2-points" "work/ex/clippy-test-run/sources/stable/gh/pajlada/pajbot2-points"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pajlada/pajbot2-points'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pajlada/pajbot2-points" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pajlada/pajbot2-points"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pajlada/pajbot2-points'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 70b49fbbe192371efa51b972611f28b4bb1847ec [INFO] sha for GitHub repo pajlada/pajbot2-points: 70b49fbbe192371efa51b972611f28b4bb1847ec [INFO] validating manifest of pajlada/pajbot2-points on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pajlada/pajbot2-points on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pajlada/pajbot2-points [INFO] finished frobbing pajlada/pajbot2-points [INFO] frobbed toml for pajlada/pajbot2-points written to work/ex/clippy-test-run/sources/stable/gh/pajlada/pajbot2-points/Cargo.toml [INFO] started frobbing pajlada/pajbot2-points [INFO] finished frobbing pajlada/pajbot2-points [INFO] frobbed toml for pajlada/pajbot2-points written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pajlada/pajbot2-points/Cargo.toml [INFO] crate pajlada/pajbot2-points has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pajlada/pajbot2-points against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pajlada/pajbot2-points:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc98f7b774571d19a586b10aee605f287a0958bb7af765bfb4dcaa6caa389103 [INFO] running `"docker" "start" "-a" "cc98f7b774571d19a586b10aee605f287a0958bb7af765bfb4dcaa6caa389103"` [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Checking pajbot2-points v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | channel_name: channel_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | user_ids: user_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `user_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | channel_name: channel_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | user_ids: user_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `user_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/custom_error.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return WrongCommand { [INFO] [stderr] 14 | | received_command: a, [INFO] [stderr] 15 | | expected_command: b, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | WrongCommand { [INFO] [stderr] 14 | received_command: a, [INFO] [stderr] 15 | expected_command: b, [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/custom_error.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | MyError::IoError(e) => return fmt::Display::fmt(e, f), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fmt::Display::fmt(e, f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/custom_error.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | MyError::RecvError(e) => return fmt::Display::fmt(e, f), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fmt::Display::fmt(e, f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return String::from_utf8(user_id_buf.to_vec()).map_err(|e| MyError::ParseError(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(user_id_buf.to_vec()).map_err(|e| MyError::ParseError(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return Ok(user_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(user_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / return ((buffer[0] as i32) << 24) [INFO] [stderr] 14 | | + ((buffer[1] as i32) << 16) [INFO] [stderr] 15 | | + ((buffer[2] as i32) << 8) [INFO] [stderr] 16 | | + (buffer[3] as i32); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | ((buffer[0] as i32) << 24) [INFO] [stderr] 14 | + ((buffer[1] as i32) << 16) [INFO] [stderr] 15 | + ((buffer[2] as i32) << 8) [INFO] [stderr] 16 | + (buffer[3] as i32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / return ((buffer[0] as u32) << 24) [INFO] [stderr] 44 | | + ((buffer[1] as u32) << 16) [INFO] [stderr] 45 | | + ((buffer[2] as u32) << 8) [INFO] [stderr] 46 | | + (buffer[3] as u32); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 43 | ((buffer[0] as u32) << 24) [INFO] [stderr] 44 | + ((buffer[1] as u32) << 16) [INFO] [stderr] 45 | + ((buffer[2] as u32) << 8) [INFO] [stderr] 46 | + (buffer[3] as u32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / return Ok(Client { [INFO] [stderr] 91 | | stream: stream, [INFO] [stderr] 92 | | channel_name: channel_name, [INFO] [stderr] 93 | | request_sender: sender, [INFO] [stderr] 94 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 90 | Ok(Client { [INFO] [stderr] 91 | stream: stream, [INFO] [stderr] 92 | channel_name: channel_name, [INFO] [stderr] 93 | request_sender: sender, [INFO] [stderr] 94 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return Ok(Some(u64_to_buf(points).to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(u64_to_buf(points).to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | return Ok(Some(response)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(response))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | return Ok(Some(response)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(response))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(Some(u64_to_buf(user_rank).to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(u64_to_buf(user_rank).to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return ChannelPoints { [INFO] [stderr] 34 | | path: path.to_string(), [INFO] [stderr] 35 | | user_id_to_rank: HashMap::new(), [INFO] [stderr] 36 | | ranks: Vec::new(), [INFO] [stderr] 37 | | receiver: None, [INFO] [stderr] 38 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | ChannelPoints { [INFO] [stderr] 34 | path: path.to_string(), [INFO] [stderr] 35 | user_id_to_rank: HashMap::new(), [INFO] [stderr] 36 | ranks: Vec::new(), [INFO] [stderr] 37 | receiver: None, [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(ChannelPoints::new(path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChannelPoints::new(path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(ChannelPoints::new(path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChannelPoints::new(path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(m); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return self.get_points(user_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_points(user_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return 420; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `420` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return *user_points; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*user_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | / return Points { [INFO] [stderr] 256 | | channels: HashMap::new(), [INFO] [stderr] 257 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 255 | Points { [INFO] [stderr] 256 | channels: HashMap::new(), [INFO] [stderr] 257 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/custom_error.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return WrongCommand { [INFO] [stderr] 14 | | received_command: a, [INFO] [stderr] 15 | | expected_command: b, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | WrongCommand { [INFO] [stderr] 14 | received_command: a, [INFO] [stderr] 15 | expected_command: b, [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/custom_error.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | MyError::IoError(e) => return fmt::Display::fmt(e, f), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fmt::Display::fmt(e, f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/custom_error.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | MyError::RecvError(e) => return fmt::Display::fmt(e, f), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fmt::Display::fmt(e, f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return String::from_utf8(user_id_buf.to_vec()).map_err(|e| MyError::ParseError(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(user_id_buf.to_vec()).map_err(|e| MyError::ParseError(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return Ok(user_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(user_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / return ((buffer[0] as i32) << 24) [INFO] [stderr] 14 | | + ((buffer[1] as i32) << 16) [INFO] [stderr] 15 | | + ((buffer[2] as i32) << 8) [INFO] [stderr] 16 | | + (buffer[3] as i32); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | ((buffer[0] as i32) << 24) [INFO] [stderr] 14 | + ((buffer[1] as i32) << 16) [INFO] [stderr] 15 | + ((buffer[2] as i32) << 8) [INFO] [stderr] 16 | + (buffer[3] as i32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / return ((buffer[0] as u32) << 24) [INFO] [stderr] 44 | | + ((buffer[1] as u32) << 16) [INFO] [stderr] 45 | | + ((buffer[2] as u32) << 8) [INFO] [stderr] 46 | | + (buffer[3] as u32); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 43 | ((buffer[0] as u32) << 24) [INFO] [stderr] 44 | + ((buffer[1] as u32) << 16) [INFO] [stderr] 45 | + ((buffer[2] as u32) << 8) [INFO] [stderr] 46 | + (buffer[3] as u32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | / return Ok(Client { [INFO] [stderr] 91 | | stream: stream, [INFO] [stderr] 92 | | channel_name: channel_name, [INFO] [stderr] 93 | | request_sender: sender, [INFO] [stderr] 94 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 90 | Ok(Client { [INFO] [stderr] 91 | stream: stream, [INFO] [stderr] 92 | channel_name: channel_name, [INFO] [stderr] 93 | request_sender: sender, [INFO] [stderr] 94 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return Ok(Some(u64_to_buf(points).to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(u64_to_buf(points).to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | return Ok(Some(response)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(response))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | return Ok(Some(response)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(response))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(Some(u64_to_buf(user_rank).to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(u64_to_buf(user_rank).to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return ChannelPoints { [INFO] [stderr] 34 | | path: path.to_string(), [INFO] [stderr] 35 | | user_id_to_rank: HashMap::new(), [INFO] [stderr] 36 | | ranks: Vec::new(), [INFO] [stderr] 37 | | receiver: None, [INFO] [stderr] 38 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | ChannelPoints { [INFO] [stderr] 34 | path: path.to_string(), [INFO] [stderr] 35 | user_id_to_rank: HashMap::new(), [INFO] [stderr] 36 | ranks: Vec::new(), [INFO] [stderr] 37 | receiver: None, [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Ok(ChannelPoints::new(path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChannelPoints::new(path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(ChannelPoints::new(path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChannelPoints::new(path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(m); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return self.get_points(user_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_points(user_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return 420; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `420` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return *user_points; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*user_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | / return Points { [INFO] [stderr] 256 | | channels: HashMap::new(), [INFO] [stderr] 257 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 255 | Points { [INFO] [stderr] 256 | channels: HashMap::new(), [INFO] [stderr] 257 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/points.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `user_id` [INFO] [stderr] --> src/points.rs:107:29 [INFO] [stderr] | [INFO] [stderr] 107 | fn remove_points(&self, user_id: String, points: u64) -> u64 { [INFO] [stderr] | ^^^^^^^ help: consider using `_user_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `points` [INFO] [stderr] --> src/points.rs:107:46 [INFO] [stderr] | [INFO] [stderr] 107 | fn remove_points(&self, user_id: String, points: u64) -> u64 { [INFO] [stderr] | ^^^^^^ help: consider using `_points` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rank` [INFO] [stderr] --> src/points.rs:155:34 [INFO] [stderr] | [INFO] [stderr] 155 | Some(rank) => { [INFO] [stderr] | ^^^^ help: consider using `_rank` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/points.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | Edit(c) => { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/points.rs:194:26 [INFO] [stderr] | [INFO] [stderr] 194 | Rank(c) => { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sender` [INFO] [stderr] --> src/points.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | Quit(sender) => { [INFO] [stderr] | ^^^^^^ help: consider using `_sender` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `user_id` [INFO] [stderr] --> src/points.rs:107:29 [INFO] [stderr] | [INFO] [stderr] 107 | fn remove_points(&self, user_id: String, points: u64) -> u64 { [INFO] [stderr] | ^^^^^^^ help: consider using `_user_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `points` [INFO] [stderr] --> src/points.rs:107:46 [INFO] [stderr] | [INFO] [stderr] 107 | fn remove_points(&self, user_id: String, points: u64) -> u64 { [INFO] [stderr] | ^^^^^^ help: consider using `_points` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rank` [INFO] [stderr] --> src/points.rs:155:34 [INFO] [stderr] | [INFO] [stderr] 155 | Some(rank) => { [INFO] [stderr] | ^^^^ help: consider using `_rank` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/points.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | Edit(c) => { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/points.rs:194:26 [INFO] [stderr] | [INFO] [stderr] 194 | Rank(c) => { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sender` [INFO] [stderr] --> src/points.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | Quit(sender) => { [INFO] [stderr] | ^^^^^^ help: consider using `_sender` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/points.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let mut res = self.ranks.get_mut(*user_rank as usize); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `save` [INFO] [stderr] --> src/points.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn save(&self) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/points.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let mut res = self.ranks.get_mut(*user_rank as usize); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | .map_err(|e| MyError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::IoError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:16:60 [INFO] [stderr] | [INFO] [stderr] 16 | return String::from_utf8(user_id_buf.to_vec()).map_err(|e| MyError::ParseError(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | .map_err(|e| MyError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | .map_err(|e| MyError::ParseError(e))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: method is never used: `save` [INFO] [stderr] --> src/points.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn save(&self) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | .map_err(|e| MyError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::IoError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:16:60 [INFO] [stderr] | [INFO] [stderr] 16 | return String::from_utf8(user_id_buf.to_vec()).map_err(|e| MyError::ParseError(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | return ((buffer[0] as i32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | + ((buffer[1] as i32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | + ((buffer[2] as i32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | + (buffer[3] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:29:22 [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] 29 | .map_err(|e| MyError::IoError(e))?; [INFO] [stderr] --> src/utils.rs:43:13 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::IoError` [INFO] [stderr] | [INFO] [stderr] 43 | return ((buffer[0] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | + ((buffer[1] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | + ((buffer[2] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:46:11 [INFO] [stderr] | [INFO] [stderr] 46 | + (buffer[3] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | .map_err(|e| MyError::ParseError(e))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let result = ((buffer[0] as u64) << 56) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | + ((buffer[1] as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | + ((buffer[2] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | + ((buffer[3] as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | + ((buffer[4] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | + ((buffer[5] as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | + ((buffer[6] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | + (buffer[7] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | return ((buffer[0] as i32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | + ((buffer[1] as i32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | + ((buffer[2] as i32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | + (buffer[3] as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return ((buffer[0] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | + ((buffer[1] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | + ((buffer[2] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:46:11 [INFO] [stderr] | [INFO] [stderr] 46 | + (buffer[3] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let result = ((buffer[0] as u64) << 56) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | + ((buffer[1] as u64) << 48) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | + ((buffer[2] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | + ((buffer[3] as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | + ((buffer[4] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | + ((buffer[5] as u64) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | + ((buffer[6] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | + (buffer[7] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(buffer[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:88:64 [INFO] [stderr] | [INFO] [stderr] 88 | let channel_name = String::from_utf8(body_buf).map_err(|e| MyError::ParseError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:88:64 [INFO] [stderr] | [INFO] [stderr] 88 | let channel_name = String::from_utf8(body_buf).map_err(|e| MyError::ParseError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match self.handle_command() { [INFO] [stderr] 101 | | Err(e) => { [INFO] [stderr] 102 | | // Something that went wrong, went wrong. [INFO] [stderr] 103 | | // If we can recover from the error, or tell the client that something went [INFO] [stderr] ... | [INFO] [stderr] 110 | | Ok(_) => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Err(e) = self.handle_command() { [INFO] [stderr] 101 | // Something that went wrong, went wrong. [INFO] [stderr] 102 | // If we can recover from the error, or tell the client that something went [INFO] [stderr] 103 | // wrong, we should probably do that. [INFO] [stderr] 104 | // For now, disconnecting and letting the client reconnect is probably the best [INFO] [stderr] 105 | // thing [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match self.handle_command() { [INFO] [stderr] 101 | | Err(e) => { [INFO] [stderr] 102 | | // Something that went wrong, went wrong. [INFO] [stderr] 103 | | // If we can recover from the error, or tell the client that something went [INFO] [stderr] ... | [INFO] [stderr] 110 | | Ok(_) => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Err(e) = self.handle_command() { [INFO] [stderr] 101 | // Something that went wrong, went wrong. [INFO] [stderr] 102 | // If we can recover from the error, or tell the client that something went [INFO] [stderr] 103 | // wrong, we should probably do that. [INFO] [stderr] 104 | // For now, disconnecting and letting the client reconnect is probably the best [INFO] [stderr] 105 | // thing [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | .map_err(|e| MyError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:163:46 [INFO] [stderr] | [INFO] [stderr] 163 | let points = receiver.recv().map_err(|e| MyError::RecvError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::RecvError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | .map_err(|e| MyError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::IoError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:163:46 [INFO] [stderr] | [INFO] [stderr] 163 | let points = receiver.recv().map_err(|e| MyError::RecvError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyError::RecvError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/client.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let force = if buffer[0] == 0x01 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `buffer[0] == 0x01` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/client.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let force = if buffer[0] == 0x01 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `buffer[0] == 0x01` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/points.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | file.write(&mut buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/points.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | file.write(&mut buf)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/points.rs:299:34 [INFO] [stderr] | [INFO] [stderr] 299 | for (channel_name, _) in &self.channels { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 299 | for channel_name in self.channels.keys() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/points.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | file.write(&mut buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/points.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | file.write(&mut buf)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pajbot2-points`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/points.rs:299:34 [INFO] [stderr] | [INFO] [stderr] 299 | for (channel_name, _) in &self.channels { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 299 | for channel_name in self.channels.keys() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pajbot2-points`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cc98f7b774571d19a586b10aee605f287a0958bb7af765bfb4dcaa6caa389103"` [INFO] running `"docker" "rm" "-f" "cc98f7b774571d19a586b10aee605f287a0958bb7af765bfb4dcaa6caa389103"` [INFO] [stdout] cc98f7b774571d19a586b10aee605f287a0958bb7af765bfb4dcaa6caa389103