[INFO] updating cached repository pacman82/cellular-automaton [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pacman82/cellular-automaton [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pacman82/cellular-automaton" "work/ex/clippy-test-run/sources/stable/gh/pacman82/cellular-automaton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pacman82/cellular-automaton'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pacman82/cellular-automaton" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacman82/cellular-automaton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacman82/cellular-automaton'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2971c2066d7614ffd6305cd5e640060db18a2f6c [INFO] sha for GitHub repo pacman82/cellular-automaton: 2971c2066d7614ffd6305cd5e640060db18a2f6c [INFO] validating manifest of pacman82/cellular-automaton on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pacman82/cellular-automaton on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pacman82/cellular-automaton [INFO] finished frobbing pacman82/cellular-automaton [INFO] frobbed toml for pacman82/cellular-automaton written to work/ex/clippy-test-run/sources/stable/gh/pacman82/cellular-automaton/Cargo.toml [INFO] started frobbing pacman82/cellular-automaton [INFO] finished frobbing pacman82/cellular-automaton [INFO] frobbed toml for pacman82/cellular-automaton written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacman82/cellular-automaton/Cargo.toml [INFO] crate pacman82/cellular-automaton has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pacman82/cellular-automaton against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pacman82/cellular-automaton:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4947fb787fced0cefc70ab9ca641c2ed18a51812b026053f86a6c3cb6ebc46d [INFO] running `"docker" "start" "-a" "b4947fb787fced0cefc70ab9ca641c2ed18a51812b026053f86a6c3cb6ebc46d"` [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking rule v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rule` [INFO] [stderr] --> src/main.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for (i, ) in rule.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:67:60 [INFO] [stderr] | [INFO] [stderr] 67 | fn apply_rules(previous: &[Cell], next: &mut [Cell], rule: &[Cell; 8]) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `[Cell; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | fn apply_rule(neighbours: [Cell; 3], rule: &[Cell; 8]) -> Cell { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `[Cell; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rule` [INFO] [stderr] --> src/main.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for (i, ) in rule.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:67:60 [INFO] [stderr] | [INFO] [stderr] 67 | fn apply_rules(previous: &[Cell], next: &mut [Cell], rule: &[Cell; 8]) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `[Cell; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | fn apply_rule(neighbours: [Cell; 3], rule: &[Cell; 8]) -> Cell { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `[Cell; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.27s [INFO] running `"docker" "inspect" "b4947fb787fced0cefc70ab9ca641c2ed18a51812b026053f86a6c3cb6ebc46d"` [INFO] running `"docker" "rm" "-f" "b4947fb787fced0cefc70ab9ca641c2ed18a51812b026053f86a6c3cb6ebc46d"` [INFO] [stdout] b4947fb787fced0cefc70ab9ca641c2ed18a51812b026053f86a6c3cb6ebc46d