[INFO] updating cached repository p404/boleta [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/p404/boleta [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/p404/boleta" "work/ex/clippy-test-run/sources/stable/gh/p404/boleta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/p404/boleta'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/p404/boleta" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p404/boleta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p404/boleta'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e41b2ef1ac2412f7f8c6f1c761d3d9e79075911 [INFO] sha for GitHub repo p404/boleta: 7e41b2ef1ac2412f7f8c6f1c761d3d9e79075911 [INFO] validating manifest of p404/boleta on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of p404/boleta on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing p404/boleta [INFO] finished frobbing p404/boleta [INFO] frobbed toml for p404/boleta written to work/ex/clippy-test-run/sources/stable/gh/p404/boleta/Cargo.toml [INFO] started frobbing p404/boleta [INFO] finished frobbing p404/boleta [INFO] frobbed toml for p404/boleta written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p404/boleta/Cargo.toml [INFO] crate p404/boleta has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting p404/boleta against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/p404/boleta:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc8febf0e8b3aefe70260b4c315ca5b909ed82b972a00f313513d24156380c9b [INFO] running `"docker" "start" "-a" "bc8febf0e8b3aefe70260b4c315ca5b909ed82b972a00f313513d24156380c9b"` [INFO] [stderr] Checking openssl-probe v0.1.0 [INFO] [stderr] Checking text_io v0.1.6 [INFO] [stderr] Compiling libz-sys v1.0.13 [INFO] [stderr] Compiling openssl-sys v0.9.7 [INFO] [stderr] Compiling curl-sys v0.3.10 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.7.2 [INFO] [stderr] Checking curl v0.4.6 [INFO] [stderr] Checking curl-easybuilder v0.1.0 [INFO] [stderr] Checking boleta v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/configuration.rs:12:42 [INFO] [stderr] | [INFO] [stderr] 12 | "Y" | "y" | "yes" | "YES" => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/configuration.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/invoice.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `year % 4 == 0 && (year % 100 != 0 || year % 400 == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/configuration.rs:12:42 [INFO] [stderr] | [INFO] [stderr] 12 | "Y" | "y" | "yes" | "YES" => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/configuration.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/invoice.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return year % 4 == 0 && (year % 100 != 0 || year % 400 == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `year % 4 == 0 && (year % 100 != 0 || year % 400 == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 73 [INFO] [stderr] --> src/configuration.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn configuration_bootstrap(path: &Path) { [INFO] [stderr] 18 | | println!("From: (e.g. John Doe)"); [INFO] [stderr] 19 | | let from: String = read!("{}\n"); [INFO] [stderr] 20 | | [INFO] [stderr] ... | [INFO] [stderr] 52 | | configuration_file.write_all(data.as_bytes()).unwrap(); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/configuration.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if confirmation() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `confirmation()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/invoice.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match configuration_file.read_to_string(&mut configuration_file_string) { [INFO] [stderr] 33 | | Err(_) => panic!("Couldn't read configuration file"), [INFO] [stderr] 34 | | Ok(_) => (), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = configuration_file.read_to_string(&mut configuration_file_string) { panic!("Couldn't read configuration file") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/invoice.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | Err(_) => panic!("Couldn't read configuration file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 73 [INFO] [stderr] --> src/configuration.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn configuration_bootstrap(path: &Path) { [INFO] [stderr] 18 | | println!("From: (e.g. John Doe)"); [INFO] [stderr] 19 | | let from: String = read!("{}\n"); [INFO] [stderr] 20 | | [INFO] [stderr] ... | [INFO] [stderr] 52 | | configuration_file.write_all(data.as_bytes()).unwrap(); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/configuration.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if confirmation() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `confirmation()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/invoice.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match configuration_file.read_to_string(&mut configuration_file_string) { [INFO] [stderr] 33 | | Err(_) => panic!("Couldn't read configuration file"), [INFO] [stderr] 34 | | Ok(_) => (), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = configuration_file.read_to_string(&mut configuration_file_string) { panic!("Couldn't read configuration file") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/invoice.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | Err(_) => panic!("Couldn't read configuration file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 10s [INFO] running `"docker" "inspect" "bc8febf0e8b3aefe70260b4c315ca5b909ed82b972a00f313513d24156380c9b"` [INFO] running `"docker" "rm" "-f" "bc8febf0e8b3aefe70260b4c315ca5b909ed82b972a00f313513d24156380c9b"` [INFO] [stdout] bc8febf0e8b3aefe70260b4c315ca5b909ed82b972a00f313513d24156380c9b