[INFO] updating cached repository oxidizers/drdns [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/oxidizers/drdns [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/oxidizers/drdns" "work/ex/clippy-test-run/sources/stable/gh/oxidizers/drdns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/oxidizers/drdns'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/oxidizers/drdns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oxidizers/drdns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oxidizers/drdns'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98c1153a09642c2a5d8d2ed77ef7d9429d94995a [INFO] sha for GitHub repo oxidizers/drdns: 98c1153a09642c2a5d8d2ed77ef7d9429d94995a [INFO] validating manifest of oxidizers/drdns on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oxidizers/drdns on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oxidizers/drdns [INFO] finished frobbing oxidizers/drdns [INFO] frobbed toml for oxidizers/drdns written to work/ex/clippy-test-run/sources/stable/gh/oxidizers/drdns/Cargo.toml [INFO] started frobbing oxidizers/drdns [INFO] finished frobbing oxidizers/drdns [INFO] frobbed toml for oxidizers/drdns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/oxidizers/drdns/Cargo.toml [INFO] crate oxidizers/drdns has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oxidizers/drdns against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/oxidizers/drdns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 747d428030ffc8479bef6345b763ecad7a4d6ea2526248d2acea10efdacbfed1 [INFO] running `"docker" "start" "-a" "747d428030ffc8479bef6345b763ecad7a4d6ea2526248d2acea10efdacbfed1"` [INFO] [stderr] Checking errno v0.2.3 [INFO] [stderr] Checking drdns v0.0.0 (/opt/crater/workdir) [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | if cachesize > 1000000000u32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000u32` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | cachesize = 1000000000u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | if d > 604800i32 as (f64) { [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | d = 604800i32 as (f64); [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | } else if datalen > 1000000u32 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | if ttl > 604800u32 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | ttl = 604800u32; [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: module has the same name as its containing module [INFO] [stderr] --> src/cdb/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | mod cdb; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::module_inception)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/cdb/cdb.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / if libc::fstat(fd, &mut st as (*mut libc::stat)) == 0i32 { [INFO] [stderr] 51 | | if st.st_size as (usize) <= 0xffffffffusize { [INFO] [stderr] 52 | | x = libc::mmap( [INFO] [stderr] 53 | | 0 as *mut libc::c_void, [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | if libc::fstat(fd, &mut st as (*mut libc::stat)) == 0i32 && st.st_size as (usize) <= 0xffffffffusize { [INFO] [stderr] 51 | x = libc::mmap( [INFO] [stderr] 52 | 0 as *mut libc::c_void, [INFO] [stderr] 53 | st.st_size as (usize), [INFO] [stderr] 54 | 0x1, [INFO] [stderr] 55 | 0x1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cdb/cdb.rs:51:41 [INFO] [stderr] | [INFO] [stderr] 51 | if st.st_size as (usize) <= 0xffffffffusize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0xffff_ffffusize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/ip4.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | / if byte::diff( [INFO] [stderr] 55 | | header.as_mut_ptr(), [INFO] [stderr] 56 | | 2u32, [INFO] [stderr] 57 | | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | if byte::diff( [INFO] [stderr] 55 | header.as_mut_ptr(), [INFO] [stderr] 56 | 2u32, [INFO] [stderr] 57 | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] 58 | ) == 0 && byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/ip4.rs:60:27 [INFO] [stderr] | [INFO] [stderr] 60 | / if byte::diff( [INFO] [stderr] 61 | | header.as_mut_ptr().offset(2isize), [INFO] [stderr] 62 | | 2u32, [INFO] [stderr] 63 | | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if byte::diff( [INFO] [stderr] 61 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] 62 | 2u32, [INFO] [stderr] 63 | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] 64 | ) == 0 && datalen as (i32) == 4i32 { [INFO] [stderr] 65 | if packet::copy(buf, len, pos, header.as_mut_ptr(), 4u32) == 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/mx.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | / if byte::diff( [INFO] [stderr] 59 | | header.as_mut_ptr(), [INFO] [stderr] 60 | | 2u32, [INFO] [stderr] 61 | | (*b"\0\x0F\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | if byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr(), [INFO] [stderr] 60 | 2u32, [INFO] [stderr] 61 | (*b"\0\x0F\0").as_ptr() as (*mut u8), [INFO] [stderr] 62 | ) == 0 && byte::diff( [INFO] [stderr] 63 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/name.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | / if byte::diff( [INFO] [stderr] 59 | | header.as_mut_ptr(), [INFO] [stderr] 60 | | 2u32, [INFO] [stderr] 61 | | (*b"\0\x0C\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | if byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr(), [INFO] [stderr] 60 | 2u32, [INFO] [stderr] 61 | (*b"\0\x0C\0").as_ptr() as (*mut u8), [INFO] [stderr] 62 | ) == 0 && byte::diff( [INFO] [stderr] 63 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/random.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / if { [INFO] [stderr] 53 | | let _rhs = 1; [INFO] [stderr] 54 | | let _lhs = &mut IN[0usize]; [INFO] [stderr] 55 | | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | if { [INFO] [stderr] 53 | let _rhs = 1; [INFO] [stderr] 54 | let _lhs = &mut IN[0usize]; [INFO] [stderr] 55 | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] 56 | *_lhs [INFO] [stderr] 57 | } == 0 && { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/random.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / if { [INFO] [stderr] 60 | | let _rhs = 1; [INFO] [stderr] 61 | | let _lhs = &mut IN[1usize]; [INFO] [stderr] 62 | | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if { [INFO] [stderr] 60 | let _rhs = 1; [INFO] [stderr] 61 | let _lhs = &mut IN[1usize]; [INFO] [stderr] 62 | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] 63 | *_lhs [INFO] [stderr] 64 | } == 0 && { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/dns/random.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 124 | sum = sum.wrapping_add(0x9e3779b9u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x9e37_79b9u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:126:80 [INFO] [stderr] | [INFO] [stderr] 126 | let _rhs = (x ^ SEED[0usize]).wrapping_add(sum) ^ (x << 5i32 | x >> 32i32 - 5i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::precedence)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:132:80 [INFO] [stderr] | [INFO] [stderr] 132 | let _rhs = (x ^ SEED[1usize]).wrapping_add(sum) ^ (x << 7i32 | x >> 32i32 - 7i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:138:80 [INFO] [stderr] | [INFO] [stderr] 138 | let _rhs = (x ^ SEED[2usize]).wrapping_add(sum) ^ (x << 9i32 | x >> 32i32 - 9i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 9i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:144:81 [INFO] [stderr] | [INFO] [stderr] 144 | let _rhs = (x ^ SEED[3usize]).wrapping_add(sum) ^ (x << 13i32 | x >> 32i32 - 13i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 13i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:150:80 [INFO] [stderr] | [INFO] [stderr] 150 | let _rhs = (x ^ SEED[4usize]).wrapping_add(sum) ^ (x << 5i32 | x >> 32i32 - 5i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:156:80 [INFO] [stderr] | [INFO] [stderr] 156 | let _rhs = (x ^ SEED[5usize]).wrapping_add(sum) ^ (x << 7i32 | x >> 32i32 - 7i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:162:80 [INFO] [stderr] | [INFO] [stderr] 162 | let _rhs = (x ^ SEED[6usize]).wrapping_add(sum) ^ (x << 9i32 | x >> 32i32 - 9i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 9i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:168:81 [INFO] [stderr] | [INFO] [stderr] 168 | let _rhs = (x ^ SEED[7usize]).wrapping_add(sum) ^ (x << 13i32 | x >> 32i32 - 13i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 13i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:174:80 [INFO] [stderr] | [INFO] [stderr] 174 | let _rhs = (x ^ SEED[8usize]).wrapping_add(sum) ^ (x << 5i32 | x >> 32i32 - 5i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:180:80 [INFO] [stderr] | [INFO] [stderr] 180 | let _rhs = (x ^ SEED[9usize]).wrapping_add(sum) ^ (x << 7i32 | x >> 32i32 - 7i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:186:81 [INFO] [stderr] | [INFO] [stderr] 186 | let _rhs = (x ^ SEED[10usize]).wrapping_add(sum) ^ (x << 9i32 | x >> 32i32 - 9i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 9i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | (x << 13i32 | x >> 32i32 - 13i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 13i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/rcip.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | / if iplen <= 60i32 { [INFO] [stderr] 139 | | if ip4::scan( [INFO] [stderr] 140 | | DATA.s.offset(i as (isize)) as (*const u8), [INFO] [stderr] 141 | | ip.offset(iplen as (isize)), [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if iplen <= 60i32 && ip4::scan( [INFO] [stderr] 139 | DATA.s.offset(i as (isize)) as (*const u8), [INFO] [stderr] 140 | ip.offset(iplen as (isize)), [INFO] [stderr] 141 | ) != 0 { [INFO] [stderr] 142 | if byte::diff( [INFO] [stderr] 143 | ip.offset(iplen as (isize)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/rcrw.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | / if *(*rules).s.offset( [INFO] [stderr] 111 | | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 112 | | ) as (i32) != b' ' as (i32) [INFO] [stderr] 113 | | { [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | if *(*rules).s.offset( [INFO] [stderr] 111 | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 112 | ) as (i32) != b' ' as (i32) && *(*rules).s.offset( [INFO] [stderr] 113 | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 114 | ) as (i32) != b'\t' as (i32) { [INFO] [stderr] 115 | if *(*rules).s.offset( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/rcrw.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | / if *(*rules).s.offset( [INFO] [stderr] 115 | | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 116 | | ) as (i32) != b'\t' as (i32) [INFO] [stderr] 117 | | { [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | if *(*rules).s.offset( [INFO] [stderr] 115 | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 116 | ) as (i32) != b'\t' as (i32) && *(*rules).s.offset( [INFO] [stderr] 117 | (*rules).len.wrapping_sub(1u32) as [INFO] [stderr] 118 | (isize), [INFO] [stderr] 119 | ) as (i32) != [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/transmit.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | / if errno::errno() == Errno(libc::ECONNREFUSED) { [INFO] [stderr] 137 | | if (*d).udploop == 2u32 { [INFO] [stderr] 138 | | return 0i32; [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | if errno::errno() == Errno(libc::ECONNREFUSED) && (*d).udploop == 2u32 { [INFO] [stderr] 137 | return 0i32; [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/transmit.rs:444:21 [INFO] [stderr] | [INFO] [stderr] 444 | / if socket::connect4((*d).s1 - 1i32, ip, 53u16) == 0i32 { [INFO] [stderr] 445 | | if libc::send( [INFO] [stderr] 446 | | (*d).s1 - 1i32, [INFO] [stderr] 447 | | (*d).query.offset(2isize) as (*const ::libc::c_void), [INFO] [stderr] ... | [INFO] [stderr] 455 | | } [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 444 | if socket::connect4((*d).s1 - 1i32, ip, 53u16) == 0i32 && libc::send( [INFO] [stderr] 445 | (*d).s1 - 1i32, [INFO] [stderr] 446 | (*d).query.offset(2isize) as (*const ::libc::c_void), [INFO] [stderr] 447 | (*d).querylen.wrapping_sub(2u32) as (usize), [INFO] [stderr] 448 | 0i32, [INFO] [stderr] 449 | ) as (usize) == [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/txt.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | / if byte::diff( [INFO] [stderr] 59 | | header.as_mut_ptr(), [INFO] [stderr] 60 | | 2u32, [INFO] [stderr] 61 | | (*b"\0\x10\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | if byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr(), [INFO] [stderr] 60 | 2u32, [INFO] [stderr] 61 | (*b"\0\x10\0").as_ptr() as (*mut u8), [INFO] [stderr] 62 | ) == 0 && byte::diff( [INFO] [stderr] 63 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/readclose.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / if r == -1i32 { [INFO] [stderr] 29 | | if errno() == Errno(libc::EINTR) { [INFO] [stderr] 30 | | continue; [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if r == -1i32 && errno() == Errno(libc::EINTR) { [INFO] [stderr] 29 | continue; [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/tai.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | (*t).x = 4611686018427387914u64.wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `4_611_686_018_427_387_914u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | if (*t).atto > 999999999usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `999_999_999usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | (*t).atto = (*t).atto.wrapping_sub(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | if (*t).nano > 999999999usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `999_999_999usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | (*t).nano = (*t).nano.wrapping_sub(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:47:31 [INFO] [stderr] | [INFO] [stderr] 47 | ((*t).atto as (f64) * 0.000000001f64 + (*t).nano as (f64)) * 0.000000001f64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.000_000_001f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:47:70 [INFO] [stderr] | [INFO] [stderr] 47 | ((*t).atto as (f64) * 0.000000001f64 + (*t).nano as (f64)) * 0.000000001f64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.000_000_001f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | 4611686018427387914u64.wrapping_add(now.tv_sec as (usize) as (u64)) as (usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `4_611_686_018_427_387_914u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:110:48 [INFO] [stderr] | [INFO] [stderr] 110 | (*t).atto = (*t).atto.wrapping_add(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:114:48 [INFO] [stderr] | [INFO] [stderr] 114 | (*t).nano = (*t).nano.wrapping_add(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | if cachesize > 1000000000u32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000u32` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | cachesize = 1000000000u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | if d > 604800i32 as (f64) { [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | d = 604800i32 as (f64); [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | } else if datalen > 1000000u32 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | if ttl > 604800u32 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cache.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | ttl = 604800u32; [INFO] [stderr] | ^^^^^^^^^ help: consider: `604_800u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: module has the same name as its containing module [INFO] [stderr] --> src/cdb/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | mod cdb; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::module_inception)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/cdb/cdb.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / if libc::fstat(fd, &mut st as (*mut libc::stat)) == 0i32 { [INFO] [stderr] 51 | | if st.st_size as (usize) <= 0xffffffffusize { [INFO] [stderr] 52 | | x = libc::mmap( [INFO] [stderr] 53 | | 0 as *mut libc::c_void, [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | if libc::fstat(fd, &mut st as (*mut libc::stat)) == 0i32 && st.st_size as (usize) <= 0xffffffffusize { [INFO] [stderr] 51 | x = libc::mmap( [INFO] [stderr] 52 | 0 as *mut libc::c_void, [INFO] [stderr] 53 | st.st_size as (usize), [INFO] [stderr] 54 | 0x1, [INFO] [stderr] 55 | 0x1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cdb/cdb.rs:51:41 [INFO] [stderr] | [INFO] [stderr] 51 | if st.st_size as (usize) <= 0xffffffffusize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0xffff_ffffusize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cdb/hash.rs:22:43 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(hash(b"".as_ptr(), 0), 0x0001505); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0000_1505` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cdb/hash.rs:23:57 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(hash(b"Hello, world!".as_ptr(), 13), 0x564369e8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5643_69e8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/cdb/hash.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | 0x40032705 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4003_2705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/ip4.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | / if byte::diff( [INFO] [stderr] 55 | | header.as_mut_ptr(), [INFO] [stderr] 56 | | 2u32, [INFO] [stderr] 57 | | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | if byte::diff( [INFO] [stderr] 55 | header.as_mut_ptr(), [INFO] [stderr] 56 | 2u32, [INFO] [stderr] 57 | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] 58 | ) == 0 && byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/ip4.rs:60:27 [INFO] [stderr] | [INFO] [stderr] 60 | / if byte::diff( [INFO] [stderr] 61 | | header.as_mut_ptr().offset(2isize), [INFO] [stderr] 62 | | 2u32, [INFO] [stderr] 63 | | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if byte::diff( [INFO] [stderr] 61 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] 62 | 2u32, [INFO] [stderr] 63 | (*b"\0\x01\0").as_ptr() as (*mut u8), [INFO] [stderr] 64 | ) == 0 && datalen as (i32) == 4i32 { [INFO] [stderr] 65 | if packet::copy(buf, len, pos, header.as_mut_ptr(), 4u32) == 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/mx.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | / if byte::diff( [INFO] [stderr] 59 | | header.as_mut_ptr(), [INFO] [stderr] 60 | | 2u32, [INFO] [stderr] 61 | | (*b"\0\x0F\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | if byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr(), [INFO] [stderr] 60 | 2u32, [INFO] [stderr] 61 | (*b"\0\x0F\0").as_ptr() as (*mut u8), [INFO] [stderr] 62 | ) == 0 && byte::diff( [INFO] [stderr] 63 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/name.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | / if byte::diff( [INFO] [stderr] 59 | | header.as_mut_ptr(), [INFO] [stderr] 60 | | 2u32, [INFO] [stderr] 61 | | (*b"\0\x0C\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | if byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr(), [INFO] [stderr] 60 | 2u32, [INFO] [stderr] 61 | (*b"\0\x0C\0").as_ptr() as (*mut u8), [INFO] [stderr] 62 | ) == 0 && byte::diff( [INFO] [stderr] 63 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/random.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / if { [INFO] [stderr] 53 | | let _rhs = 1; [INFO] [stderr] 54 | | let _lhs = &mut IN[0usize]; [INFO] [stderr] 55 | | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | if { [INFO] [stderr] 53 | let _rhs = 1; [INFO] [stderr] 54 | let _lhs = &mut IN[0usize]; [INFO] [stderr] 55 | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] 56 | *_lhs [INFO] [stderr] 57 | } == 0 && { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/random.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / if { [INFO] [stderr] 60 | | let _rhs = 1; [INFO] [stderr] 61 | | let _lhs = &mut IN[1usize]; [INFO] [stderr] 62 | | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if { [INFO] [stderr] 60 | let _rhs = 1; [INFO] [stderr] 61 | let _lhs = &mut IN[1usize]; [INFO] [stderr] 62 | *_lhs = (*_lhs).wrapping_add(_rhs as (u32)); [INFO] [stderr] 63 | *_lhs [INFO] [stderr] 64 | } == 0 && { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/dns/random.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 124 | sum = sum.wrapping_add(0x9e3779b9u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x9e37_79b9u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:126:80 [INFO] [stderr] | [INFO] [stderr] 126 | let _rhs = (x ^ SEED[0usize]).wrapping_add(sum) ^ (x << 5i32 | x >> 32i32 - 5i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::precedence)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:132:80 [INFO] [stderr] | [INFO] [stderr] 132 | let _rhs = (x ^ SEED[1usize]).wrapping_add(sum) ^ (x << 7i32 | x >> 32i32 - 7i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:138:80 [INFO] [stderr] | [INFO] [stderr] 138 | let _rhs = (x ^ SEED[2usize]).wrapping_add(sum) ^ (x << 9i32 | x >> 32i32 - 9i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 9i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:144:81 [INFO] [stderr] | [INFO] [stderr] 144 | let _rhs = (x ^ SEED[3usize]).wrapping_add(sum) ^ (x << 13i32 | x >> 32i32 - 13i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 13i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:150:80 [INFO] [stderr] | [INFO] [stderr] 150 | let _rhs = (x ^ SEED[4usize]).wrapping_add(sum) ^ (x << 5i32 | x >> 32i32 - 5i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:156:80 [INFO] [stderr] | [INFO] [stderr] 156 | let _rhs = (x ^ SEED[5usize]).wrapping_add(sum) ^ (x << 7i32 | x >> 32i32 - 7i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:162:80 [INFO] [stderr] | [INFO] [stderr] 162 | let _rhs = (x ^ SEED[6usize]).wrapping_add(sum) ^ (x << 9i32 | x >> 32i32 - 9i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 9i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:168:81 [INFO] [stderr] | [INFO] [stderr] 168 | let _rhs = (x ^ SEED[7usize]).wrapping_add(sum) ^ (x << 13i32 | x >> 32i32 - 13i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 13i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:174:80 [INFO] [stderr] | [INFO] [stderr] 174 | let _rhs = (x ^ SEED[8usize]).wrapping_add(sum) ^ (x << 5i32 | x >> 32i32 - 5i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 5i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:180:80 [INFO] [stderr] | [INFO] [stderr] 180 | let _rhs = (x ^ SEED[9usize]).wrapping_add(sum) ^ (x << 7i32 | x >> 32i32 - 7i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 7i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:186:81 [INFO] [stderr] | [INFO] [stderr] 186 | let _rhs = (x ^ SEED[10usize]).wrapping_add(sum) ^ (x << 9i32 | x >> 32i32 - 9i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 9i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: operator precedence can trip the unwary [INFO] [stderr] --> src/dns/random.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | (x << 13i32 | x >> 32i32 - 13i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `x >> (32i32 - 13i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/rcip.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | / if iplen <= 60i32 { [INFO] [stderr] 139 | | if ip4::scan( [INFO] [stderr] 140 | | DATA.s.offset(i as (isize)) as (*const u8), [INFO] [stderr] 141 | | ip.offset(iplen as (isize)), [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if iplen <= 60i32 && ip4::scan( [INFO] [stderr] 139 | DATA.s.offset(i as (isize)) as (*const u8), [INFO] [stderr] 140 | ip.offset(iplen as (isize)), [INFO] [stderr] 141 | ) != 0 { [INFO] [stderr] 142 | if byte::diff( [INFO] [stderr] 143 | ip.offset(iplen as (isize)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/rcrw.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | / if *(*rules).s.offset( [INFO] [stderr] 111 | | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 112 | | ) as (i32) != b' ' as (i32) [INFO] [stderr] 113 | | { [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | if *(*rules).s.offset( [INFO] [stderr] 111 | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 112 | ) as (i32) != b' ' as (i32) && *(*rules).s.offset( [INFO] [stderr] 113 | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 114 | ) as (i32) != b'\t' as (i32) { [INFO] [stderr] 115 | if *(*rules).s.offset( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/rcrw.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | / if *(*rules).s.offset( [INFO] [stderr] 115 | | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 116 | | ) as (i32) != b'\t' as (i32) [INFO] [stderr] 117 | | { [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | if *(*rules).s.offset( [INFO] [stderr] 115 | (*rules).len.wrapping_sub(1u32) as (isize), [INFO] [stderr] 116 | ) as (i32) != b'\t' as (i32) && *(*rules).s.offset( [INFO] [stderr] 117 | (*rules).len.wrapping_sub(1u32) as [INFO] [stderr] 118 | (isize), [INFO] [stderr] 119 | ) as (i32) != [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/transmit.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | / if errno::errno() == Errno(libc::ECONNREFUSED) { [INFO] [stderr] 137 | | if (*d).udploop == 2u32 { [INFO] [stderr] 138 | | return 0i32; [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 136 | if errno::errno() == Errno(libc::ECONNREFUSED) && (*d).udploop == 2u32 { [INFO] [stderr] 137 | return 0i32; [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/transmit.rs:444:21 [INFO] [stderr] | [INFO] [stderr] 444 | / if socket::connect4((*d).s1 - 1i32, ip, 53u16) == 0i32 { [INFO] [stderr] 445 | | if libc::send( [INFO] [stderr] 446 | | (*d).s1 - 1i32, [INFO] [stderr] 447 | | (*d).query.offset(2isize) as (*const ::libc::c_void), [INFO] [stderr] ... | [INFO] [stderr] 455 | | } [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 444 | if socket::connect4((*d).s1 - 1i32, ip, 53u16) == 0i32 && libc::send( [INFO] [stderr] 445 | (*d).s1 - 1i32, [INFO] [stderr] 446 | (*d).query.offset(2isize) as (*const ::libc::c_void), [INFO] [stderr] 447 | (*d).querylen.wrapping_sub(2u32) as (usize), [INFO] [stderr] 448 | 0i32, [INFO] [stderr] 449 | ) as (usize) == [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/dns/txt.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | / if byte::diff( [INFO] [stderr] 59 | | header.as_mut_ptr(), [INFO] [stderr] 60 | | 2u32, [INFO] [stderr] 61 | | (*b"\0\x10\0").as_ptr() as (*mut u8), [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | if byte::diff( [INFO] [stderr] 59 | header.as_mut_ptr(), [INFO] [stderr] 60 | 2u32, [INFO] [stderr] 61 | (*b"\0\x10\0").as_ptr() as (*mut u8), [INFO] [stderr] 62 | ) == 0 && byte::diff( [INFO] [stderr] 63 | header.as_mut_ptr().offset(2isize), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/readclose.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / if r == -1i32 { [INFO] [stderr] 29 | | if errno() == Errno(libc::EINTR) { [INFO] [stderr] 30 | | continue; [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if r == -1i32 && errno() == Errno(libc::EINTR) { [INFO] [stderr] 29 | continue; [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/tai.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | (*t).x = 4611686018427387914u64.wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `4_611_686_018_427_387_914u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | if (*t).atto > 999999999usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `999_999_999usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | (*t).atto = (*t).atto.wrapping_sub(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | if (*t).nano > 999999999usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `999_999_999usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | (*t).nano = (*t).nano.wrapping_sub(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:47:31 [INFO] [stderr] | [INFO] [stderr] 47 | ((*t).atto as (f64) * 0.000000001f64 + (*t).nano as (f64)) * 0.000000001f64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.000_000_001f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:47:70 [INFO] [stderr] | [INFO] [stderr] 47 | ((*t).atto as (f64) * 0.000000001f64 + (*t).nano as (f64)) * 0.000000001f64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.000_000_001f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | 4611686018427387914u64.wrapping_add(now.tv_sec as (usize) as (u64)) as (usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `4_611_686_018_427_387_914u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:110:48 [INFO] [stderr] | [INFO] [stderr] 110 | (*t).atto = (*t).atto.wrapping_add(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/taia.rs:114:48 [INFO] [stderr] | [INFO] [stderr] 114 | (*t).nano = (*t).nano.wrapping_add(1000000000usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: aborting due to 46 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `drdns`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 49 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `drdns`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "747d428030ffc8479bef6345b763ecad7a4d6ea2526248d2acea10efdacbfed1"` [INFO] running `"docker" "rm" "-f" "747d428030ffc8479bef6345b763ecad7a4d6ea2526248d2acea10efdacbfed1"` [INFO] [stdout] 747d428030ffc8479bef6345b763ecad7a4d6ea2526248d2acea10efdacbfed1